💬 achow101 commented on pull request "Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes":
(https://github.com/bitcoin/bitcoin/pull/29050#issuecomment-2045322740)
Seems like this should be a draft

📝 achow101 converted_to_draft a pull request: "indexes: Stop using node internal types and locking cs_main, improve sync logic"
(https://github.com/bitcoin/bitcoin/pull/24230)
This PR lets indexing code mostly run outside of the node process. It also improves indexing sync logic, which is moved out of indexing code to a new [`node::SyncChain()`](https://github.com/ryanofsky/bitcoin/blob/8d8cdcb37005030f646ba3c45f7f54f556efb8bf/src/node/chain.h#L24-L39) function.

Almost all the commits in this PR are small refactoring changes that move code from `src/index/` to `src/node/`, or replace references to node types like `CBlockIndex`, `CChain`, `CChainState` in index code
...

✅ achow101 closed a pull request: "contrib/init: (OpenRC) use -daemonwait to wait for startup completion"
(https://github.com/bitcoin/bitcoin/pull/24066)

💬 achow101 commented on pull request "contrib/init: (OpenRC) use -daemonwait to wait for startup completion":
(https://github.com/bitcoin/bitcoin/pull/24066#issuecomment-2045334717)
> Are we just going to concede that the problem is unsolvable?

This PR does not seem to have conceptual support.

✅ achow101 closed a pull request: "net: call getaddrinfo() in detachable thread to prevent stalling"
(https://github.com/bitcoin/bitcoin/pull/27557)

✅ achow101 closed a pull request: "wallet: add `seeds` argument to `importdescriptors`"
(https://github.com/bitcoin/bitcoin/pull/27351)

💬 achow101 commented on pull request "wallet: add `seeds` argument to `importdescriptors`":
(https://github.com/bitcoin/bitcoin/pull/27351#issuecomment-2045348329)
The approach in this PR does not seem to have support.

⚠️ Zhouziheng3188 opened an issue: "Can't version 26.1 export Bech32 address private key?"
(https://github.com/bitcoin/bitcoin/issues/29836)
bitcoin core -v 26.1.0

Dumpprivkey instruction can't export the private key. What is the reason?


💬 maflcko commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045361385)
Only legacy wallets are supported by this command. Does `listdescriptors` work for you?

💬 achow101 commented on pull request "Introduce 'getblockfileinfo' RPC command":
(https://github.com/bitcoin/bitcoin/pull/27770#issuecomment-2045362077)
Are you still working on this?

💬 laanwj commented on pull request "security: restrict abis in bitcoind.service":
(https://github.com/bitcoin/bitcoin/pull/28340#issuecomment-2045362990)
ACK 0244416aacbad03e4ebe8f2c95c7861a318916ea . This is a sensible security feature.
It looks like [the documentation](https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html) of systemd.exec even mentions this pairing.

I do agree with @sjors, however, that when we're adding systemd hardening options, we might as well look further.

✅ achow101 closed a pull request: "Fix issues in ZMQ error handling"
(https://github.com/bitcoin/bitcoin/pull/28029)

💬 achow101 commented on pull request "Fix issues in ZMQ error handling":
(https://github.com/bitcoin/bitcoin/pull/28029#issuecomment-2045368032)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

💬 theStack commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#discussion_r1557776951)
Got rid of the "got inv" `assert_debug_log`s, the mempool reject reason is now checked with `testmempoolaccept`.

✅ achow101 closed a pull request: "wallet: Fix wallet directory initialization"
(https://github.com/bitcoin/bitcoin/pull/28514)

💬 achow101 commented on pull request "wallet: Fix wallet directory initialization":
(https://github.com/bitcoin/bitcoin/pull/28514#issuecomment-2045374108)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed an issue: "odd behaviour of GetDataDir creating wallets/ subdirectory"
(https://github.com/bitcoin/bitcoin/issues/16220)

💬 achow101 commented on issue "odd behaviour of GetDataDir creating wallets/ subdirectory":
(https://github.com/bitcoin/bitcoin/issues/16220#issuecomment-2045376507)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

💬 darosior commented on issue "odd behaviour of GetDataDir creating wallets/ subdirectory":
(https://github.com/bitcoin/bitcoin/issues/16220#issuecomment-2045376833)
Is it just that it creates a "wallets" folder even without wallets? If so it doesn't seem important.

💬 laanwj commented on pull request "Introduce 'getblockfileinfo' RPC command":
(https://github.com/bitcoin/bitcoin/pull/27770#issuecomment-2045379103)
I think this information is too low-level. In the past we've rejected changes that expose low-level information about our block storage because block files are not an external API, and exposing this kind of info limits our flexibility in regard to changing the block storage model.

I agree that it can be useful to have more transparency into pruning, however, but I'm not sure adding a RPC giving information per file is the best approach.