💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952383520)
Nice - working now.
thanks.

Perhaps worth updating the ReadMe to include the extra step?

5. tar xfz Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz

💬 paplorinc commented on issue "Proposal: Adopt simple SPDX-License-Identifier Across Bitcoin Codebase":
(https://github.com/bitcoin/bitcoin/issues/29445#issuecomment-1952396447)
The original repo still retains the git history and you're free to copy it to any other repo and modify whatever you want.

💬 maflcko commented on pull request "net: make the list of known message types a compile time constant":
(https://github.com/bitcoin/bitcoin/pull/29421#discussion_r1494531483)
I meant just for the array, for now.

```cpp
inline constexpr std::array g_all_net_message_types{std::to_array<std::string_view>({

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952428742)
Sure, but I think this should be mentioned in the doc that describes how to use the `tar.gz`, not in the doc on how to generate the `tar.gz`, or maybe just put the command in the error message?

📝 paplorinc opened a pull request: "Replace Custom `MAC_OSX` Macro with Standard `__APPLE__` for Consistent macOS Detection"
(https://github.com/bitcoin/bitcoin/pull/29450)
This PR aims to standardize and simplify macOS-specific checks within our codebase by replacing the custom-defined `MAC_OSX` macro with the universally recognized `__APPLE__`macro.

Unlike `MAC_OSX`, which is not predefined and requires manual definition, `__APPLE__` is automatically defined by the compiler on all Apple platforms, streamlining our build process.

We already use `__APPLE__` in several parts of our own codebase, such as in [tinyformat.h](https://github.com/bitcoin/bitcoin/blob
...

💬 maflcko commented on pull request "Replace Custom `MAC_OSX` Macro with Standard `__APPLE__` for Consistent macOS Detection":
(https://github.com/bitcoin/bitcoin/pull/29450#issuecomment-1952449002)
Missing `build: ` prefix in title?

💬 maflcko commented on pull request "test: add missing tests for Assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-1952480346)
You'll have to remove the TODO on the top of the file as well, when the test was added?

💬 maflcko commented on issue "test: Write assumeutxo tests":
(https://github.com/bitcoin/bitcoin/issues/28648#issuecomment-1952482196)
@paplorinc You can refer to the issue description, which says:

> Refer to the TODO comments in ./test/functional/feature_assumeutxo.py, or to the uncovered lines in the AssumeUtxo code via a coverage report. For example, https://maflcko.github.io/b-c-cov/total.coverage/src/validation.cpp.gcov.html

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952482519)
It can be in both the doc and error message if possible?

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952484352)
Sure, pull requests welcome :)

💬 furszy commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#discussion_r1494577858)
> It seems all these lines of code might be replaced with `ConfirmMessage(nullptr, 500ms);`.

That should trigger the filesystem window to dump the psbt info to a file, which would incur in another step to cancel the dialog. The idea here is to obtain the data through the clipboard only (see few lines below), not through a file.

That being said, agree that we could move this into the utility file in the future and cleanup some code.

💬 glozow commented on pull request "[26.1] final changes for 26.1rc1":
(https://github.com/bitcoin/bitcoin/pull/29440#issuecomment-1952509971)
> (Up to you if you want to fix the fuzzing, I don't need it, I just wanted to mention that the fix is missing)

Seems better to leave it as is

📝 hebasto opened a pull request: "test: Recognize dialog object by name"
(https://github.com/bitcoin-core/gui/pull/797)
Fixes https://github.com/bitcoin-core/gui/issues/796.

💬 hebasto commented on pull request "test: Recognize dialog object by name":
(https://github.com/bitcoin-core/gui/pull/797#issuecomment-1952522066)
cc @maflcko @furszy

💬 furszy commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952529363)
It is because the test is trying to access the `QMessageBox::Discard` button on a dialog that does not have a discard button. It does not happen regularly because `SendCoins()` usually confirms the `SendConfirmationDialog` dialog in less than 500ms, which destructs the dialog, only leaving the psbt dialog active by the time the timer is triggered.

🤔 furszy reviewed a pull request: "test: Recognize dialog object by name"
(https://github.com/bitcoin-core/gui/pull/797#pullrequestreview-1888508153)
Code ACK 4c9db9b587

💬 maflcko commented on pull request "assumeutxo: Get rid of faked nTx and nChainTx values":
(https://github.com/bitcoin/bitcoin/pull/29370#discussion_r1494616142)
Would need to add a suppression for now?

```
node1 stderr rpc/blockchain.cpp:1658:42: runtime error: unsigned integer overflow: 0 - 200 cannot be represented in type 'unsigned int'
#0 0x5622afcfe34c in getchaintxstats()::$_0::operator()(RPCHelpMan const&, JSONRPCRequest const&) const src/rpc/blockchain.cpp:1658:42
#1 0x5622afcfe34c in UniValue std::__invoke_impl<UniValue, getchaintxstats()::$_0&, RPCHelpMan const&, JSONRPCRequest const&>(std::__invoke_other, getchaintxstats()::$_0
...

👋 glozow's pull request is ready for review: "policy: enable sibling eviction for v3 transactions"
(https://github.com/bitcoin/bitcoin/pull/29306)

💬 hebasto commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#discussion_r1494650375)
> That will trigger the filesystem window to dump the psbt info to a file...

Why? The `ConfirmMessage` triggers the default button, which is `QMessageBox::Discard`, no?

👍 fanquake approved a pull request: "[26.1] final changes for 26.1rc1"
(https://github.com/bitcoin/bitcoin/pull/29440#pullrequestreview-1888599554)
ACK 1e7fb270d36310efff6fc968f1c52291043d461b