💬 furszy commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#discussion_r1494667687)
> > That will trigger the filesystem window to dump the psbt info to a file...
>
> Why? The `ConfirmMessage` triggers the default button, which is `QMessageBox::Discard`, no?

Yeah ok, I did not see the manual `setDefaultButton` call. That will work fine while the dialog takes less than 500ms in popping up. If it takes longer, the test will stall because `ConfirmMessage` executes runs the time only once (`QTimer::singleShot`).

💬 hebasto commented on pull request "lint: Check for missing bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29408#issuecomment-1952628049)
> Or is it more-so just to keep IWYU usable without warnings for our c-i configs specifically?

Yes. At some point in the future we might want to treat IWYU warnings as errors.

👍 hebasto approved a pull request: "refactor: bitcoin-config.h includes cleanup"
(https://github.com/bitcoin/bitcoin/pull/29404#pullrequestreview-1888622822)
ACK 9d1dbbd4ceb8c04340927f5127195dc306adf3fc, I have reviewed the code and it looks OK.

💬 Sjors commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-1952644105)
In the context of Stratum v2 #29432 I'm looking for a more efficient way to decide when to generate a new block template.

The current implementation looks at the mempool's `GetTransactionsUpdated()` every `-sv2interval` seconds. If there was any update, it calls `CreateNewBlock()` on `BlockAssembler`. It then checks if fees increased by at least `-sv2feedelta` since the last template and if so, pushes it to connected clients.

`GetTransactionsUpdated()` changes all the time, especially with
...

💬 sipa commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-1952653016)
> Would it be easy to keep track of that (approximate) number every time something is added or removed from the mempool?

After clustermempool, yes. Today doing that inherently requires running the mining algorithm to figure out what transactions to put there.

💬 Sjors commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-1952657689)
Indeed, I meant on top of this PR (or a later incarnation).

💬 hebasto commented on pull request "ci: Avoid CI failures from temp env file reuse":
(https://github.com/bitcoin/bitcoin/pull/29441#discussion_r1494723144)
This comment got outdated, no?

🚀 fanquake merged a pull request: "[26.1] final changes for 26.1rc1"
(https://github.com/bitcoin/bitcoin/pull/29440)

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952703183)
sure, will oblige.

📝 fanquake opened a pull request: "doc: document that BIP324 on by default for v27.0"
(https://github.com/bitcoin/bitcoin/pull/29452)
Addresses: https://github.com/bitcoin/bitcoin/pull/29347#issuecomment-1952335331.

💬 maflcko commented on pull request "ci: Avoid CI failures from temp env file reuse":
(https://github.com/bitcoin/bitcoin/pull/29441#discussion_r1494748529)
`git` is still installed unconditionally, otherwise, it wouldn't be present, no?

Might replace "install" with "require" if I re-touch, or in a follow-up?

👍 hebasto approved a pull request: "ci: Avoid CI failures from temp env file reuse"
(https://github.com/bitcoin/bitcoin/pull/29441#pullrequestreview-1888734489)
ACK fa91bf2559d2e839592bf1dc1d423d5fb1c3573e.

💬 maflcko commented on pull request "doc: document that BIP324 on by default for v27.0":
(https://github.com/bitcoin/bitcoin/pull/29452#issuecomment-1952731929)
lgtm ACK 0d3e18bcd6639d0752a15078d2ba76fbaaa94417

👍 theStack approved a pull request: "doc: document that BIP324 on by default for v27.0"
(https://github.com/bitcoin/bitcoin/pull/29452#pullrequestreview-1888744127)
ACK 0d3e18bcd6639d0752a15078d2ba76fbaaa94417

💬 sipa commented on pull request "doc: document that BIP324 on by default for v27.0":
(https://github.com/bitcoin/bitcoin/pull/29452#issuecomment-1952747820)
ACK 0d3e18bcd6639d0752a15078d2ba76fbaaa94417

💬 hebasto commented on pull request "RFC: build: remove confusing and inconsistent disable-asm option":
(https://github.com/bitcoin/bitcoin/pull/29407#issuecomment-1952767863)
> Our docs (developer-notes.md and fuzzing.md) mention the use of `--disable-asm` to avoid address sanitizer failures.

In the libsecp repo, the `--with-asm=no` option is still required to avoid MSan warnings. If this is a common issue for builtin assembly code, it seems possible that the `sha256_sse4.cpp` might cause similar issues in the future without an option to disable it.

Maybe gate the `sha256_sse4::Transform` function with `#if !defined(DISABLE_OPTIMIZED_SHA256)`?

🚀 glozow merged a pull request: "doc: document that BIP324 on by default for v27.0"
(https://github.com/bitcoin/bitcoin/pull/29452)

🤔 josibake reviewed a pull request: "wallet: cache IsMine scriptPubKeys to improve performance of descriptor wallets"
(https://github.com/bitcoin/bitcoin/pull/26008#pullrequestreview-1888853780)
ACK https://github.com/bitcoin/bitcoin/pull/26008/commits/e041ed9b755468d205ed48b29f6c4b9e9df8bc9f

Reviewed diff, looks good!

💬 josibake commented on pull request "Silent Payments: Implement BIP352":
(https://github.com/bitcoin/bitcoin/pull/28122#issuecomment-1952864224)
I've updated this to use https://github.com/bitcoin-core/secp256k1/pull/1471 for the cryptography needed for silent payments. This way, we don't need make any changes to `CKey`/`CPubKey` and keeps all of the low-level cryptography in `libsecp256k1`. This simplifies this PR to creating the necessary wrappers for the libsecp silent payments module and implementing the non-cryptography parts of the protocol (i.e. the client code).

Putting this PR in draft for now, until https://github.com/bitcoi
...

✅ ariard closed a pull request: "Add issuer-selected opt-in txn / pckg policy checks"
(https://github.com/bitcoin/bitcoin/pull/29448)