💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494446464)
Changed this to be `parent_entry->GetCountWithDescendants() == 2` so no grandchildren and no other siblings.

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447054)
Added an `Assume`

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447437)
Kept this and added an `Assume`, also see https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1493792426

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447595)
Done

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447749)
Done

🤔 fjahr reviewed a pull request: "rpc: improve submitpackage documentation and other improvements"
(https://github.com/bitcoin/bitcoin/pull/29292#pullrequestreview-1888244890)
utACK 5a7a7208554d09bd0a0bb8de9d4d94ed4146e739

This is ok to merge as is but if you decide to address https://github.com/bitcoin/bitcoin/pull/29292/commits/9deb9104572b4543b7135c31fbf3a34cb1f371b6#r1476296848 I will quickly re-review.

💬 fjahr commented on pull request "rpc: improve submitpackage documentation and other improvements":
(https://github.com/bitcoin/bitcoin/pull/29292#discussion_r1494441180)
Don't we check for `MAX_PACKAGE_COUNT` later on as well (so twice)? Either way, I am leaning slightly towards what @glozow asks, simply because it's nicer for the users to give helpful feedback as early as we can.

💬 fjahr commented on pull request "rpc: improve submitpackage documentation and other improvements":
(https://github.com/bitcoin/bitcoin/pull/29292#discussion_r1494445730)
nit: Might be good to stick this somewhere into the framework so it can be reused in other test, similar to the constants on top of `test_framework/messages.py`.

✅ maflcko closed an issue: "[CI/CD]Release channels?"
(https://github.com/bitcoin/bitcoin/issues/29446)

💬 maflcko commented on issue "[CI/CD]Release channels?":
(https://github.com/bitcoin/bitcoin/issues/29446#issuecomment-1952319730)
Closing for now. Let us know if you have any other questions.

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952323962)
Should have used the appropriate screenshot.

The issue is indeed puzzling, and as said I've tried various kinds of combinations with the same result.

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952331461)
"Please place the *extracted*, *untarred* SDK there"

💬 hebasto commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#discussion_r1494464086)
It seems all these lines of code might be replaced with `ConfirmMessage(nullptr, 500ms);`.

💬 maflcko commented on pull request "net: enable v2transport by default":
(https://github.com/bitcoin/bitcoin/pull/29347#issuecomment-1952335331)
Needs `bips.md` updated?

💬 fjahr commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1494466102)
Ok, I see. If the taproot activation height is removed we decide not to use that specific height at all but rather one that is around the time the BIP was proposed or even to some time around now? The specifics of the approach have been changed a lot and so even if someone already has experimented with it in the last few months the current iteration likely won't work for them to be able to spend their funds, no @josibake ? Had we discussed adding the start height as a parameter, that may be anot
...

👍 TheCharlatan approved a pull request: "refactor: bitcoin-config.h includes cleanup"
(https://github.com/bitcoin/bitcoin/pull/29404#pullrequestreview-1888286089)
ACK 9d1dbbd4ceb8c04340927f5127195dc306adf3fc

🤔 glozow reviewed a pull request: "Add issuer-selected opt-in txn / pckg policy checks"
(https://github.com/bitcoin/bitcoin/pull/29448#pullrequestreview-1888289535)
It's not really clear to me what you're trying to achieve in this PR - some kind of way for transactions to specify what their ancestor/descendant limits are? There are no tests, the CI is failing, and a lot of the code comments are incorrect/irrelevant to the adjacent lines.

I also don't really understand the motivation from the PR description. There seems to be a large number of goals and issues that aren't clearly defined. Would you mind writing something a bit clearer and more concise?

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952354717)
My apologies, but this are the steps I followed from the ReadMe page: https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction

1. apt install cpio
2. git clone https://github.com/bitcoin-core/apple-sdk-tools.git
3. python3 apple-sdk-tools/extract_xcode.py -f Xcode_15.xip | cpio -d -I
4. ./contrib/macdeploy/gen-sdk '/path/to/Xcode.app'

The resulting file from step 4 is what I've placed in the SDKs folder.

Is there another step after 4 to get untarred S
...

💬 furszy commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1952357099)
> I have also in the meantime tested a branch from @furszy which reduced migration time from 30 mins to 80 seconds 👀

That's great!
@maflcko could you also try it please?.

Branch: https://github.com/furszy/bitcoin-core/tree/2024_wallet_batch_migration_multi_insert.

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952372719)
See https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952277332