💬 Sjors commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#discussion_r1494319538)
f42e4f3b3b4b3ca1945d1ea298b443f1cecaf2ea: this only works with v1 transport. In both v2 transport and the (proposed) Stratum v2 transport (#29432) bytes on the wire need further processing to reconstruct the underlying message.

For those it's more useful to have a `GetBytes(size_t n)` helper method that waits until `n` bytes have been received.

(Specifically for the Stratum v2 I'm also trying to completely avoid a dependency on `CNetMessage`, but the design for that is still in flux)

💬 hebasto commented on issue "depends: `touch` command for creating determinstic archive timestamps fails on OpenBSD":
(https://github.com/bitcoin/bitcoin/issues/29447#issuecomment-1952130268)
> Haven't investigated deeper what `-h` exactly does

```
$ touch --help | grep -A 2 -e "-h,"
-h, --no-dereference affect each symbolic link instead of any referenced
file (useful only on systems that can change the
timestamps of a symlink)
```

💬 t-bast commented on pull request "wallet: Target a pre-defined utxo set composition by adjusting change outputs":
(https://github.com/bitcoin/bitcoin/pull/29442#issuecomment-1952151548)
@murchandamus we'd love to get your feedback on this! I'll try to summarize at a higher level what we'd like to achieve.

The `bitcoind` wallet currently tries to keep a somewhat "minimal" utxo set and actively consolidates user utxos, because it assumes that we receive transactions as much (or more) than we send transactions and wants outgoing transactions to be as cheap as possible. But that's not true of liquidity service providers, who usually only receive funds when refilling the wallet f
...

💬 naumenkogs commented on pull request "net: call `Select` with reachable networks in `ThreadOpenConnections`":
(https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1494332423)
Might as well fix ` if (new_count + tried_count == 0) return {};` above. While it seems like a bug in the existing code, it's really hard to trigger.... feeding addrman with that much garbage would be a failure probably before the size_t limit is hit :)

💬 naumenkogs commented on pull request "net: call `Select` with reachable networks in `ThreadOpenConnections`":
(https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1494214557)
3f99f5a6e58fae4981228929045ed7be32463381

Might be worth making this overflow-safe?

💬 dergoegge commented on pull request "[26.1] final changes for 26.1rc1":
(https://github.com/bitcoin/bitcoin/pull/29440#issuecomment-1952185126)
Fuzz job times out because https://github.com/bitcoin/bitcoin/pull/28933 has not been back-ported

⚠️ maflcko opened an issue: "ci_native_asan: "
(https://github.com/bitcoin-core/gui/issues/796)
Not sure if it is reproducible, but the CI task failed locally.

Commit: baed5edeb611d949982c849461949c645f8998a7

Log:

```
QDEBUG : AppTests::appTests() requestInitialize : Requesting initialize
QDEBUG : AppTests::appTests() Running initialization in thread
QDEBUG : AppTests::appTests() initializeResult : Initialization result: true
QINFO : AppTests::appTests() Platform customization: "other"
QWARN : AppTests::appTests() This plugin does not support propagateSizeHints()
QWARN :
...

💬 maflcko commented on pull request "[26.1] final changes for 26.1rc1":
(https://github.com/bitcoin/bitcoin/pull/29440#issuecomment-1952199738)
Fuzz will fail either way, because the banman fuzz target isn't updated either to include the fix.

```
fuzz: test/fuzz/banman.cpp:112: void banman_fuzz_target(FuzzBufferType): Assertion `banmap == banmap_read' failed.

💬 maflcko commented on pull request "RPC: access RPC arguments by name":
(https://github.com/bitcoin/bitcoin/pull/29277#issuecomment-1952207658)
> @stickies-v have you considered preparing a map once when an RPC is called rather than doing the search for the index every time an arg is accessed?

I doubt this will have any impact. It could even perform worse, and require more code? Also, maps aren't constexpr, so if this is moved toward constexpr/consteval, it will have to be re-written again.

💬 willcl-ark commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1952211224)
@achow101 for context my test wallet has 8016 descriptors after migration:

```fish
will@will-ubuntu in ~ : 🐍 3.11.6
₿ /home/will/src/bitcoin/src/bitcoin-cli -regtest -datadir=/media/will/PEPSI/regtest-v60000 listdescriptors | jq '.descriptors | length'
8016
```

I have also in the meantime tested a branch from @furszy which reduced migration time from 30 mins to 80 seconds 👀

💬 hebasto commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952250759)
cc @furszy

⚠️ gdiscord opened an issue: "Guix build script incorrectly reporting there is no Mac SDK"
(https://github.com/bitcoin/bitcoin/issues/29449)
Trying Guix build for the first time and hitting this seemingly unexplainable issue

macOS SDK does not exist at '/root/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers', please place the extracted, untarred SDK there to perform darwin builds, or define SDK_PATH environment variable. Exiting...

I've tried placing it in the depends folder, and the error is the same.

Makes me think I'm probably missing something that is undocumented

![Screenshot 2024-02-19 at 11 35 17](https://
...

💬 magks commented on issue "Assertion chainman().ActiveChain()[height] fails on startup on memory-constrained system":
(https://github.com/bitcoin/bitcoin/issues/29422#issuecomment-1952276380)
Just want to add that on a Raspberry PI 3B with 1 GB memory I also was running into a similiar issue during IBD however it was on testnet rather than mainnet that I got around by creating a swapfile. The PI was also running Unbound and had about 500MB free memory upon starting the IBD. The kernel would panic and upon rebooting dmesg revealed the OOM errors. So I created a swapfile and monitored with `free`. Indeed the memory filled and would occasionally dip into swap. I can't recall now what th
...

💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952277332)
Looks like you've got the SDK in `~/BITCOIN/SDKs/`, but you're telling the build script it's at `~/SDKs/` ?

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952290698)
The SDK is in ~/BITCOIN/SDKs/
I've tried various kinds of combinations also.


💬 hebasto commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952294989)
> Not sure if it is reproducible...

I can't to reproduce it.

💬 maflcko commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952299486)
You can reproduce with:


```diff
diff --git a/src/qt/test/wallettests.cpp b/src/qt/test/wallettests.cpp
index f5b86f44a6..142ec821e2 100644
--- a/src/qt/test/wallettests.cpp
+++ b/src/qt/test/wallettests.cpp
@@ -429,6 +429,7 @@ void TestGUIWatchOnly(interfaces::Node& node, TestChain100Setup& test)
}
});
timer.start(500);
+ std::this_thread::sleep_for(500ms);

// Send tx and verify PSBT copied to the clipboard.
SendCoins(*wallet.get(), sendCoinsDia
...

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#issuecomment-1952306161)
> alternative log lines are a bit noisy, but understandable and I have no good suggestions that reduce that much
> I'm not sure how important it is to return the v3 error messages if sibling RBF fails.

I've changed it to just add "(including sibling eviction)" when that is what's happening. The diff is less invasive this way, but let me know if still too clunky. I just want to avoid confusing users ("wait, why am I getting an RBF error if I didn't try to replace anything?").

✅ maflcko closed an issue: "Guix build script incorrectly reporting there is no Mac SDK"
(https://github.com/bitcoin/bitcoin/issues/29449)

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952306497)
Please read the error message carefully. Not sure what your question is.