📝 hernanmarino opened a pull request: "test: add missing tests for Assumeutxo"
(https://github.com/bitcoin/bitcoin/pull/29428)
The objective of this PR is to add some tests to the assumeUTXO logic.

The reason it is marked as Draft is because I am planning to add more (related) tests in the following days, but each commit you see in this PR CAN be reviewed now.

(If the approach of grouping related test in a single PR is undesirable, let me know and I'll split them in independent PRs )

The first test (86037415dd83da34d829f2f6bfb8dcbe08968180 as of now ) checks that snapshots with less accumulated work than the no
...

🚀 hebasto merged a pull request: "Update translation source file for v27.0 string freeze"
(https://github.com/bitcoin-core/gui/pull/793)

💬 maflcko commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1942447314)
Not sure how to create a flame-graph, since it takes too long. But it may be eating time in `fdatasync` in

```
#9 0x0000559cb227c624 in wallet::SQLiteBatch::TxnCommit (this=0x7f5b24178fc0) at wallet/sqlite.cpp:668
#10 0x0000559cb21cff66 in wallet::DescriptorScriptPubKeyMan::TopUp (this=0x7f5b24178970, size=<optimized out>) at wallet/scriptpubkeyman.cpp:2148
#11 0x0000559cb21cb6d3 in wallet::LegacyScriptPubKeyMan::MigrateToDescriptor (this=0x7f5b24ee3900) at wallet/scriptpubkeyman.cpp:1925
...

💬 achow101 commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1942457440)
@maflcko Can you provide any more details about the wallet? The output of `getwalletinfo` would be helpful.

💬 hernanmarino commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942479877)
I'm a little late but, in order to collaborate with this in the future what exactly should I be diffing ? between what branches/ files ? Thanks

💬 maflcko commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1942482242)
It is just a normal wallet:

```
{
"walletname": "-1707752467.legacy.bak-1707848638.legacy.bak-1707849652.legacy.bak-1707855504.legacy.bak",
"walletversion": 60000,
"format": "bdb",
"balance": 1.26999586,
"unconfirmed_balance": 0.00000000,
"immature_balance": 0.00000000,
"txcount": 661,
"keypoololdest": 1515426721,
"keypoolsize": 999,
"unlocked_until": 0,
"paytxfee": 0.00000000,
"private_keys_enabled": true,
"avoid_reuse": false,
"scanning": false,

...

💬 achow101 commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1942484980)
How long does it take to migrate if you just let it complete?

💬 maflcko commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1942542460)
Ok, I can try that. I wonder if anyone else can try the HDD+BDB combo to double check. Or if really no one else has a HDD+BDB for testing, it can be declared unsupported?

⚠️ 124maa opened an issue: "I don't think we should add a lock icon or something like that; there are significant benefits of having encrypted connections on a large scale, but users in general shouldn't assume that their specific connections are more secure for their specific purposes when they're v2."
(https://github.com/bitcoin-core/gui/issues/794)
I don't think we should add a lock icon or something like that; there are significant benefits of having encrypted connections on a large scale, but users in general shouldn't assume that their specific connections are more secure for their specific purposes when they're v2.

_Originally posted by @sipa in https://github.com/bitcoin-core/gui/issues/754#issuecomment-1713750890_

✅ 124maa closed an issue: "I don't think we should add a lock icon or something like that; there are significant benefits of having encrypted connections on a large scale, but users in general shouldn't assume that their specific connections are more secure for their specific purposes when they're v2."
(https://github.com/bitcoin-core/gui/issues/794)

✅ brunoerg closed a pull request: "addrman: delete addresses that don't belong to the supported networks"
(https://github.com/bitcoin/bitcoin/pull/29330)

💬 brunoerg commented on pull request "addrman: delete addresses that don't belong to the supported networks":
(https://github.com/bitcoin/bitcoin/pull/29330#issuecomment-1942641832)
I'll close this PR to work on a "less aggressive" approach (extending `Select` to support multiple networks). I will provide my benchmarks on that new PR.

Thanks, @vasild @mzumsande @naumenkogs @amitiuttarwar.

💬 hernanmarino commented on pull request "wallet: Allow user to navigate options while encrypting at creation":
(https://github.com/bitcoin-core/gui/pull/722#issuecomment-1942673140)
Rebased for CI, no actual code changes in my code.

💬 brunoerg commented on pull request "test: merge banning test from p2p_disconnect_ban to rpc_setban":
(https://github.com/bitcoin/bitcoin/pull/26863#issuecomment-1942677223)
Rebased

💬 pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942681474)
@hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.

💬 pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488634834)
True, I'll re-phrase it, thank you!

💬 pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488635819)
Agreed.

🤔 furszy reviewed a pull request: "rpc: Drop migratewallet experimental warning"
(https://github.com/bitcoin/bitcoin/pull/28037#pullrequestreview-1879022384)
Is the chain sync, reindex or any indexing procedure taking that long as well?

🤔 hernanmarino reviewed a pull request: "cli: improve error message on multiwallet and add validation to cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1879030432)
re ACK fa48d460334beef43fa73455aa9e30971d33c1b2
Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.
Also, and although not invalidating for me , I think that @jonatack 's suggestions are worth following.

👍 hernanmarino approved a pull request: "assumeutxo, rpc: Improve EOF error when reading snapshot metadata in loadtxoutset"
(https://github.com/bitcoin/bitcoin/pull/28670#pullrequestreview-1879041794)
Approach ACK