💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1942756439)
> re ACK [fa48d46](https://github.com/bitcoin/bitcoin/commit/fa48d460334beef43fa73455aa9e30971d33c1b2) Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.

Yeah, there was an unconscious typo somewhere since the beginning and I think it's what @jonatack meant on his [latest review](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) as well.

> Also, and although not invalidating for me , I think that @jo
...

💬 hernanmarino commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942759563)
> @hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md?rgh-link-date=2024-02-13T21%3A47%3A53Z) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.

I read the guide (and your PR) and it doesn´t mention what branches/commits/files to diff

I performed a diff on th PR branch after the make ins
...

💬 pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942782943)
I think you don't need to run [the python script](https://github.com/bitcoin/bitcoin/pull/29397#pullrequestreview-1868440624) cos that core PR I mentioned above was already merged on this `gui` repo before this PR and since this PR is now merged too, you would need to perform just the `make` command on `master` before this PR.

📝 xavier6 opened a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.

✅ fanquake closed a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)

📝 fanquake locked a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.

📝 xavier6 opened a pull request: "Add Opentimestamps Verity"
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".

💬 xavier6 commented on pull request "Add Opentimestamps Verity":
(https://github.com/bitcoin/bitcoin/pull/29430#issuecomment-1943080114)
Hopefully it works!

✅ achow101 closed a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)

📝 achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".

💬 kevkevinpal commented on pull request "mempool: Log added for dumping mempool transactions to disk":
(https://github.com/bitcoin/bitcoin/pull/29402#discussion_r1488897358)
updated in this commit [b9f449b](https://github.com/bitcoin/bitcoin/pull/29402/commits/b9f449b2d0637c09fd8dc3f44078355827af4a92)

💬 kevkevinpal commented on pull request "mempool: Log added for dumping mempool transactions to disk":
(https://github.com/bitcoin/bitcoin/pull/29402#discussion_r1488899166)
I think this is what you are talking about unless I'm getting confused [b9f449b](https://github.com/bitcoin/bitcoin/pull/29402/commits/b9f449b2d0637c09fd8dc3f44078355827af4a92)

the <util/fs.h> includes is already imported but I added `fs::` before `file_size`

💬 DoctorBuzz1 commented on issue "Move from Static Dust Limit [330 / 546 sats] to Variable Dust Limit [= to TxFee]":
(https://github.com/bitcoin/bitcoin/issues/29423#issuecomment-1943222606)
Rate limit the spam, which is overtaking the monetary use-case of Bitcoin, and the batch Txs like you suggest wouldn't be a real problem. It's only a problem when the spam continues to jack up fees for no legit reason. See here: https://twitter.com/DoctorBuzz1/status/1757659895426330648

Even in the current fee market, I think it would be tough to find a legit batch Tx that would be triggered by this change, considering the savings mentioned in your link. And even if you COULD find an exam
...

💬 jadijadi commented on issue "Weird focus rect displayed on inital sync":
(https://github.com/bitcoin-core/gui/issues/783#issuecomment-1943256980)
Thanks for the explanation. I can reproduce and will work on it today.

💬 maflcko commented on pull request "rpc: Drop migratewallet experimental warning":
(https://github.com/bitcoin/bitcoin/pull/28037#issuecomment-1943262513)
Not sure. I am using the spinning storage only to test `migratewallet`. It finished after 2 hours.

I don't want to block this pull request, but I wanted to share what I am seeing when running the migration on a slow storage. Migration is a one-time cost, so I'll leave it up to others whether to improve it, and by how much. However, if `migratewallet` is expected to take long for other wallets if they reside on slow storage, it may be good to add a note to the RPC? Something like, "Depending o
...

💬 ArmchairCryptologist commented on issue "Move from Static Dust Limit [330 / 546 sats] to Variable Dust Limit [= to TxFee]":
(https://github.com/bitcoin/bitcoin/issues/29423#issuecomment-1943280826)
If we wanted to revamp the dust threshold to, say, increase the cost of ordinals/inscriptions and stop people from junking up the UTXO set without significantly affecting normal usage, a more compatible solution might be to define it as a UTXO that cannot be economically spent at the fee level of the transaction creating it (or a multiplier of said fee), rather than basing it on the total fee of the transaction.

Of course, seeing as we cannot in general know exactly how much data is required
...

💬 maflcko commented on pull request "mempool: Log added for dumping mempool transactions to disk":
(https://github.com/bitcoin/bitcoin/pull/29402#discussion_r1489094999)
No, I don't think this was addressed?

📝 stratospher opened a pull request: "test/BIP324: disconnection scenarios during v2 handshake"
(https://github.com/bitcoin/bitcoin/pull/29431)
Add tests for the following v2 handshake scenarios:
1. Disconnection happens when > `MAX_GARBAGE_LEN` bytes garbage is sent
2. Disconnection happens when incorrect garbage terminator is sent
3. Disconnection happens when garbage bytes are tampered with
4. Disconnection happens when AAD of first encrypted packet after the garbage terminator is not filled
5. bitcoind ignores non-empty version packet and no disconnection happens

All these tests require a modified v2 P2P class (different fro
...

💬 hebasto commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1943421925)
@hernanmarino

> I'm a little late but, in order to collaborate with this in the future what exactly should I be diffing ? between what branches/ files ? Thanks

Thank you for your interest!

Here are all steps to verify this PR (and similar ones in the future):
```
git fetch origin pull/793/head
git checkout FETCH_HEAD
make -C depends -j $(nproc)
./autogen.sh
./configure CONFIG_SITE=$PWD/depends/x86_64-pc-linux-gnu/share/config.site # Use the corresponding path if building on macO
...

💬 hebasto commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1489222081)
Because it is outdated.