💬 maflcko commented on pull request "Update doc/policy/README.md":
(https://github.com/bitcoin/bitcoin/pull/29095#issuecomment-1859154827)
> table with them all somewhere instead?


Are they not listed in the `-help` already? There is even a category for them, no?

📝 fanquake locked a pull request: "ci: uninstall aws-sam-cli"
(https://github.com/bitcoin/bitcoin/pull/29092)
Test alternative to #29080.

📝 LarryRuane converted_to_draft a pull request: "test: test_bitcoin: allow -testdatadir=<datadir>"
(https://github.com/bitcoin/bitcoin/pull/26564)
This backward-compatible change would help with code review and testing. When `test_bitcoin` runs, it creates a working or data directory within `/tmp/test_common_Bitcoin\ Core/`, named as a long random (hex) string.

This small patch does three things:

- If the (new) argument `-testdatadir=<datadir>` is given, it replaces the random string path component with this argument as the test's working directory
- When the test starts, remove the working directory if it exists from an earlier run
...

💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#issuecomment-1859181762)
Ran same hyperfine benchmark with base, 985ddd954199cb7686ac75d12492d25b16d235c8, and head of branch. Got similar results :rocket:.

```
Summary
./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = ceeb71816512642e92a110b2cf5d2549d090fe78) ran
1.06 ± 0.00 times faster than ./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = 985ddd954199cb7686ac75d12492d25b16d235c8)
1.07 ± 0.00 times faster th
...

💬 conduition commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1859227102)
> The point of "fighting the spam TXs" is not to prevent all forms of data inscription at all costs, it's to fix Bitcoin's fee market. The crux of the problem as described https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852569550 and https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852673575 is that inscriptions dramatically overpay fees by design and thus price out large segments of Bitcoin transactors at very little absolute cost, thus degrading the monetary properties o
...

💬 Thanos107 commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1859236241)
This is my first real contribution and I would like to contribute to the Blockchain/Bitcoin Space.

I just wanted to ask if I have to create a new Readme file in the Docs folder or change an existing file.

💬 luke-jr commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1429227673)
```suggestion
return NonStandardInputReason{"bad-txns-input-script-unknown", strprintf("input %u", i)};
```

💬 luke-jr commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1429228453)
```suggestion
return NonStandardInputReason{"bad-txns-input-scriptcheck-missing", strprintf("input %u", i)};
```

💬 Retropex commented on pull request "NOMERGE UFG Default permitbaremultisig=0":
(https://github.com/bitcoin/bitcoin/pull/29093#issuecomment-1859240676)
@fanquake @ajtowns Now that the PR is open, do I have to do anything else to make it eligible for a merge?

📝 Thanos107 opened a pull request: "Explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/pull/29101)
I have explained about the Wallet Password in this pull request.

I dealt with the open issue of "How wallet password works and does"

Explained how,

it is not the seed
it does not protect against a 5$ wrench
it might protect against a stranger walking up to an unlocked screen with a Bitcoin Core wallet running
it doesn't encrypt metadata or pubkeys
it results in loss of funds if the password is too complex and forgotten

Eager to hear from you.

📝 SatoshiNT0 opened a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)

📝 fanquake locked a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240654)
No such thing

💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240754)
No such thing

💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240500)
What?

👍 luke-jr approved a pull request: "Fix: Ensure 'Transaction View' remains disabled if no wallet is selected"
(https://github.com/bitcoin-core/gui/pull/780#pullrequestreview-1785495190)
utACK

💬 luke-jr commented on pull request "[26.x] Backports":
(https://github.com/bitcoin/bitcoin/pull/29011#issuecomment-1859252584)
7e90b5938f4dbdba58355f55f785c9054055a912 has a typo in the commit message

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#issuecomment-1859275939)
concept ACK [ef8ed8](https://github.com/bitcoin/bitcoin/commit/ef8ed8c973b2a48ccff54e4443a88e876d210bcf)

💬 darosior commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1429274748)
Worth adding a comment here, it's not immediate that this assertion would never fail because `MAX_BLOCKTXN_DEPTH < MIN_BLOCKS_TO_KEEP`.