Bitcoin Core Github
43 subscribers
122K links
Download Telegram
⚠️ conduition opened an issue: "rpc: decodescript fails for witness scripts with length larger than uint16"
(https://github.com/bitcoin/bitcoin/issues/29103)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Decoding scripts fails for large scripts with lengths greater than `0xFFFF`. [See this inscription transaction for an example](https://mempool.space/tx/36ef4b89daa22096575c08844823375753dc8be4e4890a30ac8defde1c1a9e7a) which bitcoin core cannot decode.



### Expected behaviour

Any script that can be included in a taproot witness should be decodable by bitcoin core.

### Steps to reprodu
...
💬 sipa commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859344127)
This is a limitation of your shell (`bash`), not Bitcoin Core.

You can use the `-stdin` argument to `bitcoin-cli` to pass it arguments that don't fit on the command line of your system.
conduition closed an issue: "rpc: decodescript fails for witness scripts with length larger than uint16"
(https://github.com/bitcoin/bitcoin/issues/29103)
💬 conduition commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859344891)
Ah my apologies. I misunderstood the error.
📝 Aminkavoos opened a pull request: "23.x"
(https://github.com/bitcoin/bitcoin/pull/29104)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
💬 Aminkavoos commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1859359011)
****
achow101 closed a pull request: "23.x"
(https://github.com/bitcoin/bitcoin/pull/29104)
📝 achow101 locked a pull request: "23.x"
(https://github.com/bitcoin/bitcoin/pull/29104)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
⚠️ FU3X opened an issue: "Any plans to implement the concepts Kaspa has?"
(https://github.com/bitcoin/bitcoin/issues/29105)
### Please describe the feature you'd like to see added.

Take on the ideas Kaspa has done?

### Is your feature related to a problem, if so please describe it.

Scalability

### Describe the solution you'd like

Processing multiple blocks at a time?

### Describe any alternatives you've considered

Just using Kaspa

### Please leave any additional context

_No response_
👍 jaonoctus approved a pull request: "rpc: Optimize serialization disk space of dumptxoutset"
(https://github.com/bitcoin/bitcoin/pull/26045#pullrequestreview-1785932484)
Concept ACK

Tested on testnet and regtest, works as expected
💬 TheCharlatan commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429615733)
This is a ChatGPT generated text.
💬 S3RK commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1859720008)
@Thanos107 #28974 already addresses this issue. Maybe you want to take a look at another one?
💬 Thanos107 commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429642554)
Actually, yeah. I used Chatgpt to refine it.

Should I not have done that?

Actually, this is my first pull request, so I don't have any idea how this works.

I will remove this pull request and push another one if that's okay with you.
maflcko closed an issue: "Any plans to implement the concepts Kaspa has?"
(https://github.com/bitcoin/bitcoin/issues/29105)
💬 maflcko commented on issue "Any plans to implement the concepts Kaspa has?":
(https://github.com/bitcoin/bitcoin/issues/29105#issuecomment-1859834282)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

Network-wide consensus and/or P2P changes first need to be discussed with the greater community, for example the `bitcoin-dev` maili
...
💬 maflcko commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859838225)
See also https://github.com/bitcoin/bitcoin/issues?q=is%3Aissue+%22Argument+list+too+long%22+is%3Aclosed
💬 Sjors commented on pull request "wallet, mempool: propagete `checkChainLimits` error message to wallet":
(https://github.com/bitcoin/bitcoin/pull/28863#discussion_r1429730115)
Indeed, or it could even be done as part of that PR. It depends on which one gets merged first.
💬 maflcko commented on pull request "NOMERGE UFG Default permitbaremultisig=0":
(https://github.com/bitcoin/bitcoin/pull/29093#issuecomment-1859845096)
If you want to learn more about contributing to Bitcoin Core, you can refer to the `CONTRIBUTING.md` file, which should answer any questions.
💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1429782917)
Nice :+1: