🤔 pablomartin4btc reviewed a pull request: "Wallet: Calculate used balance from GetBalance(...)"
(https://github.com/bitcoin/bitcoin/pull/29062#pullrequestreview-1785308728)
Concept ACK

💬 pablomartin4btc commented on pull request "Wallet: Calculate used balance from GetBalance(...)":
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1428925448)
What about caculating `avoid_reuse` locally (e.g. `const bool avoid = !(m_wallet->IsWalletFlagSet(WALLET_FLAG_AVOID_REUSE));` at the beginning of the function), instead of passing it? I thought @achow101's [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was referring to include that too but maybe I'm wrong.

💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428946493)
The purpose of `ReallocateCache` originally was to balance the snapshot and background chainstate caches (see https://github.com/bitcoin/bitcoin/pull/18637). However, in https://github.com/bitcoin/bitcoin/pull/25325/commits/5e4ac5abf54f8e6d6330df0c73119aa0cca4c103 this function was removed from `ResizeCoinsCaches` and moved to `Flush`. This created an implicit assumption that calling `Flush` would clear the memory in the cache. This change violates that assumption, since the memory will no longe
...

💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#discussion_r1428961040)
Should this parameter be added to the fuzz targets or unit tests?

🤔 luke-jr reviewed a pull request: "versionbits refactoring"
(https://github.com/bitcoin/bitcoin/pull/29039#pullrequestreview-1785323162)
Concept NACK, refactoring without a purpose, and probably makes more work for merging BIP8.

📝 SatoshiNT0 opened a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***


Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...

🤔 SatoshiNT0 reviewed a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099#pullrequestreview-1785331767)
That must be the correct MIT license. Because it was taken from my original project.

✅ achow101 closed a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)

📝 achow101 locked a pull request: "Update COPYING"
(https://github.com/bitcoin/bitcoin/pull/29099)
<!--
That must be the correct MIT license. Because it was taken from my original project.
*** Please remove the following help text before submitting: ***


Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core
...

💬 BrandonOdiwuor commented on pull request "Wallet: Calculate used balance from GetBalance(...)":
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1429014044)
> have it always compute the used balance for us rather than having the caller do this extra computation.

My understanding of this part of @achow101 [comment](https://github.com/bitcoin/bitcoin/pull/28776/files#r1407875236) was to move the calculation for the `used` balance to `GetBalance(...)`

I have updated the PR and added `GetFullBalance()` which adds `used` balance to `GetBalance(...)`

📝 gosu93 opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29100)

📝 achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29100)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 maflcko commented on pull request "Update doc/policy/README.md":
(https://github.com/bitcoin/bitcoin/pull/29095#issuecomment-1859154827)
> table with them all somewhere instead?


Are they not listed in the `-help` already? There is even a category for them, no?

📝 fanquake locked a pull request: "ci: uninstall aws-sam-cli"
(https://github.com/bitcoin/bitcoin/pull/29092)
Test alternative to #29080.

📝 LarryRuane converted_to_draft a pull request: "test: test_bitcoin: allow -testdatadir=<datadir>"
(https://github.com/bitcoin/bitcoin/pull/26564)
This backward-compatible change would help with code review and testing. When `test_bitcoin` runs, it creates a working or data directory within `/tmp/test_common_Bitcoin\ Core/`, named as a long random (hex) string.

This small patch does three things:

- If the (new) argument `-testdatadir=<datadir>` is given, it replaces the random string path component with this argument as the test's working directory
- When the test starts, remove the working directory if it exists from an earlier run
...

💬 andrewtoth commented on pull request "sync: improve CCoinsViewCache ReallocateCache":
(https://github.com/bitcoin/bitcoin/pull/28945#issuecomment-1859181762)
Ran same hyperfine benchmark with base, 985ddd954199cb7686ac75d12492d25b16d235c8, and head of branch. Got similar results :rocket:.

```
Summary
./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = ceeb71816512642e92a110b2cf5d2549d090fe78) ran
1.06 ± 0.00 times faster than ./src/bitcoind -dbcache=500 -reindex-chainstate -printtoconsole=0 -stopatheight=500000 (commit = 985ddd954199cb7686ac75d12492d25b16d235c8)
1.07 ± 0.00 times faster th
...

💬 conduition commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1859227102)
> The point of "fighting the spam TXs" is not to prevent all forms of data inscription at all costs, it's to fix Bitcoin's fee market. The crux of the problem as described https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852569550 and https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852673575 is that inscriptions dramatically overpay fees by design and thus price out large segments of Bitcoin transactors at very little absolute cost, thus degrading the monetary properties o
...

💬 Thanos107 commented on issue "doc: Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/issues/18085#issuecomment-1859236241)
This is my first real contribution and I would like to contribute to the Blockchain/Bitcoin Space.

I just wanted to ask if I have to create a new Readme file in the Docs folder or change an existing file.

💬 luke-jr commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1429227673)
```suggestion
return NonStandardInputReason{"bad-txns-input-script-unknown", strprintf("input %u", i)};
```