Bitcoin Core Github
43 subscribers
122K links
Download Telegram
💬 luke-jr commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r1429228453)
```suggestion
return NonStandardInputReason{"bad-txns-input-scriptcheck-missing", strprintf("input %u", i)};
```
💬 Retropex commented on pull request "NOMERGE UFG Default permitbaremultisig=0":
(https://github.com/bitcoin/bitcoin/pull/29093#issuecomment-1859240676)
@fanquake @ajtowns Now that the PR is open, do I have to do anything else to make it eligible for a merge?
📝 Thanos107 opened a pull request: "Explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/pull/29101)
I have explained about the Wallet Password in this pull request.

I dealt with the open issue of "How wallet password works and does"

Explained how,

it is not the seed
it does not protect against a 5$ wrench
it might protect against a stranger walking up to an unlocked screen with a Bitcoin Core wallet running
it doesn't encrypt metadata or pubkeys
it results in loss of funds if the password is too complex and forgotten

Eager to hear from you.
📝 SatoshiNT0 opened a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
fanquake closed a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)
📝 fanquake locked a pull request: "That must be the correct MIT license. Because it was taken from my original project."
(https://github.com/bitcoin/bitcoin/pull/29102)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240654)
No such thing
💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240754)
No such thing
💬 luke-jr commented on pull request "Explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/29101#discussion_r1429240500)
What?
👍 luke-jr approved a pull request: "Fix: Ensure 'Transaction View' remains disabled if no wallet is selected"
(https://github.com/bitcoin-core/gui/pull/780#pullrequestreview-1785495190)
utACK
💬 luke-jr commented on pull request "[26.x] Backports":
(https://github.com/bitcoin/bitcoin/pull/29011#issuecomment-1859252584)
7e90b5938f4dbdba58355f55f785c9054055a912 has a typo in the commit message
💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#issuecomment-1859275939)
concept ACK [ef8ed8](https://github.com/bitcoin/bitcoin/commit/ef8ed8c973b2a48ccff54e4443a88e876d210bcf)
💬 darosior commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1429274748)
Worth adding a comment here, it's not immediate that this assertion would never fail because `MAX_BLOCKTXN_DEPTH < MIN_BLOCKS_TO_KEEP`.
⚠️ conduition opened an issue: "rpc: decodescript fails for witness scripts with length larger than uint16"
(https://github.com/bitcoin/bitcoin/issues/29103)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Decoding scripts fails for large scripts with lengths greater than `0xFFFF`. [See this inscription transaction for an example](https://mempool.space/tx/36ef4b89daa22096575c08844823375753dc8be4e4890a30ac8defde1c1a9e7a) which bitcoin core cannot decode.



### Expected behaviour

Any script that can be included in a taproot witness should be decodable by bitcoin core.

### Steps to reprodu
...
💬 sipa commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859344127)
This is a limitation of your shell (`bash`), not Bitcoin Core.

You can use the `-stdin` argument to `bitcoin-cli` to pass it arguments that don't fit on the command line of your system.
conduition closed an issue: "rpc: decodescript fails for witness scripts with length larger than uint16"
(https://github.com/bitcoin/bitcoin/issues/29103)
💬 conduition commented on issue "rpc: decodescript fails for witness scripts with length larger than uint16":
(https://github.com/bitcoin/bitcoin/issues/29103#issuecomment-1859344891)
Ah my apologies. I misunderstood the error.
📝 Aminkavoos opened a pull request: "23.x"
(https://github.com/bitcoin/bitcoin/pull/29104)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
💬 Aminkavoos commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1859359011)
****