💬 RandyMcMillan commented on pull request "Make provably unsignable standard P2PK and P2MS outpoints unspendable.":
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1856492483)
Concept ACK

⚠️ sarthak13gupta opened an issue: "Not able to build and compile on macos"
(https://github.com/bitcoin/bitcoin/issues/29083)
Hey there , I'm facing these issues.
I ran these commands

`./autogen.sh`
`./configure --disable-bench --disable-fuzz-binary --enable-debug --without-gui --enable-suppress-external-warnings`
` make`




<img width="1440" alt="Screenshot 2023-12-15 at 1 02 35 AM" src="https://github.com/bitcoin/bitcoin/assets/74540123/8d96fcda-36c0-4a06-934f-a83e9a96b543">
<img width="1434" alt="Screenshot 2023-12-15 at 1 02 48 AM" src="https://github.com/bitcoin/bitcoin/assets/74540123/0656acd4
...

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856500865)
Did you run `make clean`?

💬 achow101 commented on pull request "Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly":
(https://github.com/bitcoin/bitcoin/pull/28051#issuecomment-1856505048)
ACK 6db04be102807ee0120981a9b8de62a55439dabb

Code seems fine, but I'm not familiar enough with this area to say whether this is the right approach or if there are any side effects that haven't been thought of.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856510625)
Yes I have tried that.

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856514195)
What is your operating system and architecture? Where did you get BDB from?

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856514918)
Do you need BDB? If not, you can disable it with `--without-bdb`.

💬 hebasto commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856517075)
What is the `./configure` script summary?

💬 maflcko commented on pull request "fuzz: Improve fuzzing stability for minisketch harness":
(https://github.com/bitcoin/bitcoin/pull/29064#issuecomment-1856517924)
review ACK b2fc7a2eda103724ac8cbeaf99df3ce6f5b7d974

🚀 achow101 merged a pull request: "Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly"
(https://github.com/bitcoin/bitcoin/pull/28051)

👋 dergoegge's pull request is ready for review: "fuzz: Improve fuzzing stability for minisketch harness"
(https://github.com/bitcoin/bitcoin/pull/29064)

✅ LeoSpyke closed an issue: "test: `feature_index_prune.py` timeout failure"
(https://github.com/bitcoin/bitcoin/issues/29082)

💬 LeoSpyke commented on issue "test: `feature_index_prune.py` timeout failure":
(https://github.com/bitcoin/bitcoin/issues/29082#issuecomment-1856519929)
Setting `--timeout-factor=2` did the trick.
Thank you @maflcko.

⚠️ hebasto opened an issue: "`security-check.py` produces false positive result for stack smashing protection"
(https://github.com/bitcoin/bitcoin/issues/29084)
I'm aware that `test-security-check.py` tests both cases `-fno-stack-protector` and `-fstack-protector-all`.

However, the `security-check.py` passes in the master branch @ 986047170892c9482ccbc21f05bf4f1499b3089d with the diff as follows:
```diff
--- a/configure.ac
+++ b/configure.ac
@@ -935,7 +935,7 @@ fi
if test "$use_hardening" != "no"; then
use_hardening=yes
AX_CHECK_COMPILE_FLAG([-Wstack-protector], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -Wstack-protector"])
- AX_CHECK_CO
...

💬 fanquake commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1856530747)
Probably because our GCC in guix is passing stack protection flags by default?

💬 hebasto commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1856532058)
> Probably because our GCC in guix is passing stack protection flags by default?

Shouldn't `-fno-stack-protector` override compiler's defaults?

💬 hebasto commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1856533170)
> Probably because our GCC in guix is passing stack protection flags by default?

Why does the `test-security-check.py` pass then?

💬 jonatack commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856534079)
Can also try `make distclean` and then rebuild.

If that doesn't work, or if you are seeing linker issues, the header and compilation might be out of sync and you may want to ensure that you are building from a clean tree. If you are using ccache, try clearing the cache by running `ccache -C` (see ccache -h for help) and then rebuilding.

If that doesn't solve it, you can also run `git clean -f -x -d` and rebuild. This wipes everything in the tree that doesn't belong to git, so be careful th
...

💬 fanquake commented on issue "`security-check.py` produces false positive result for stack smashing protection":
(https://github.com/bitcoin/bitcoin/issues/29084#issuecomment-1856538009)
Probably because the toolchain is built hardened, so any test bin still has the stack protection symbol coming from glibc or similar.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856542633)
> What is your operating system and architecture? Where did you get BDB from?

MacOS 13.0 Arm64 architechture . I tried installing BDB using homebrew while following the docs -> https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md