👍 stickies-v approved a pull request: "refactor: Remove pre-C++20 code, fs::path cleanup"
(https://github.com/bitcoin/bitcoin/pull/29040#pullrequestreview-1782682980)
re-ACK 66667130416b86208e01a0eb5541a15ea805ac26

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856548573)
> MacOS 13.0 Arm64 architechture . I tried installing BDB using homebrew while following the docs -> https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md

Can you try to re-install it, and check that it installs it for arm64? Otherwise, if you don't need it, you can disable it by passing `--without-bdb` to `./configure`.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856555215)
> What is the `./configure` script summary?

I don't exactly understand it but this is what i got after running the ./configure command.
https://gist.github.com/sarthak13gupta/6ab7cf9b402a3695b20da574a5957804

💬 murchandamus commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856559034)
> ```diff
> @@ -128,7 +128,7 @@ FUZZ_TARGET(coinselection)
> auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :
> SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
> if (result_bnb) {
> - assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);
> + assert(result_bnb->GetChange(coin_params.min_viable_change, coin_para
...

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856559437)
> > MacOS 13.0 Arm64 architechture . I tried installing BDB using homebrew while following the docs -> https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md
>
> Can you try to re-install it, and check that it installs it for arm64? Otherwise, if you don't need it, you can disable it by passing `--without-bdb` to `./configure`.

I don't think I need it currently.
Do I need to add anything else in this line
`./configure --disable-bench --disable-fuzz-binary --enable-debug --witho
...

💬 hebasto commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856564277)
@sarthak13gupta

Did you move your macOS from x86_64 (Intel) to a new Apple Silicon based one?

(I saw a similar issue back then)

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856564856)
> Do I need to add anything else in this line


Yes, that sounds good. The configure should then print, just to confirm:


```diff
Options used to compile and link:
external signer = yes
multiprocess = no
with libs = yes
with wallet = yes
with sqlite = yes
- with bdb = yes
+ with bdb = no
with gui / qt = no
with zmq = yes
with test = yes
with fuzz binary = no
with bench = no
with upnp = no
wi
...

💬 achow101 commented on pull request "wallet: birth time update during tx scanning":
(https://github.com/bitcoin/bitcoin/pull/28920#issuecomment-1856566954)
> Should we backport [6f49737](https://github.com/bitcoin/bitcoin/commit/6f497377aa17cb8a590fd7717fa8ededf4249999) or the whole PR, and if so how far?

I think it would be good to backport the entire thing.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856567568)
> @sarthak13gupta
>
> Did you move your macOS from x86_64 (Intel) machine to a new Apple Silicon based one?
>
> (I saw a similar issue back then)

Nope it's an m1 so I guess that would be arm64 since the start.

💬 hebasto commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856580214)
If nothing else helps, I would suggest to remove and reinstall Homebrew from scratch.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856587924)
The issue persists... this is what I'm getting after running
`./configure`
https://gist.github.com/sarthak13gupta/6ab7cf9b402a3695b20da574a5957804
and
`make`
https://gist.github.com/sarthak13gupta/a993a3f2eb2183b32c1e6042fe7d96db
commands.
also, another command used initially was `git checkout v26.0` to checkout to 26.0

Also, should I reinstall command line tools as well, given the issue below?
<img width="1256" alt="Screenshot 2023-12-15 at 2 32 40 AM" src="https://github.com/bit
...

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856597168)
For reference, the configure output seems to target x86:

```
% ./configure --disable-bench --disable-fuzz-binary --enable-debug --without-gui --enable-suppress-external-warnings --without-bdb
checking for pkg-config... /opt/homebrew/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking build system type... x86_64-apple-darwin22.1.0
checking host system type... x86_64-apple-darwin22.1.0
...

💬 fanquake commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856600045)
You said you're running on arm, but configure says otherwise:
> checking build system type... x86_64-apple-darwin22.1.0

Is your terminal running under Rosetta or something.

💬 fanquake commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856603897)
This is clearly a local issue / misconfiguration, not a problem with Core.

💬 achow101 commented on pull request "wallet: birth time update during tx scanning":
(https://github.com/bitcoin/bitcoin/pull/28920#issuecomment-1856605477)
ACK 1ce45baed7dd2da3f1cb85c9c25110e5537451ae

💬 murchandamus commented on pull request "Add multiplication operator to CFeeRate":
(https://github.com/bitcoin/bitcoin/pull/29037#issuecomment-1856612479)
Thanks @kashifs, I’ve merged your pull request into my pull request and pushed it.

💬 maflcko commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856618608)
Could this be due to an env var? Maybe check `env | grep 'HOST='`?

💬 brunoerg commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856620276)
> So, instead of passing coin_params.m_cost_of_change and 0, we should be passing coin_params.min_viable_change and coin_params.m_change_fee. Just fixing one or the other was insufficient, but when I replace both all my fuzz crashes pass.

Cool, I think the 0 came from the way we call `ComputeAndSetWaste` internally in `SelectCoinsBnB`.

💬 brunoerg commented on pull request "fuzz: coinselection, improve `min_viable_change`/`change_output_size`":
(https://github.com/bitcoin/bitcoin/pull/28372#issuecomment-1856623275)
Thanks, @furszy and @murchandamus. I will address the suggestions and leave it running for some time before pushing.

💬 sarthak13gupta commented on issue "Not able to build and compile on macos":
(https://github.com/bitcoin/bitcoin/issues/29083#issuecomment-1856629535)
> You said you're running on arm, but configure says otherwise:
>
> > checking build system type... x86_64-apple-darwin22.1.0
>
> Is your terminal running under Rosetta or something.

Yes, now that I checked because it gives compatibility issues with dependencies sometimes.

Should I change it and run it without Rosseta?

But I don't know why this would happen , also when brew is located at `/opt/homebrew/bin/brew`
and I'm installing dependencies using
`arch -arm64 brew install
...