💬 amitiuttarwar commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#issuecomment-1679933308)
ACK 6d7fd9fb9b38be75b2bce643a99cc584837a902b

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#issuecomment-1679985361)
CI is green 🫠

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295394612)
review note: This was done to manually nuke the old cache and start a new depends build/cache for all tasks on Cirrus CI.

🤔 atou69 reviewed a pull request: "refactor: Remove unused boost signals2 from torcontrol"
(https://github.com/bitcoin/bitcoin/pull/28240#pullrequestreview-1579843842)
#27511

💬 MarcoFalke commented on pull request "ci: label docker images and prune dangling images selectively":
(https://github.com/bitcoin/bitcoin/pull/27793#discussion_r1295419773)
this isn't enough. Volumes also exist

⚠️ MarcoFalke opened an issue: "What is depends BUILD_ID_SALT ?"
(https://github.com/bitcoin/bitcoin/issues/28276)
Is it unused? If not, how can it be used? If yes, can it be removed?

References:

```
$ git grep '\<build_id\>'
depends/Makefile:# they rely on the build_id variables
depends/Makefile:build_id:=$(shell env CC='$(build_CC)' C_STANDARD='$(C_STANDARD)' CXX='$(build_CXX)' CXX_STANDARD='$(CXX_STANDARD)' AR='$(build_AR)' RANLIB='$(build_RANLIB)' STRIP='$(build_STRIP)' SHA256SUM='$(build_SHA256SUM)' DEBUG='$(DEBUG)' LTO='$(LTO)' NO_HARDEN='$(NO_HARDEN)' ./gen_id '$(BUILD_ID_SALT)' 'GUIX_
...

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295448801)
Any reason to reduce this to 4 when it previously was 10?

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295459732)
Looks like each pull request will rewrite the ccache and thus the hit rate will be ~0% overall?

Would be better to get the cache from the own pull only, or master.

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#discussion_r1295494329)
> > Also, is the 10 GB enough to store all ccache + depends + image + ... stuff for all tasks?
>
> Well, it depends on what "all tasks" encompass.

A single task currently will cycle through 10GB in less than a day, see https://github.com/bitcoin/bitcoin/actions/caches

💬 RobinLinus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1680138110)
@russeree, your response is a red herring because you're distracting from the fact that Mike openly states that he's *"polluting the UTXO set"* with *"toxic waste"*:

- ["What if we do it in the worst way possible? What if we store it in the UTXO set?"](https://youtu.be/jJV_-EFZshU?t=252)
- ["I'm ruining bitcoin"](https://youtu.be/jJV_-EFZshU?t=276)
- ["With Stamps we're polluting the UTXO set on pre-segwit nodes, post-segwit nodes, pruned nodes, full nodes. They're all getting this toxic wa
...

💬 hebasto commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295521264)
Why is there a need to build a new `depends/built` cache in the first place?

💬 hebasto commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#issuecomment-1680149151)
Re-run of the Cirrus task builds the depends packages regardless of caching: https://cirrus-ci.com/task/5981899345100800

💬 hebasto commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295550323)
fae6642af234cad6063945bcba7958168bf2687c, style nit, suggesting to set environment variables consistently throughout the entire `ci.yml` file, wherever possible:

```suggestion
env:
BASE_ROOT_DIR: ${{ github.workspace }}
run: ./ci/test_run_all.sh
```

💬 Sjors commented on issue "Raise maximum -dbcache setting":
(https://github.com/bitcoin/bitcoin/issues/28249#issuecomment-1680180842)
@sipa I ran an IBD as part of testing #27596. Since I did a restart after the cache initially hit 1 GB, the data is not accurate, but the cache reached 13,334 MiB at block at block 798,000. A month earlier at 794,000 the log shows it as 12,766 MiB. So the memory footprint is growing ~7 GB per year (and that's not even the worst month, see [chart I linked to above](https://statoshi.info/d/000000009/unspent-transaction-output-set?orgId=1&from=now%2Fy&to=now&refresh=5s&viewPanel=8)).

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295561963)
Thanks, removed.

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#discussion_r1295562542)
Thanks, adjusted style

👍 hebasto approved a pull request: "ci: Move tidy to persistent worker"
(https://github.com/bitcoin/bitcoin/pull/28214#pullrequestreview-1580082893)
re-ACK faaa0794b24f250f787bc9b9605270108ea101a0

💬 MarcoFalke commented on pull request "ci: Fix macOS-cross SDK rsync":
(https://github.com/bitcoin/bitcoin/pull/28273#issuecomment-1680189483)




> Re-run of the Cirrus task builds the depends packages regardless of caching: https://cirrus-ci.com/task/5981899345100800

Good catch. The folder was empty. Should be fixed now.

💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295570969)
Yea, looks like caching doesn't work at all here?

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295573475)
> Yea, looks like caching doesn't work at all here?

- https://github.com/bitcoin/bitcoin/issues/21552
- https://github.com/bitcoin/bitcoin/pull/24620