💬 fanquake commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295574797)
If it doesn't work, why was any of this added to the CI template?

💬 Sjors commented on pull request "Break up script/standard.{h/cpp}":
(https://github.com/bitcoin/bitcoin/pull/28244#issuecomment-1680204877)
ACK 91d924ede1b421df31c895f4f43359e453a09ca5

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295577353)
I think it works when there are no pull requests. It should be possible to fix this in a follow-up.

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295578085)
> If it doesn't work, why was any of this added to the CI template?

Ccache regression, introduced in https://github.com/bitcoin/bitcoin/pull/19683, should be fixed. It is not related to the CI template that is correct.

💬 stickies-v commented on pull request "ci: label docker images and prune dangling images selectively":
(https://github.com/bitcoin/bitcoin/pull/27793#discussion_r1295578392)
Thanks Dropped the README.md commit, don't feel like spending more time on this. @Sjors feel free to follow up if you think it's important.

💬 russeree commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1680212205)
> * "What if we do it in the worst way possible? What if we store it in the UTXO set?"

He is wrong about this, the worst way possible would be to use P2PK instead of P2MS since it would increase the number of outpoints per arbitrary data TX by 3x.

> @russeree, your response is a red herring because you're distracting from the fact that Mike openly states that he's _"polluting the UTXO set"_ with _"toxic waste"_:

This is actually a proper response, thanks citing sources and facts. My co
...

💬 hebasto commented on pull request "build: Fix ccache behavior when cross-compiling for darwin hosts":
(https://github.com/bitcoin/bitcoin/pull/24620#issuecomment-1680215229)
> ~0. I'm still not convinced this is a good change, or even something that _needs_ to be solved at the cost of introducing more platform specific hacks / complication into our build system. It's surprising that there is no way for us to fix this for our use case given the multitude of ccache configuration options / settings, and it's support for additional compiler wrappers. Have we opened an issue upstream to document our use case, and why ccache doesn't currently work with it?

Considering
...

💬 fanquake commented on pull request "build: Fix ccache behavior when cross-compiling for darwin hosts":
(https://github.com/bitcoin/bitcoin/pull/24620#issuecomment-1680218377)
> It's surprising that there is no way for us to fix this for our use case given the multitude of ccache configuration options / settings, and it's support for additional compiler wrappers.

> Have we opened an issue upstream to document our use case, and why ccache doesn't currently work with it?

📝 ggauzin opened a pull request: "Update Bitcoin Core integration/staging tree documentation"
(https://github.com/bitcoin/bitcoin/pull/28277)
This commit updates the documentation for the Bitcoin Core integration/staging tree. The changes include minor text edits and formatting improvements to enhance readability and clarity.

- Updated the formatting of headings for consistency.
- Added missing punctuation in the "License" section.
- Clarified the role of the master branch and its stability in the "Development Process" section.
- Clarified the purpose of the https://github.com/bitcoin-core/gui repository.
- Improved the descrip
...

✅ fanquake closed a pull request: "Update Bitcoin Core integration/staging tree documentation"
(https://github.com/bitcoin/bitcoin/pull/28277)

💬 ggauzin commented on pull request "Update Bitcoin Core integration/staging tree documentation":
(https://github.com/bitcoin/bitcoin/pull/28277#issuecomment-1680221923)
why is it closed

💬 ajtowns commented on pull request "[no merge, meta] refactor: net/net processing split":
(https://github.com/bitcoin/bitcoin/pull/28252#issuecomment-1680222391)
I think I might be coming across as disagreeing more than I actually do? I'm all for modularisation and better testing, and getting things tightly focussed so that you don't need to keep huge amounts of context in your head; but I think the way we've been doing that in `net_processing` in many places is adding complexity and interrelationships rather than reducing them.

> Perhaps a competing PR/design doc of what you are thinking about would help? I've thought about the design in this PR so m
...

💬 russeree commented on issue "Raise maximum -dbcache setting":
(https://github.com/bitcoin/bitcoin/issues/28249#issuecomment-1680225154)
I am re running an -reindex=1 with tracepoints watching for flushes.

Here is my last log entry for cache size height 800673 size 14,045 MiB

```2023-08-11T12:56:23Z UpdateTip: new best=00000000000000000002b6e22bae3b1f28339b6275c02ec9cbb6f19ffd9c7e9c height=800673 version=0x3017a000 log2_work=94.326952 tx=871155372 date='2023-07-28T20:42:50Z' progress=0.995044 cache=14045.6MiB(115054304txo)```

💬 MarcoFalke commented on pull request "Update Bitcoin Core integration/staging tree documentation":
(https://github.com/bitcoin/bitcoin/pull/28277#issuecomment-1680227708)
I think it was closed because the oxford comma is a style question. Generally we leave the style to the original author and then leave it as-is until the line is touched again for other reasons. Everyone should be able to read and understand the text even without the oxford comma.

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295597557)
>

How is this related. This is the "macOS native", not "macOS-cross" task.

💬 hebasto commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1295599361)
> How is this related. This is the "macOS native", not "macOS-cross" task.

My bad. Sorry for the noise.

💬 fanquake commented on issue "ci: ccache does not work for macOS cross-compiling builds":
(https://github.com/bitcoin/bitcoin/issues/21552#issuecomment-1680237452)
Given it's not in the description, can someone summarize the current state of this issue?

* What doesn't work?
* What ccache options have been tried (and don't work)? Taking into account recent ccache releases.
* Have we opened an issue upstream to either report that ccache is broken (for us), or that we have a usecase which isn't satified by it's current feature/option set, to see if they are open to adding a new feature/option?
* If there is any (related) upstream discussions/issues, can
...

💬 RobinLinus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1680238303)
Using P2PK costs more fees. Making the toxic waste more expensive is the objective of this PR.

However, it was stated here before that P2PK should be nonstandard too. Ideally, we would even do a softfork to cleanup all these exploitable quirks. Softforks are much harder though so it's a good approach to simply make P2PK/P2MS nonstandard for now.

💬 russeree commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1680265240)
> Using P2PK costs more fees. Making the toxic waste more expensive is the objective of this PR.

It's my belief that users committed to inflating the UTXO set via these mechanisms won't find the overhead of using P2PK problematic when trying to embed persistent, unprunable data into the timechain. P2MS was originally selected because it offered a cost-effective method to achieve this. If P2MS becomes inefficient or difficult to relay, the next logical choice would be P2PK. If users are will
...

💬 naumenkogs commented on pull request "p2p: Drop m_recently_announced_invs bloom filter":
(https://github.com/bitcoin/bitcoin/pull/27675#issuecomment-1680269540)
ACK fb02ba3c5f5bcd96b5e3622ef001b8e57ce63fc0