💬 dergoegge commented on pull request "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect":
(https://github.com/bitcoin/bitcoin/pull/33983#discussion_r2577510113)
This should not be removed

📝 instagibbs opened a pull request: "fuzz: gate mempool entry based on weight"
(https://github.com/bitcoin/bitcoin/pull/33985)
The mempool implementation now uses TxGraph with entries using FeePerWeight, not vsize. This means our package_rbf harness will erroneously add more transaction weight than we can support inside of FeeFrac. Gate more aggressivelt using WITNESS_SCALE_FACTOR.

Fixes https://github.com/bitcoin/bitcoin/issues/33981

💬 kevkevinpal commented on pull request "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect":
(https://github.com/bitcoin/bitcoin/pull/33983#issuecomment-3597170872)
> In my opinion this is too fine grained of a step and not worth a PR on its own, as it will cause more churn down the line (e.g. the signature of `MaybeDiscourageAndDisconnect` will likely have to change again).

Gotcha, should I attempt to decouple more/all functions in `PeerManagerImpl`. I was worried about attempting to make too large a PR, but I guess I went the other extreme, haha

💬 instagibbs commented on issue "integer overflow in FUZZ=package_rbf":
(https://github.com/bitcoin/bitcoin/issues/33981#issuecomment-3597171676)
I believe I diagnosed it and implemented a fix https://github.com/bitcoin/bitcoin/pull/33985

💬 kevkevinpal commented on pull request "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect":
(https://github.com/bitcoin/bitcoin/pull/33983#discussion_r2577556376)
I added a `should_disconnect` parameter and after this function is called we do the following

```
if (should_disconnect) {
pto->fDisconnect = true;
}
return true;
```

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >40% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2577565765)
But `ConnectBlock` also inserts the newly created utxos into the cache, so that the next call to `AccessCoin` will just get it from the cache's `cacheCoins` map.

💬 maflcko commented on pull request "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect":
(https://github.com/bitcoin/bitcoin/pull/33983#issuecomment-3597201044)
Can you explain this a bit better?

> An (ugly) initial POC can be seen here: https://github.com/theuni/bitcoin/tree/multiprocess_p2p. Note that it will likely not be rebased because it was not intended to be used as-is. Instead, chunks will be extracted and PR'd separately.

Did you cherry-pick a commit from this branch? If not, why not? If yes, why did the author change?

💬 instagibbs commented on pull request "fuzz: gate mempool entry based on weight":
(https://github.com/bitcoin/bitcoin/pull/33985#issuecomment-3597202152)
cc @sdaftuar

💬 l0rinc commented on issue "When 30.0 for Start9":
(https://github.com/bitcoin/bitcoin/issues/33984#issuecomment-3597240774)
please see: https://x.com/start9labs/status/1981503274051391495

💬 mbarulli commented on issue "When 30.0 for Start9":
(https://github.com/bitcoin/bitcoin/issues/33984#issuecomment-3597261243)
Thanks! Very useful tip!


On Mon, Dec 1, 2025, 16:36 l0rinc ***@***.***> wrote:

> *l0rinc* left a comment (bitcoin/bitcoin#33984)
> <https://github.com/bitcoin/bitcoin/issues/33984#issuecomment-3597240774>
>
> please see: https://x.com/start9labs/status/1981503274051391495
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/33984#issuecomment-3597240774>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAILWGX
...

🤔 janb84 reviewed a pull request: "refactor: C++20 operators"
(https://github.com/bitcoin/bitcoin/pull/33771#pullrequestreview-3525686869)
ACK 48840bfc2d7beeac0ddf56a3c26b243156ec8936

Reducing custom handwritten boilerplate and replacing it with modern idioms is not something we should shun to do (imho). Using the spaceship operation `<=>` will use the compiler to generate the other operators correctly.

Was a bit worried that the spaceship did not yet land on apple clang, given the [documentation](https://developer.apple.com/xcode/cpp/)
<img width="761" height="383" alt="Screenshot 2025-12-01 at 15 42 16" src="https://githu
...

✅ kevkevinpal closed a pull request: "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect"
(https://github.com/bitcoin/bitcoin/pull/33983)

💬 kevkevinpal commented on pull request "refactor/p2p: Decouple CNode from PeerManagerImpl::MaybeDiscourageAndDisconnect":
(https://github.com/bitcoin/bitcoin/pull/33983#issuecomment-3597265384)
> Can you explain this a bit better?
>
> > An (ugly) initial POC can be seen here: https://github.com/theuni/bitcoin/tree/multiprocess_p2p. Note that it will likely not be rebased because it was not intended to be used as-is. Instead, chunks will be extracted and PR'd separately.
>
> Did you cherry-pick a commit from this branch? If not, why not? If yes, why did the author change?

I did not cherry-pick commits from this branch but now looking at it, I prefer the approach here instead. W
...

👍 willcl-ark approved a pull request: "[30.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33609#pullrequestreview-3525704408)
ACK b2cb203af05743ea5c130913afa7549c02d1bae5

💬 instagibbs commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2577658987)
Given the new implementation that doesn't even use `visited()`, I think can be removed anyway (in another followup)

💬 sdaftuar commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2577689691)
Done

💬 janb84 commented on pull request "depends, doc: Add `tcl` as build dependency for `sqlite` package":
(https://github.com/bitcoin/bitcoin/pull/33975#issuecomment-3597369323)
This doesn't work for me on ubuntu 24.04, if I only install what is specified and then execute:
```sh
gmake -C depends sqlite CC=gcc-14 CXX=g++-14
```
it will fail to find with the error state above, I needed to install g++:
```sh
apt install g++
```

But it will install g++13 so I needed to run :
```sh
gmake -C depends sqlite CC=gcc-13 CXX=g++-13
```

💬 sdaftuar commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2577692236)
Fixed!

💬 sdaftuar commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2577693180)
Fixed, and made a few other small style edits as well.

💬 sdaftuar commented on pull request "Cluster mempool followups":
(https://github.com/bitcoin/bitcoin/pull/33591#discussion_r2577693764)
Done.