💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >40% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2577730632)
> So it kinda' reproduces that it doesn't make sense to do more than 4
Looks like it doesn't make sense to do more than 2?
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2577730632)
> So it kinda' reproduces that it doesn't make sense to do more than 4
Looks like it doesn't make sense to do more than 2?
👍 instagibbs approved a pull request: "Cluster mempool followups"
(https://github.com/bitcoin/bitcoin/pull/33591#pullrequestreview-3525882615)
ACK https://github.com/bitcoin/bitcoin/pull/33591/commits/b8d279a81c16fe9f5b6d422e518c77344e217d4f
(https://github.com/bitcoin/bitcoin/pull/33591#pullrequestreview-3525882615)
ACK https://github.com/bitcoin/bitcoin/pull/33591/commits/b8d279a81c16fe9f5b6d422e518c77344e217d4f
💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >40% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2577771108)
maybe, but leveldb is basically empty, we shouldn't take it *too* seriously
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2577771108)
maybe, but leveldb is basically empty, we shouldn't take it *too* seriously
📝 sipa opened a pull request: "doc: improvements to doc/descriptors.md"
(https://github.com/bitcoin/bitcoin/pull/33986)
This brings doc/descriptors.md up to date:
* Stop trying to exhaustively list all RPCs that involve descriptors. They're used everywhere.
* Stop trying to give the history of descriptor support, we have release notes for that.
* Mention that wallets are now built around descriptors (especially with legacy wallets gone).
* Mention `musig()` descriptors in the specification part.
* Reference the relevant output descriptor BIPs in the text.
(https://github.com/bitcoin/bitcoin/pull/33986)
This brings doc/descriptors.md up to date:
* Stop trying to exhaustively list all RPCs that involve descriptors. They're used everywhere.
* Stop trying to give the history of descriptor support, we have release notes for that.
* Mention that wallets are now built around descriptors (especially with legacy wallets gone).
* Mention `musig()` descriptors in the specification part.
* Reference the relevant output descriptor BIPs in the text.
💬 instagibbs commented on pull request "policy: Remove individual transaction <minrelay restriction":
(https://github.com/bitcoin/bitcoin/pull/33892#discussion_r2577778753)
changed my mind; it's good to have v2 ephemeral dust coverage since we don't have much/any?
(https://github.com/bitcoin/bitcoin/pull/33892#discussion_r2577778753)
changed my mind; it's good to have v2 ephemeral dust coverage since we don't have much/any?
🤔 sipa reviewed a pull request: "Cluster mempool followups"
(https://github.com/bitcoin/bitcoin/pull/33591#pullrequestreview-3525911467)
ACK b8d279a81c16fe9f5b6d422e518c77344e217d4f
(https://github.com/bitcoin/bitcoin/pull/33591#pullrequestreview-3525911467)
ACK b8d279a81c16fe9f5b6d422e518c77344e217d4f
💬 fanquake commented on pull request "guix: use GCC 14.3.0 over 13.3.0":
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3597776607)
I tried comparing debug info from GCCs passes, the first one that seems to differ is `objsz1`:
```diff
--- bitcoin_wallet.dir.aarch64/db.cpp.cpp.108t.objsz1
+++ bitcoin_wallet.dir.x86_64/db.cpp.cpp.108t.objsz1
@@ -9967,15 +9967,15 @@
Computing maximum dynamic object size for _38:
Computing maximum object size for _38:
Computing maximum dynamic object size for _143:
Computing maximum object size for _143:
Computing maximum dynamic object size for _215:
_127: maximum dynamic obj
...
(https://github.com/bitcoin/bitcoin/pull/33775#issuecomment-3597776607)
I tried comparing debug info from GCCs passes, the first one that seems to differ is `objsz1`:
```diff
--- bitcoin_wallet.dir.aarch64/db.cpp.cpp.108t.objsz1
+++ bitcoin_wallet.dir.x86_64/db.cpp.cpp.108t.objsz1
@@ -9967,15 +9967,15 @@
Computing maximum dynamic object size for _38:
Computing maximum object size for _38:
Computing maximum dynamic object size for _143:
Computing maximum object size for _143:
Computing maximum dynamic object size for _215:
_127: maximum dynamic obj
...
👍 marcofleon approved a pull request: "[30.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33609#pullrequestreview-3526105740)
Lgtm, ACK b2cb203af05743ea5c130913afa7549c02d1bae5
(https://github.com/bitcoin/bitcoin/pull/33609#pullrequestreview-3526105740)
Lgtm, ACK b2cb203af05743ea5c130913afa7549c02d1bae5
💬 bialy39439 commented on issue "[flatpak] - I cannot choose or change datadir when running from flatpak":
(https://github.com/bitcoin/bitcoin/issues/24612#issuecomment-3597848572)
I'm facing same issue.
Solution for me is to add --datadir argument afer org.bitcoincore.bitcoin-qt in .desktop file, eg:
`/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=bitcoin-qt --file-forwarding org.bitcoincore.bitcoin-qt --datadir=/path/to/somewhere`
(https://github.com/bitcoin/bitcoin/issues/24612#issuecomment-3597848572)
I'm facing same issue.
Solution for me is to add --datadir argument afer org.bitcoincore.bitcoin-qt in .desktop file, eg:
`/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=bitcoin-qt --file-forwarding org.bitcoincore.bitcoin-qt --datadir=/path/to/somewhere`
📝 0xB10C opened a pull request: "2025 11 self advertise in separate message"
(https://github.com/bitcoin/bitcoin/pull/33987)
wip; PR for CI
(https://github.com/bitcoin/bitcoin/pull/33987)
wip; PR for CI
✅ 0xB10C closed a pull request: "2025 11 self advertise in separate message"
(https://github.com/bitcoin/bitcoin/pull/33987)
(https://github.com/bitcoin/bitcoin/pull/33987)
💬 0xB10C commented on pull request "2025 11 self advertise in separate message":
(https://github.com/bitcoin/bitcoin/pull/33987#issuecomment-3597864819)
should have been against my fork...
(https://github.com/bitcoin/bitcoin/pull/33987#issuecomment-3597864819)
should have been against my fork...
💬 ryanofsky commented on pull request "refactor: Add util::Result failure values, multiple error and warning messages":
(https://github.com/bitcoin/bitcoin/pull/25665#issuecomment-3597867646)
> At this point I wonder though if using `std::expected` instead would have more success.
Note that goals of std::expected and util::Result are different. The goal of util::Result is to let code provide descriptive error messages to users when it fails (this is why it uses translated strings). The goal of std::expected is to return error information to callers so they can distinguish between different types of failures and handle them in different ways. The Result class is better at error rep
...
(https://github.com/bitcoin/bitcoin/pull/25665#issuecomment-3597867646)
> At this point I wonder though if using `std::expected` instead would have more success.
Note that goals of std::expected and util::Result are different. The goal of util::Result is to let code provide descriptive error messages to users when it fails (this is why it uses translated strings). The goal of std::expected is to return error information to callers so they can distinguish between different types of failures and handle them in different ways. The Result class is better at error rep
...
👋 instagibbs's pull request is ready for review: "policy: don't CheckEphemeralSpends on reorg"
(https://github.com/bitcoin/bitcoin/pull/33616)
(https://github.com/bitcoin/bitcoin/pull/33616)
💬 instagibbs commented on pull request "policy: don't CheckEphemeralSpends on reorg":
(https://github.com/bitcoin/bitcoin/pull/33616#issuecomment-3597968747)
Added some more coverage and now has no dependencies.
(https://github.com/bitcoin/bitcoin/pull/33616#issuecomment-3597968747)
Added some more coverage and now has no dependencies.
💬 hebasto commented on pull request "depends, doc: Add `tcl` as build dependency for `sqlite` package":
(https://github.com/bitcoin/bitcoin/pull/33975#issuecomment-3597986268)
@janb84
> This doesn't work for me on ubuntu 24.04, if I only install what is specified and then execute:
>
> ```shell
> gmake -C depends sqlite CC=gcc-14 CXX=g++-14
> ```
The example above assumes that the [`gcc-14`](https://packages.ubuntu.com/noble/gcc-14) and [`g++-14`](https://packages.ubuntu.com/noble/g++-14) packages are installed.
(https://github.com/bitcoin/bitcoin/pull/33975#issuecomment-3597986268)
@janb84
> This doesn't work for me on ubuntu 24.04, if I only install what is specified and then execute:
>
> ```shell
> gmake -C depends sqlite CC=gcc-14 CXX=g++-14
> ```
The example above assumes that the [`gcc-14`](https://packages.ubuntu.com/noble/gcc-14) and [`g++-14`](https://packages.ubuntu.com/noble/g++-14) packages are installed.
💬 janb84 commented on pull request "depends, doc: Add `tcl` as build dependency for `sqlite` package":
(https://github.com/bitcoin/bitcoin/pull/33975#issuecomment-3598060500)
> @janb84
>
> > This doesn't work for me on ubuntu 24.04, if I only install what is specified and then execute:
> > ```shell
> > gmake -C depends sqlite CC=gcc-14 CXX=g++-14
> > ```
>
> The example above assumes that the [`gcc-14`](https://packages.ubuntu.com/noble/gcc-14) and [`g++-14`](https://packages.ubuntu.com/noble/g++-14) packages are installed.
Ah Sorry, my mistake, took your example to literally.
(https://github.com/bitcoin/bitcoin/pull/33975#issuecomment-3598060500)
> @janb84
>
> > This doesn't work for me on ubuntu 24.04, if I only install what is specified and then execute:
> > ```shell
> > gmake -C depends sqlite CC=gcc-14 CXX=g++-14
> > ```
>
> The example above assumes that the [`gcc-14`](https://packages.ubuntu.com/noble/gcc-14) and [`g++-14`](https://packages.ubuntu.com/noble/g++-14) packages are installed.
Ah Sorry, my mistake, took your example to literally.
🤔 janb84 reviewed a pull request: "depends, doc: Add `tcl` as build dependency for `sqlite` package"
(https://github.com/bitcoin/bitcoin/pull/33975#pullrequestreview-3526330943)
ACK 632cf872a584e4a373a669aca5b885f63a2b7add
PR adds `tcl` as packages to install to compile depends.
Have confirmed change on ubuntu 24.04
(https://github.com/bitcoin/bitcoin/pull/33975#pullrequestreview-3526330943)
ACK 632cf872a584e4a373a669aca5b885f63a2b7add
PR adds `tcl` as packages to install to compile depends.
Have confirmed change on ubuntu 24.04
💬 sdaftuar commented on pull request "fuzz: gate mempool entry based on weight":
(https://github.com/bitcoin/bitcoin/pull/33985#issuecomment-3598198410)
Looks right to me, and I was able to generate a fuzz crash on master that was fixed by this PR. Going to continue fuzzing for a bit to see if there are any other issues.
(https://github.com/bitcoin/bitcoin/pull/33985#issuecomment-3598198410)
Looks right to me, and I was able to generate a fuzz crash on master that was fixed by this PR. Going to continue fuzzing for a bit to see if there are any other issues.
⚠️ manuelbarraza2202-debug opened an issue: "Top Bitcoin recovery expert helping victims restore stolen digital funds. Visit TECHY FORCE CYBER RETRIEVAL"
(https://github.com/bitcoin/bitcoin/issues/33988)
### Motivation
The world of cryptocurrency has been marred by numerous scams, with unsuspecting investors losing substantial amounts to fraudulent schemes. One such scam involved a bogus job opportunity that demanded a hefty $49,000 "training fee" in USDC (USD Coin). Many victims of this scam had given up hope of ever recovering their lost investment. However, a recent success story has demonstrated that, with the right approach, it is possible to recover significant amounts of stolen funds. Th
...
(https://github.com/bitcoin/bitcoin/issues/33988)
### Motivation
The world of cryptocurrency has been marred by numerous scams, with unsuspecting investors losing substantial amounts to fraudulent schemes. One such scam involved a bogus job opportunity that demanded a hefty $49,000 "training fee" in USDC (USD Coin). Many victims of this scam had given up hope of ever recovering their lost investment. However, a recent success story has demonstrated that, with the right approach, it is possible to recover significant amounts of stolen funds. Th
...