Bitcoin Core Github
43 subscribers
122K links
Download Telegram
πŸš€ fanquake merged a pull request: "test: move create_malleated_version() to messages.py for reuse"
(https://github.com/bitcoin/bitcoin/pull/33793)
πŸ’¬ fanquake commented on pull request "Changing the rpcbind argument being ignored to a pop up warning, inst…":
(https://github.com/bitcoin/bitcoin/pull/33813#issuecomment-3501963024)
https://github.com/bitcoin/bitcoin/actions/runs/19159736145/job/54788142845?pr=33813#step:5:171:
```bash
Duplicate include(s) in src/httpserver.cpp:
#include <node/interface_ui.h>
```

Can you also shorten the length of the commit title, and add a proper `prefix:`.
πŸ’¬ hebasto commented on pull request "ci: Add fast IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502001970)
> but if it can't be taken and applied directly without fixing the sorting, and the formatting, and in the worse case, changing headers entirely for `modernize-deprecated-headers`, then it doesn't seem that much more useful.

I disagree. In practice, when a developer works on changes that modify includes, the diff in the includes would typically be just a few lines. Using the diff from the CI job as a hint seems entirely reasonable. I don’t see a strong need to increase the script’s complexity
...
πŸ’¬ hebasto commented on pull request "ci: Add fast IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2502986634)
Reworked into a single job.
πŸ’¬ ismaelsadeeq commented on issue "Header-only support for waitNext()":
(https://github.com/bitcoin/bitcoin/issues/33756#issuecomment-3502079264)
> I'd like to expand the `waitNext()` Mining IPC function to optionally (via `BlockWaitOptions`) return an (empty) new template as soon as we have a header with sufficient proof-of-work, pending block download and/or validation.

Why? you should expand on the motivations behind this and what exactly you aim to achieve with this feature.

> I suspect there’s little benefit if compact block reconstruction succeeds. And, if I understand correctly, we hold `cs_main` during this process anyway, so th
...
πŸš€ fanquake merged a pull request: "test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py"
(https://github.com/bitcoin/bitcoin/pull/33782)
πŸ‘ maflcko approved a pull request: "ci: Add fast IWYU job"
(https://github.com/bitcoin/bitcoin/pull/33810#pullrequestreview-3433404478)
lgtm. Seems fine
πŸ’¬ maflcko commented on pull request "ci: Add fast IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2503088962)
```suggestion
# Don't apply patches in the iwyu job, because it relies on the `git diff`
```

nit, if you re-touch
πŸ’¬ maflcko commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502188798)
@willcl-ark @pinheadmz Probably off-topic here, but I am thinking about just having those spam issues be auto-closed and locked by @DrahtBot . Any thoughts?
πŸ’¬ pinheadmz commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502204812)
@maflcko yes ACK to that... can the bot edit title and description to null as well? (Will and I don't have permission)

Bot has been doing great with these heuristics auto closes. I just stroll by later and block the account if its total nonsense
πŸ’¬ hebasto commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#discussion_r2503176033)
Thanks! Fixed.
πŸ’¬ fanquake commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502215255)
> just to produce a diff that can be immediately applied.

The diff can't be applied at all, is always wrong to varying extents, and there are no instructions for devs on how to fix it.
πŸ’¬ willcl-ark commented on issue "alexminer":
(https://github.com/bitcoin/bitcoin/issues/33815#issuecomment-3502215405)
Yeah ack from me too
βœ… fanquake closed an issue: "alexminer"
(https://github.com/bitcoin/bitcoin/issues/33815)
βœ… fanquake closed an issue: "l"
(https://github.com/bitcoin/bitcoin/issues/33816)
πŸ’¬ maflcko commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502264978)
> instructions

Some basic instructions could be added after the `echo "^^^ ⚠️ Failure generated from IWYU"`, if needed.
πŸ’¬ fanquake commented on pull request "net_processing: reorder the code that handles the VERSION message":
(https://github.com/bitcoin/bitcoin/pull/33792#issuecomment-3502276048)
cc @ajtowns
πŸ’¬ vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3502289963)
`e5e16de7b5...29ef3c62de`: rebase due to conflicts, drop the changes that were merged via https://github.com/bitcoin/bitcoin/pull/33793, thank you!