💬 hebasto commented on pull request "ci: Add IWYU job":
(https://github.com/bitcoin/bitcoin/pull/33810#issuecomment-3502299400)
> > instructions
>
> Some basic instructions could be added after the `echo "^^^ ⚠️ Failure generated from IWYU"`, if needed.

Happy to add them once someone suggests good wording.

💬 fanquake commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#issuecomment-3502313400)
Guix Build (aarch64):
```bash
a3647a46e00124b207263b695d9598cf9fe6c845ea9072c933462dd0e31a0ed9 guix-build-a02282d20c87/output/aarch64-linux-gnu/SHA256SUMS.part
6e3b9a2e39e207d98c347ccc0a81dfc6c79484befa5dbbeaaccdd0b44b759e99 guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu-debug.tar.gz
827f5c070c2ee3c8e1eb96cfd6f05551e4a69a00e422f808c15840026c7a27fc guix-build-a02282d20c87/output/aarch64-linux-gnu/bitcoin-a02282d20c87-aarch64-linux-gnu.tar.gz
0614c4
...

💬 m3dwards commented on pull request "cmake: Create subdirectories in build tree in advance":
(https://github.com/bitcoin/bitcoin/pull/32773#issuecomment-3502318619)
ACK 76dae5d6911b600fafa3a417a740f14b299284f3

Tested on arm Mac.

💬 fanquake commented on pull request "cmake: Create subdirectories in build tree in advance":
(https://github.com/bitcoin/bitcoin/pull/32773#issuecomment-3502325640)
cc @purpleKarrot

📝 l0rinc opened a pull request: "validation: reduce persisted UTXO set size by prioritizing positive lookups (RFC)"
(https://github.com/bitcoin/bitcoin/pull/33817)
*draft to gather comments and conceptual reviews*

-----

### Context

BIP30 prevents duplicate transaction IDs by checking whether outputs already exist in the UTXO set before adding them.
LevelDB's `FilterPolicy` stores a per-table probabilistic filter to optimize for negative lookups.

After the first ~230k blocks (BIP30/BIP34 windows), validation does not deliberately probe the UTXO set for missing entries (missing coins imply invalid transactions).
Bloom filters therefore slow the
...

📝 hebasto opened a pull request: "ci: Extend tidy job to cover kernel code"
(https://github.com/bitcoin/bitcoin/pull/33818)

🚀 fanquake merged a pull request: "script: remove dead code in `CountWitnessSigOps`"
(https://github.com/bitcoin/bitcoin/pull/33786)

✅ fanquake closed a pull request: "depends: add zeromq patch to fix mingw CMake file install location"
(https://github.com/bitcoin/bitcoin/pull/33778)

💬 fanquake commented on pull request "depends: add zeromq patch to fix mingw CMake file install location":
(https://github.com/bitcoin/bitcoin/pull/33778#issuecomment-3502369453)
I wont bother changing this for now (also don't want to add to /share given that bundles content we are currently pruning). Maybe we can also convince upstream to rechange their approach.

✅ fanquake closed a pull request: "guix: Pointer Authentication and Branch Target Identification for aarch64 Linux"
(https://github.com/bitcoin/bitcoin/pull/24123)

💬 fanquake commented on pull request "guix: Pointer Authentication and Branch Target Identification for aarch64 Linux":
(https://github.com/bitcoin/bitcoin/pull/24123#issuecomment-3502370479)
Ideally #25573 will happen soon, which essentially includes this. So closing for now.

💬 l0rinc commented on issue "malloc: Failed to allocate segment from range group - out of space":
(https://github.com/bitcoin/bitcoin/issues/33806#issuecomment-3502430755)
I can reproduce it reliably on a MacBook M4 Pro with 64 GB memory.
The OOM happens at block ~500k already (at ~8.6GiB dbcache): https://gist.github.com/l0rinc/8ccb47e298d6176f8af28397eef7b4df

👍 rkrux approved a pull request: "log: show reindex progress in `ImportBlocks`"
(https://github.com/bitcoin/bitcoin/pull/33353#pullrequestreview-3433884021)
lgtm ACK d7de5b109f69293b375729363b4e5038f3fb6b15

I don't see a harm in logging the approximate completeness percentage, would be helpful instead for the user imo.

💬 maflcko commented on issue "malloc: Failed to allocate segment from range group - out of space":
(https://github.com/bitcoin/bitcoin/issues/33806#issuecomment-3502734842)
> I can reproduce it reliably on a MacBook M4 Pro with 64 GB memory.

Does it happen with da6f041e39efaf64a84b748556e321021ec1f756 reverted?

💬 maflcko commented on pull request "ci: Extend tidy job to cover kernel code":
(https://github.com/bitcoin/bitcoin/pull/33818#discussion_r2503744180)
i wonder if this can use the dev-mode preset, so that only a single list has to maintained for all targets

💬 frankomosh commented on pull request "test: add case where `TOTAL_TRIES` is exceeded yet solution remains":
(https://github.com/bitcoin/bitcoin/pull/33701#discussion_r2503752402)
> It's tricky that the api doesn't return a different result when the TOTAL_TRIES is exceeded.
>
> What if you add

`BOOST_CHECK(result_b->GetAlgoCompleted() == false);` right after the `BOOST_CHECK(!result_b);`.

I guess that might prove TOTAL_TRIES has been hit, instead of failing for any other reason. It obviously doesn’t give a typed error enum(like the rust version), but I guess it is the best that can be done with the current C++ API without a larger refactor. ?

💬 TheCharlatan commented on pull request "ci: Extend tidy job to cover kernel code":
(https://github.com/bitcoin/bitcoin/pull/33818#discussion_r2503782285)
sgtm

💬 hebasto commented on pull request "ci: Extend tidy job to cover kernel code":
(https://github.com/bitcoin/bitcoin/pull/33818#discussion_r2503836132)
Thanks! Adjusted.

📝 Sjors opened a pull request: "mining: add getCoinbase()"
(https://github.com/bitcoin/bitcoin/pull/33819)
Deprecate `getCoinbaseTx()` in favor of a new method that provides a struct with everything clients need to construct a coinbase. This is safer than providing a raw dummy coinbase that clients then have to manipulate.

Also deprecate `getCoinbaseCommitment()` and `getWitnessCommitmentIndex()`.

A new helper method `ExtractCoinbaseTemplate()` processes the dummy coinbase transaction generated by `BlockAssembler::CreateNewBlock` and produces a `CoinbaseTemplate`.

Expand the `interface_ipc.p
...

💬 Sjors commented on pull request "mining: add getCoinbase()":
(https://github.com/bitcoin/bitcoin/pull/33819#issuecomment-3502899702)
Working on a matching [sv2-tp](https://github.com/stratum-mining/sv2-tp) pull request.