💬 fanquake commented on issue "ci: short read: expected xxxxxxxxx bytes but got xxxxxxxxx: unexpected EOF":
(https://github.com/bitcoin/bitcoin/issues/33640#issuecomment-3411520463)
IRC yesterday: https://github.com/bitcoin/bitcoin/actions/runs/18534138379/job/52824610461

📝 fanquake opened a pull request: "doc: archive release notes for v28.3"
(https://github.com/bitcoin/bitcoin/pull/33642)

👍 stickies-v approved a pull request: "doc: archive release notes for v28.3"
(https://github.com/bitcoin/bitcoin/pull/33642#pullrequestreview-3345767371)
ACK ceea24b92153d799dfaed1874c86d91c5d002d68 - matches https://github.com/bitcoin/bitcoin/blob/da5f5de4055ecad75490820c0f51db007a0a7d8f/doc/release-notes.md

💬 fanquake commented on issue "ci: short read: expected xxxxxxxxx bytes but got xxxxxxxxx: unexpected EOF":
(https://github.com/bitcoin/bitcoin/issues/33640#issuecomment-3411642707)
https://github.com/bitcoin/bitcoin/actions/runs/17769369035/job/50682078335?pr=33117

🚀 fanquake merged a pull request: "doc: archive release notes for v28.3"
(https://github.com/bitcoin/bitcoin/pull/33642)

🤔 pablomartin4btc reviewed a pull request: "Fix Wayland visual glitches"
(https://github.com/bitcoin-core/gui/pull/904#pullrequestreview-3345811524)
Concept ACK

If you can, please check how this behave on #817.

👍 stickies-v approved a pull request: "Update leveldb subtree to latest master"
(https://github.com/bitcoin/bitcoin/pull/33641#pullrequestreview-3345811711)
ACK 54ffe3de5b1d15f10516ea536a12e13cd7d338f3

Verified that subtree matches commit cad64b151dabe9ffe9771a54d7c9dbfb3355cefb, and the changes are trivial.

💬 hebasto commented on pull request "Update `minisketch` subtree and switch to its build script":
(https://github.com/bitcoin/bitcoin/pull/32856#discussion_r2436716393)
> Since we already know the direction of development, why add more legacy code just for the sake of consistency?

It makes the current code more readable (at least for me).

👍 hebasto approved a pull request: "randomenv: Fix MinGW dllimport warning for `environ`"
(https://github.com/bitcoin/bitcoin/pull/33570#pullrequestreview-3345939519)
re-ACK 9610b0d1e28aeda02a2ddcf1f0591ae577c3e88e.

💬 hebasto commented on pull request "randomenv: Fix MinGW dllimport warning for `environ`":
(https://github.com/bitcoin/bitcoin/pull/33570#issuecomment-3411810718)
> We use mingw-w64 in the CI & Guix build, and it doesn't produce this warning.

GCC has no such a diagnostic: https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html.

Clang does: https://clang.llvm.org/docs/DiagnosticsReference.html#winconsistent-dllimport.

💬 l0rinc commented on pull request "Update leveldb subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/33641#issuecomment-3411960774)
ACK 54ffe3de5b1d15f10516ea536a12e13cd7d338f3

💬 l0rinc commented on pull request "test: [move-only] binary utils to utils.py":
(https://github.com/bitcoin/bitcoin/pull/33633#issuecomment-3411994551)
Concept ACK

👋 sipa's pull request is ready for review: "Replace cluster linearization algorithm with SFL"
(https://github.com/bitcoin/bitcoin/pull/32545)

💬 cedwies commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#issuecomment-3412187177)
ACK 84b2ad0

💬 cedwies commented on pull request "Update leveldb subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/33641#issuecomment-3412213444)
ACK 54ffe3d

🤔 cedwies reviewed a pull request: "net_processing: rename RelayTransaction to better describe what it does"
(https://github.com/bitcoin/bitcoin/pull/33565#pullrequestreview-3346428420)
ACK 84b2ad0

💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3412455674)
Rebased, and made a significant change to the SFL algorithm itself:
* Switched to a different technique for making the initial state topological. The big advantage is that this approach also works when one already has a linearization which is not entirely topological already.

Also the following changes to the `cluster_linearize.h` code in general:
* Using SFL gaining the ability to fix existing linearizations, replaced `FixLinearization` with just making this feature part of `Linearize`.
*
...

🚀 fanquake merged a pull request: "Update leveldb subtree to latest master"
(https://github.com/bitcoin/bitcoin/pull/33641)

💬 sipa commented on pull request "Replace cluster linearization algorithm with SFL":
(https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-3412487618)
This PR has grown quite a bit in scope (despite still being a net negative in LoC!), so I don't think it's unreasonable to split it up into an SFL-specific one, and one with follow-up changes to `txgraph`, or even further. I'll wait for reviewer comments.

💬 murchandamus commented on issue "coin-grinder missing test for TOTAL_TRIES":
(https://github.com/bitcoin/bitcoin/issues/33419#issuecomment-3412624821)
Yeah, it would be good to add this test. If someone wants to work on this, I would like to suggest that they peruse the very similar test for BnB here: https://github.com/bitcoin/bitcoin/blob/e744fd1249bf9577274614eaf3997bf4bbb612ff/src/wallet/test/coinselection_tests.cpp#L166
And to understand what CoinGrinder is actually doing and how it work, I would suggest that prospective implementers peruse the PR that added CoinGrinder starting with this commit: https://github.com/bitcoin/bitcoin/pull/27
...