💬 willcl-ark commented on issue "Node stuck with repeated "Cache size exceeds total space" log message":
(https://github.com/bitcoin/bitcoin/issues/27599#issuecomment-3412640491)
There seem to have been a number of recently merged PRs to address issues related to this recently:

#30611
#30039

...along with no further reports in a good while, so it looks like this issue might have been resolved. Is this still an issue with v30.0 or current master? If not I think this could be closed.

✅ willcl-ark closed an issue: "getaddrmaninfo RPC: add Transport v1/v2 to `tried` for ipv4 & ipv6"
(https://github.com/bitcoin/bitcoin/issues/28807)

💬 willcl-ark commented on issue "getaddrmaninfo RPC: add Transport v1/v2 to `tried` for ipv4 & ipv6":
(https://github.com/bitcoin/bitcoin/issues/28807#issuecomment-3412751085)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this shoudl be re-opened.

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#discussion_r2437450950)
Mocktime is still needed for deterministic block hashes in CI. Removing it causes test failures due to varying timestamps. The test relies on fixed block hashes for comparison, so mocktime ensures reproducibility across runs.

🤔 willcl-ark reviewed a pull request: "guix: build for Linux HOSTS with `-static-libgcc`"
(https://github.com/bitcoin/bitcoin/pull/33181#pullrequestreview-3347122839)
Concept ACK

💬 willcl-ark commented on pull request "guix: build for Linux HOSTS with `-static-libgcc`":
(https://github.com/bitcoin/bitcoin/pull/33181#discussion_r2437549781)
I think this is expected, from reading the docs on [LDFLAGS](https://cmake.org/cmake/help/latest/envvar/LDFLAGS.html), [CMAKE_EXE_LINKER_FLAGS](https://cmake.org/cmake/help/latest/variable/CMAKE_EXE_LINKER_FLAGS_CONFIG.html) and [CMAKE_SHARED_LINKER_FLAGS](https://cmake.org/cmake/help/latest/variable/CMAKE_SHARED_LINKER_FLAGS.html):

>For any configuration run (including the first), the environment variable (LDFLAGS) will be ignored if the equivalent CMAKE_<TYPE>_LINKER_FLAGS_INIT variable is
...

🤔 cedwies reviewed a pull request: "ci: Only write docker build images to Cirrus cache"
(https://github.com/bitcoin/bitcoin/pull/33639#pullrequestreview-3347085731)
Approach ACK

💬 cedwies commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2437581569)
Maybe a short comment is helpful for future maintainers?
`# The Docker build step has moved into 02_run_container.py (see PR #33639)`

💬 cedwies commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2437563972)
we compute `M` from `MAKEJOBS` and then always emit a cpuset.
CI normally uses `-jN` with N > 0, but for edge/local setups, if `MAKEJOBS` ends up as `-j0` (or missing/malformed?), `M` can be `0` -> cpus is `[]` → we emit `--cpuset-cpus= (empty)`. Would it be ok to skip the flag when M <= 0 (and optionally guard parsing)?

```py
def maybe_cpuset():
if os.getenv("HAVE_CGROUP_CPUSET"):
P = int(run(['nproc'], stdout=subprocess.PIPE).stdout)
mj = os.getenv("MAKEJOBS", "-j1") # ma
...

💬 cedwies commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2437521843)
What if we run this outside CI (where env var might not exist)? In that case `os.getenv(...)` returns `None` and `shlex.split(None)` throws `TypeError`.

Would
```py
maybe_cache_arg = shlex.split(os.getenv('DOCKER_BUILD_CACHE_ARG', ''))
```
make sense here? CI behavior is identical, but if it's missing locally we just get an empty list (no cache flags) instead of crashing. Or would you rather keep CI-only usability?

💬 diegoviola commented on pull request "Fix Wayland visual glitches":
(https://github.com/bitcoin-core/gui/pull/904#issuecomment-3413240955)
> If you can, please check how this behaves on #817.

I looked into this and I'm still able to reproduce #817 on v30.0 which has the workaround.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2437862407)
Done in #33591 (d7109669b54d299e84dfe90d2ebf591ff673f51c)

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2437897737)
Thanks -- I'm going to make it "virtual size with all in-mempool..." rather than "virtual kilobytes", which I think is more legible?

🤔 kannapoix reviewed a pull request: "rpc: Handle -named argument parsing where '=' character is used"
(https://github.com/bitcoin/bitcoin/pull/32821#pullrequestreview-3348459569)
Code review ACK: f53dbbc5057b6f676db4be9bc720898149f293fc

💬 kannapoix commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2438509207)
>we need to mention that all the parameters' names correspond to the method.

Oh, I missed that point even though I read the comment—thanks for the explanation.
I agree the getrawchangeaddress error message is still reasonable, so I think the current implementation makes sense.

💬 maflcko commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r2438644126)
```
# echo 'XGFkZAAAAGRkZWXuXP/fcGcqb2hlcirYfg9D/uXc5eXcRZJ55eXl5eXl5eXlIiL19QAFABD3XERc
AVxhYQcAAADl5f//5eVhYWHl5eX//+Xl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl
5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eX/Km8xMTQyMjgxMUMKYWFhYWFhYQAAAAAA
YWFhYWFhYWFhYWFhYWFhe2FhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh8mWkovx0AAAA
AAAAAGFhYWFhYWFhYWFhgKoL//v/Kv/////l5eXl5f//ZGRy5eX//2Ry5eX///9kZHLl5f//ZHLl
5f//5eXl5eXl5eXl5Wfl//9kZHLl5f//ZHLl5f///2RkcuXl//9kcuXl//8=' | base64 --decode > ./crash_cm_1cfc
...

⚠️ maflcko opened an issue: "fuzz: connman fuzz target: runtime error: null pointer passed as argument 2, which is declared to never be null"
(https://github.com/bitcoin/bitcoin/issues/33643)
```
# echo 'XGFkZAAAAGRkZWXuXP/fcGcqb2hlcirYfg9D/uXc5eXcRZJ55eXl5eXl5eXlIiL19QAFABD3XERc
AVxhYQcAAADl5f//5eVhYWHl5eX//+Xl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl
5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eX/Km8xMTQyMjgxMUMKYWFhYWFhYQAAAAAA
YWFhYWFhYWFhYWFhYWFhe2FhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh8mWkovx0AAAA
AAAAAGFhYWFhYWFhYWFhgKoL//v/Kv/////l5eXl5f//ZGRy5eX//2Ry5eX///9kZHLl5f//ZHLl
5f//5eXl5eXl5eXl5Wfl//9kZHLl5f//ZHLl5f///2RkcuXl//9kcuXl//8=' | base64 --decode > ./crash_cm_1cfc
...

🤔 musaHaruna reviewed a pull request: "test: [move-only] binary utils to utils.py"
(https://github.com/bitcoin/bitcoin/pull/33633#pullrequestreview-3348893757)
Code Review ACK [fa75ef4](https://github.com/bitcoin/bitcoin/pull/33633/commits/fa75ef4328f638221bcf85fcbefa885122084622)

PR looks straight forward, moving binaries to util.py files, help make them reusable and not bound to the `Test framework`.

> The config is written by the build system, so I don't think it is coupled with the TestFramework class itself.

Also confirmed that the config is written by the build system located at `bitcoin/build/test/config.ini`.
From my understanding [b
...

💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2438856790)
I think it is fine without comment, because the files are numbered in order and not too many, so one can just read/grep them all to search what they are looking for.

💬 fanquake commented on issue "fuzz: connman fuzz target: runtime error: null pointer passed as argument 2, which is declared to never be null":
(https://github.com/bitcoin/bitcoin/issues/33643#issuecomment-3414432758)
cc @vasild