💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2431873023)
Thanks for pointing this out. I will update the comment.

💬 maflcko commented on pull request "ci: run native fuzz with MSAN job":
(https://github.com/bitcoin/bitcoin/pull/33626#issuecomment-3405514021)
> I agree that it's odd, and I'm wondering why it's not happening (seemingly at all?) in the qa-assets repo?

I can see it happening here: https://github.com/bitcoin-core/qa-assets/actions/runs/18426954137/job/52509387674#step:7:5257:

```
==11740==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x55e39ba5db80 in SetArgs(int, char**) /home/runner/work/_temp/build/src/test/fuzz/util/./test/fuzz/fuzz.cpp:52:5
#1 0x55e39ba5db80 in LLVMFuzzerInitialize /home/runner/work/_temp/
...

💬 vasild commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2431914452)
A boolean `need_broadcast` does not fit the need for "don't broadcast", "broadcast to everybody" and "private broadcast".

✅ fanquake closed an issue: "ci: add an Alpine (musl libc) job"
(https://github.com/bitcoin/bitcoin/issues/33437)

🚀 fanquake merged a pull request: "ci: Turn CentOS config into Alpine musl config"
(https://github.com/bitcoin/bitcoin/pull/33480)

💬 fjahr commented on pull request "init: Improve -asmap option behavior and documentation":
(https://github.com/bitcoin/bitcoin/pull/33632#discussion_r2431971241)
Done

🚀 fanquake merged a pull request: "ci: Add macOS cross task for arm64-apple-darwin"
(https://github.com/bitcoin/bitcoin/pull/33549)

💬 fanquake commented on pull request "[wip] A more static bitcoin-qt":
(https://github.com/bitcoin/bitcoin/pull/33537#issuecomment-3405681891)
> Or is it to simplify deployment, like being able to provide a single binary that can be run on any Linux machine?

We currently provide a single binary that can be run on (most) Linux machines (along with anything in https://github.com/bitcoin-core/packaging); however I'd like to remove runtime requirements further. See #33434 for a recent motivation (users shouldn't need to install additional dependencies/install other software to run our software).

> If the latter is the case, [AppImage
...

👋 fanquake's pull request is ready for review: "Update secp256k1 subtree to latest master"
(https://github.com/bitcoin/bitcoin/pull/33625)

💬 fanquake commented on pull request "Update secp256k1 subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/33625#issuecomment-3405765634)
Guix Build (aarch64):
```bash
22b8a342b9e47069d05d1fca40437ce2b19820e3f3c6b7ef17f2132a462500f9 guix-build-879c21045eba/output/aarch64-linux-gnu/SHA256SUMS.part
8f156c6e1cea62efb25007ab62ce02292eac014fe81f526249e4ff6724292a0c guix-build-879c21045eba/output/aarch64-linux-gnu/bitcoin-879c21045eba-aarch64-linux-gnu-debug.tar.gz
9afd57b78623c0ca553a6e8bf794baf8e31ee55b3dcbe9e265b02810cfaebb82 guix-build-879c21045eba/output/aarch64-linux-gnu/bitcoin-879c21045eba-aarch64-linux-gnu.tar.gz
8819e7
...

💬 stringintech commented on pull request "p2p: Allow block downloads from peers without snapshot block after assumeutxo validation":
(https://github.com/bitcoin/bitcoin/pull/33604#issuecomment-3405795725)
Thanks for the links @stratospher!
FYI, calculating `pindexLastCommonBlock` is undergoing some improvements in #32180, and I will probably have to rebase onto that change. But either way, as you mentioned, it shouldn't cause any issues.

💬 maflcko commented on issue "`test_bitcoin-qt`: segfault under LTO (CMAKE_INTERPROCEDURAL_OPTIMIZATION=ON)":
(https://github.com/bitcoin/bitcoin/issues/33548#issuecomment-3405816831)
I think this is fixed with `GCC 15.2.0), ubuntu 25.10`. I wouldn't recommend using lto with gcc-13:

* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105469
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113359
* ...

💬 maflcko commented on pull request "ci: Build ci_native_base image layer":
(https://github.com/bitcoin/bitcoin/pull/33620#issuecomment-3405842839)
Hmm, then we should probably revert 6c4fe401e908cff1b67d80035b117aae15fe7db6 (or disable docker caching for GHA explicitly), because with the ~20 tasks here, and each task having a ccache size of 500MB, the GHA limit of 10GB should already be reached.

With the 10GB limit, it seems better to use if for ccache+depends than to cache installed packages?

💬 janb84 commented on pull request "doc: correct topology requirements in submitpackage helptext":
(https://github.com/bitcoin/bitcoin/pull/33630#discussion_r2432181432)
Text is not completely clear to me on the parents point. "or 1 transaction with its unconfirmed parents" but "Not all parents need to be present" so some of the unconfirmed parents ? all but not the confirmed parents ?

Maybe NIT;
```suggestion
"The package must consist of either: exactly 1 transaction, or 1 transaction with (some of) its unconfirmed parents. None of the parents may depend on each other. Not all parents need to be present.\n"
```

💬 optout21 commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#issuecomment-3406004322)
ACK 07a926474b5a6fa1d3d4656362a0117611f6da2f

💬 hebasto commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#issuecomment-3406102820)
Rebased to resolve a conflict with the merged https://github.com/bitcoin/bitcoin/pull/33549.

💬 GregTonoski commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3406112078)
There was the relevant quiz posted on the 13th of May 2025: 

📝 maflcko opened a pull request: "test: [move-only] binary utils to utils.py"
(https://github.com/bitcoin/bitcoin/pull/33633)
Having the binary related utils sit in the test_framework.py is fine. However, they are mostly stand-alone utils, which may be used externally.

So move them to utils.py, to allow easier external use. The diff is trivial and can be reviewed via the git options `--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space`.

💬 maflcko commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#discussion_r2432461315)
llm nit:

depend on your arch+OS you are building on. -> depend on the arch+OS you are building on. [fixes redundancy/word order: "your ... you are" is ungrammatical; use a single noun phrase "the arch+OS you are building on" or contraction "you're"]

🤔 instagibbs reviewed a pull request: "test: Fix reorg patterns in tests to use proper fork-based approach"
(https://github.com/bitcoin/bitcoin/pull/32587#pullrequestreview-3340242399)
reACK 7defbc7dc6155dabfab6a0ccddac69260d6d2d54 modulo question about remaining invalidateblock usages.



git range-diff master 0f1f02995b715a83f71b1b8fc92fa520625ec427 7defbc7dc6155dabfab6a0ccddac69260d6d2d54