Bitcoin Core Github
44 subscribers
122K links
Download Telegram
💬 instagibbs commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2432451468)
sync_blocks already ensures this no?
💬 instagibbs commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2432472005)
ping, could you respond to this @yuvicc
💬 instagibbs commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2432484590)
nit: I've now forgotten the exact reason, but we're using invalidateblock here because of MTP reasons, yeah? Might want to leave a note for future reviewers wondering.
💬 hebasto commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#discussion_r2432539485)
Thanks! Fixed.
💬 willcl-ark commented on issue "duplicate wallet warning after closing and reopening wallet":
(https://github.com/bitcoin/bitcoin/issues/20840#issuecomment-3406452511)
@hebasto should, this be moved to the GUI repo (or closed)?
glozow closed an issue: "Minor Release 29.2"
(https://github.com/bitcoin/bitcoin/issues/33586)
💬 sipa commented on pull request "Policy: Report debug message why inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#discussion_r2432583813)
Nit: this seems hard to understand

How about `"input %u P2SH redeemScript missing"`?
💬 willcl-ark commented on issue "wallet: CPU use proportional to wallet transaction count when idle":
(https://github.com/bitcoin/bitcoin/issues/16815#issuecomment-3406473260)
@dooglas is this still an issue with the wallet in v30.0/current master?
🤔 sipa reviewed a pull request: "Policy: Report debug message why inputs are non standard"
(https://github.com/bitcoin/bitcoin/pull/29060#pullrequestreview-3340451463)
utACK 9eea72d3f3647197c24329b412c7fc71895e3ea2
💬 hodlinator commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#issuecomment-3406488480)
Please excuse me while I beat the dead horse before digging deeper. Was also assuming this had to do with some kind of corruption in the bits of `CBlockIndex::nStatus` while at rest on disk, thanks for clearing this up! In https://github.com/bitcoin/bitcoin/issues/26391#issuecomment-1291737018 we find what triggered the original issue:
```
ERROR: ConnectBlock: Consensus::CheckTxInputs: 878d6685666400b75a1947ccfc676249ecdf52678b2dc0d83e0328f8c24a951a, bad-txns-inputs-missingorspent, CheckTxInpu
...
🤔 marcofleon reviewed a pull request: "TxGraph: change m_excluded_clusters"
(https://github.com/bitcoin/bitcoin/pull/33469#pullrequestreview-3340469579)
tACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4

AFL++ now showing 94.5% stability for the `txgrpah` target with this change.
💬 vasild commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#issuecomment-3406508102)
`44a726133a...84b2ad0334`: address suggestions
💬 vasild commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2432618024)
Leaving it as it is.
💬 vasild commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2432619416)
Added.
🚀 glozow merged a pull request: "coins: fix `cachedCoinsUsage` accounting in `CCoinsViewCache`"
(https://github.com/bitcoin/bitcoin/pull/32313)
willcl-ark closed an issue: "wallet getbalance is slow with 3K addresses and 3M transactions"
(https://github.com/bitcoin/bitcoin/issues/24607)
💬 willcl-ark commented on issue "wallet getbalance is slow with 3K addresses and 3M transactions":
(https://github.com/bitcoin/bitcoin/issues/24607#issuecomment-3406568114)
This feature request does not seem to have attracted much attention from other contributors. As such, it does not seem important enough to keep it sitting around idle in the list of open issues. Closing due to lack of interest.

Pull requests with improvements are always welcome.
🤔 glozow reviewed a pull request: "TxGraph: change m_excluded_clusters"
(https://github.com/bitcoin/bitcoin/pull/33469#pullrequestreview-3340565680)
ACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4
🚀 glozow merged a pull request: "TxGraph: change m_excluded_clusters"
(https://github.com/bitcoin/bitcoin/pull/33469)