💬 maflcko commented on pull request "test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`":
(https://github.com/bitcoin/bitcoin/pull/33624#issuecomment-3402515314)
review ACK fd2ce880e09c686c320811a322d00b9318f317ae 📌

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK fd2ce880e09c
...

💬 achow101 commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402534556)
> As a side note, why was the `generate` command removed from the RPC interface?

Because of the separation between node things and wallet things. `generate` is testing only and there's no good reason to have to add it to the node interface just for a convenience function.

> It seems like this RPChttps://github.com/bitcoin/bitcoin/issues/16000#issuecomment-491486488 and avoid the performance hit of touching the wallet?

It would not make a difference. The behavior is not because of any repeated
...

🤔 glozow reviewed a pull request: "cluster mempool: control/optimize TxGraph memory usage"
(https://github.com/bitcoin/bitcoin/pull/33157#pullrequestreview-3336180752)
reACK 023cd5a5469ad61205bf7bb1135895f2b4a20ea9

Thanks for taking the suggestions!

💬 glozow commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2429540255)
Fwiw, I think parts of the original comment could have been kept, it's helpful to know e.g. that it's "implementation-specific, and can go up (even when transactions are removed) and down (even when dependencies are added), as clusters can split and merge."

🚀 glozow merged a pull request: "cluster mempool: control/optimize TxGraph memory usage"
(https://github.com/bitcoin/bitcoin/pull/33157)

💬 Christewart commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402590889)
> > As a side note, why was the `generate` command removed from the RPC interface?
>
> Because of the separation between node things and wallet things. `generate` is testing only and there's no good reason to have to add it to the node interface just for a convenience function.

I think providing helpful testing tools is a worthwhile goal. For instance it was deemed worthwhile to bring back the utility around in `bitcoin-cli` (#19133). Not everyone uses the entire bitcoin core stack for develop
...

💬 achow101 commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402608360)
> Yes, so have the `generate` RPC send funds a to an address that are not relevant to the wallet

Well the issues you mentioned are talking about the old `generate` which mined into a wallet.

If you want to mine into a black hole, you can do that with `generatetoaddress` and a random address.

💬 hebasto commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3402669201)
>```
> 2025-10-14T14:47:07Z Qt 6.10.0 (dynamic), plugin=wayland
> 2025-10-14T14:47:07Z No static plugins.
>```

Could you please try the release binary from https://bitcoincore.org/bin/bitcoin-core-30.0/ or build a statically linked binary with [depends](https://github.com/bitcoin-core/gui/tree/master/depends)?

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402673663)
cc @stickies-v

👍 stickies-v approved a pull request: "test: change log rate limit version gate"
(https://github.com/bitcoin/bitcoin/pull/33612#pullrequestreview-3336520616)
ACK 7b544341c0021dd713f05bc439ee190de911930c

🚀 fanquake merged a pull request: "test: change log rate limit version gate"
(https://github.com/bitcoin/bitcoin/pull/33612)

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402716396)
Backported to `30.x` in #33609.

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402720496)
Backported to `29.x` in #33611.

💬 fanquake commented on pull request "Update libmultiprocess subtree in 30.x branch":
(https://github.com/bitcoin/bitcoin/pull/33519#issuecomment-3402730706)
cc @Sjors @theuni

💬 diegoviola commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3402733857)
> > ```
> > 2025-10-14T14:47:07Z Qt 6.10.0 (dynamic), plugin=wayland
> > 2025-10-14T14:47:07Z No static plugins.
> > ```
>
> Could you please try the release binary from https://bitcoincore.org/bin/bitcoin-core-30.0/ or build a statically linked binary with [depends](https://github.com/bitcoin-core/gui/tree/master/depends)?
>
> EDIT: Both options have only the XCB plugin built in and do not use Wayland. I just want to ensure that release binaries are not affected on your system.

Sure, I just
...

💬 Sjors commented on pull request "Update libmultiprocess subtree in 30.x branch":
(https://github.com/bitcoin/bitcoin/pull/33519#issuecomment-3402738575)
Since it missed the 30.0 cut-off, should we wait a bit longer?

💬 instagibbs commented on pull request "test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`":
(https://github.com/bitcoin/bitcoin/pull/33624#discussion_r2429811753)
```suggestion
assert(GetTransactionSigOpCost(CTransaction(spendingTx), coins, /*flags=*/0) == 0);
```

💬 instagibbs commented on pull request "test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`":
(https://github.com/bitcoin/bitcoin/pull/33624#discussion_r2429816763)
we're not ignoring, we're not setting it
```suggestion
// P2SH sigops are not counted if we don't set the SCRIPT_VERIFY_P2SH flag
```

👋 instagibbs's pull request is ready for review: "TxGraph: change m_excluded_clusters"
(https://github.com/bitcoin/bitcoin/pull/33469)

💬 instagibbs commented on pull request "TxGraph: change m_excluded_clusters":
(https://github.com/bitcoin/bitcoin/pull/33469#issuecomment-3402795146)
ready for review