💬 yancyribbens commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#issuecomment-3402801716)
cc @furszy as related to https://github.com/bitcoin/bitcoin/issues/33168

🤔 instagibbs reviewed a pull request: "txgraph: randomize order of same-feerate distinct-cluster transactions"
(https://github.com/bitcoin/bitcoin/pull/33335#pullrequestreview-3336623868)
Thinking a bit more on the fact that this randomizes eviction ordering in addition to INV gossiping, but rebase was straight forward

`git range-diff master 593d418137e4802bbe229707dcda5796522e2e5e 949353ac63249bf51fce34f50ac27f6ec51d0172`

💬 instagibbs commented on pull request "txgraph: randomize order of same-feerate distinct-cluster transactions":
(https://github.com/bitcoin/bitcoin/pull/33335#discussion_r2429842707)
seems this got lost in rebase?
```suggestion
* equal-feerate transactions in distinct clusters, to avoid leaking insertion order. */
```

📝 fanquake opened a pull request: "ci: run native fuzz with MSAN job"
(https://github.com/bitcoin/bitcoin/pull/33626)
I think this job should exist in this repo (not just qa-assets), if the alternative is double-handling changes to the interpreter (regardless of if it's to work around false positives). #32998 made changes which are now being re-changed in #33600, to work around the false positive mentioned there (so the job should currently fail here).

💬 dergoegge commented on pull request "ci: run native fuzz with MSAN job":
(https://github.com/bitcoin/bitcoin/pull/33626#issuecomment-3402849862)
Concept ACK

💬 ismaelsadeeq commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-3402862243)
Forced push from db5c7ed388a8eb72247dff015bbf47654f27faf1 to 9eea72d3f3647197c24329b412c7fc71895e3ea2 Compare diff [4f27faf1..9eea72d](https://github.com/bitcoin/bitcoin/compare/db5c7ed388a8eb72247dff015bbf47654f27faf1..9eea72d3f3647197c24329b412c7fc71895e3ea2)

I've believed @sipa recent comment https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-3401998439 is now fixed, I've maintained the error code and add the additional information in the debug message.

> Somewhat related questi
...

👍 stickies-v approved a pull request: "doc: archive release notes for v29.2"
(https://github.com/bitcoin/bitcoin/pull/33610#pullrequestreview-3336705070)
ACK c11a3dcc88950d35cc8a97c6afba7d8f7eff9883, matches https://github.com/bitcoin/bitcoin/blob/3226616493289b111997bb107e569fef54386743/doc/release-notes.md

🚀 fanquake merged a pull request: "doc: archive release notes for v29.2"
(https://github.com/bitcoin/bitcoin/pull/33610)

💬 fanquake commented on pull request "ci: run native fuzz with MSAN job":
(https://github.com/bitcoin/bitcoin/pull/33626#issuecomment-3402903110)
This has actually failed in a different way. Looks like #30760?

📝 maflcko opened a pull request: "ci: Remove unused workaround: sysctl -w vm.mmap_rnd_bits=28"
(https://github.com/bitcoin/bitcoin/pull/33627)
Remove the workaround that is no longer needed.

💬 diegoviola commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3402926319)
@hebasto @pablomartin4btc can we just get rid of the problematic code in this case? According to this comment: https://github.com/swaywm/sway/issues/4739#issuecomment-555965289

"Qt.WindowStaysOnTopHint won't work on Wayland. Clients don't get to dictate whether they stay on top or not.".

✅ maflcko closed a pull request: "ci: Remove unused workaround: sysctl -w vm.mmap_rnd_bits=28"
(https://github.com/bitcoin/bitcoin/pull/33627)

💬 maflcko commented on pull request "ci: Remove unused workaround: sysctl -w vm.mmap_rnd_bits=28":
(https://github.com/bitcoin/bitcoin/pull/33627#issuecomment-3402929530)
Ah, nvm. Sorry.

🤔 pinheadmz reviewed a pull request: "Introduce SockMan ("lite"): low-level socket handling for HTTP"
(https://github.com/bitcoin/bitcoin/pull/32747#pullrequestreview-3324351471)
Rebase to 03ce73a820b485fbdbb854d9d3947ff1e6d87880 address conflicts with master, as well as silent conflict from https://github.com/bitcoin/bitcoin/pull/33378. Address feedback from @l0rinc THANKS -- mostly improving "modernization" of the code borrowed from `Connman`.

There is a bigger question about the approach in this PR, which adds code that is dead for now but required for https://github.com/bitcoin/bitcoin/pull/32061. I am going to explore other ways to introduce this code more incremen
...

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2429818401)
good idea, i'll insert a new "modernize" commit after the move-only `GetBindAddress` commit

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2420892943)
Good call, this value is setting a boolean option to `true` so I made the variable name more explicit, in the "modernize" commit.

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2429400209)
I don't think we could reliably test these paths in ci because such socket operations depend so much on the platform.

We *could* create additional child classes of `DynSock` for the unit tests, so we have mock socket variants that fail each specific option, but I'm not sure we'd get enough value from those tests to be worth the work. Could be a follow up.

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2429627125)
yes thanks

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2429404525)
that's nice, thanks

💬 pinheadmz commented on pull request "Introduce SockMan ("lite"): low-level socket handling for HTTP":
(https://github.com/bitcoin/bitcoin/pull/32747#discussion_r2421914543)
Good call, will use `util::Result` here and remove the error string as an "out" parameter.