Bitcoin Core Github
44 subscribers
120K links
Download Telegram
fanquake closed an issue: "v30rc1 Weird GUI windowing behavior"
(https://github.com/bitcoin/bitcoin/issues/33432)
🚀 fanquake merged a pull request: "depends: static libxcb-cursor"
(https://github.com/bitcoin/bitcoin/pull/33434)
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3365921555)
Backported to `30.x` in #33473.
👋 fanquake's pull request is ready for review: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473)
🤔 ismaelsadeeq reviewed a pull request: "contrib: fix macOS deployment with no translations"
(https://github.com/bitcoin/bitcoin/pull/33482#pullrequestreview-3299314364)
ACK 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7


Makes sense to only {execute the translation available instructions} when a translation file is passed.

On master

```terminal
+ Adding Qt translations +
Traceback (most recent call last):
File "/Users/abubakarismail/Desktop/Work/bitcoin-dev/bitcoin/contrib/macdeploy/./macdeployqtplus", line 465, in <module>
translations = Path(config.translations_dir[0])
~~~~~~~~~~~~~~~~~~~~~~~^^^
TypeError: 'NoneType' object is not s
...
💬 fanquake commented on pull request "[30.x] Backports & rc3":
(https://github.com/bitcoin/bitcoin/pull/33473#issuecomment-3365932194)
Edited https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft to remove the mention of the `libxcb-cursor` runtime requirement.
🚀 fanquake merged a pull request: "contrib: fix macOS deployment with no translations"
(https://github.com/bitcoin/bitcoin/pull/33482)
💬 fanquake commented on pull request "contrib: fix macOS deployment with no translations":
(https://github.com/bitcoin/bitcoin/pull/33482#issuecomment-3365981788)
Backported to `30.x` in #33473.
💬 Crypt-iQ commented on pull request "test: addrman: check isTerrible when time is more than 10min in the future":
(https://github.com/bitcoin/bitcoin/pull/33533#issuecomment-3366011629)
crACK 8e47ed6906d5e381498681e2cab9f2e318597705
🤔 alexanderwiederin reviewed a pull request: "kernel: Introduce initial C header API"
(https://github.com/bitcoin/bitcoin/pull/30595#pullrequestreview-3295024865)
Have been using this API extensively. Can attest to:

- Appropriate API scope
- No symbol pollution
- Consistent naming conventions within the header
- Good ergonomics in practice
- No memory leaks or resource management issues discovered

Made some cosmetic suggestions.

ACK https://github.com/bitcoin/bitcoin/pull/30595/commits/f3ca1d65b0444097fd0e2f059a01eb5b29c950c1
💬 alexanderwiederin commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2399105059)
```suggestion
* @brief Reads the block the passed in block tree entry points to from disk and
```
💬 alexanderwiederin commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2399222152)
```
* validation objects are instantiated from it, the context is kept in memory
* for the duration of their lifetimes.
```
to align with https://github.com/bitcoin/bitcoin/pull/30595/commits/43f850c1ae9a66d8de599b81d3d78e7178c12251
💬 alexanderwiederin commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2399324228)
nit: should be in the next commit I think
💬 alexanderwiederin commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2399283588)
Should be introduced earlier I believe
💬 alexanderwiederin commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2399303605)
Do we need copyright here?
📝 fanquake opened a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535)
Backports:
* #33504
💬 fanquake commented on pull request "Mempool: Do not enforce TRUC checks on reorg":
(https://github.com/bitcoin/bitcoin/pull/33504#issuecomment-3366152838)
Backported to 28.x in #33535.
💬 fanquake commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2402371308)
`libxcb-cursor` can be removed now.
💬 fanquake commented on pull request "contrib: fix macOS deployment with no translations":
(https://github.com/bitcoin/bitcoin/pull/33482#issuecomment-3366186004)
Backported to `29.x` in #33534.