Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 Christewart commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3366229922)
> > One thing I noticed was the getwalletinfo RPC removed the fields balance, immature_balance, and unconfirmed_balance from the RPC result in [0ec2551](https://github.com/bitcoin/bitcoin/commit/0ec255139be3745a135386e9db957fe81bc3d833). Is this worth a release note?
>
> [@Christewart](https://github.com/Christewart) it was mentioned in the PR: [#32721 (comment)](https://github.com/bitcoin/bitcoin/pull/32721#issuecomment-3006074516). [@achow101](https://github.com/achow101) do you want to add o
...
💬 fanquake commented on pull request "wallet: don't consider unconfirmed TRUC coins with ancestors":
(https://github.com/bitcoin/bitcoin/pull/33528#issuecomment-3366268611)
Is this going to be backported to `30.x`?
💬 davidgumberg commented on pull request "[29.x] Finalise 29.2rc2":
(https://github.com/bitcoin/bitcoin/pull/33534#issuecomment-3366274330)
ACK https://github.com/bitcoin/bitcoin/pull/33534/commits/ca86f3645e1c49d9a2b95c70e475e27f2fc87d4b

I compared this to other PR's (#32766) of the "finalize format", and this has the two finalizing chagnes:
- this bumps the build version in the 29.x branch
- updates the versions in the manpages.

I compared the backport commit https://github.com/bitcoin/bitcoin/pull/33534/commits/6b3c1dbc5c0df4357ee7f57ac238bcdff55526af to https://github.com/bitcoin/bitcoin/pull/33482/commits/7b5261f7ef3d
...
📝 frankomosh opened a pull request: "doc: add coverage instrumentation hint to libFuzzer quickstart"
(https://github.com/bitcoin/bitcoin/pull/33536)
This patch shows how to enable clang source-based coverage instrumentation in the libFuzzer quickstart section. No defaults are changed, and the addition is intended to be optional.

Fixes silent "no .profraw file" confusion/error when trying to generate coverage data.
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2402470414)
Done.
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2402470769)
Done.
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2402472467)
Added some explanation in the commit message. Please let me know if it makes it more clear.
👋 frankomosh's pull request is ready for review: "doc: add coverage instrumentation hint to libFuzzer quickstart"
(https://github.com/bitcoin/bitcoin/pull/33536)
📝 fanquake converted_to_draft a pull request: "Update libmultiprocess subtree to support reduced logging"
(https://github.com/bitcoin/bitcoin/pull/33518)
Includes:

- https://github.com/bitcoin-core/libmultiprocess/pull/213
- https://github.com/bitcoin-core/libmultiprocess/pull/214
- https://github.com/bitcoin-core/libmultiprocess/pull/221
- https://github.com/bitcoin-core/libmultiprocess/pull/220

The last change is needed to support #33517 and fix poor performance in some cases caused by slow logging.

The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https
...
🤔 glozow reviewed a pull request: "[29.x] Finalise 29.2rc2"
(https://github.com/bitcoin/bitcoin/pull/33534#pullrequestreview-3299962725)
lgtm 513cef75ee06bc5d310a22d366a5f3c815aa1499. Got the same manpages, no changes to examples/bitcoin.conf or bips.md.

I think the release notes need to be updated
💬 glozow commented on pull request "[29.x] Finalise 29.2rc2":
(https://github.com/bitcoin/bitcoin/pull/33534#discussion_r2402655206)
Need to update release notes for #33482, no?
💬 glozow commented on pull request "[29.x] Finalise 29.2rc2":
(https://github.com/bitcoin/bitcoin/pull/33534#discussion_r2402669380)
I also don't see #32989
💬 glozow commented on pull request "wallet: don't consider unconfirmed TRUC coins with ancestors":
(https://github.com/bitcoin/bitcoin/pull/33528#issuecomment-3366489897)
> Is this going to be backported to 30.x?

I think that'd be best so that the behavior is consistent from v30 onwards.
💬 fanquake commented on pull request "[29.x] Finalise 29.2rc2":
(https://github.com/bitcoin/bitcoin/pull/33534#discussion_r2402679207)
Added a commit.
🤔 glozow reviewed a pull request: "[29.x] Finalise 29.2rc2"
(https://github.com/bitcoin/bitcoin/pull/33534#pullrequestreview-3300018391)
ACK d82fc69829cd8cabbaf2c3a969597b40c32edc86
💬 davidgumberg commented on pull request "[29.x] Finalise 29.2rc2":
(https://github.com/bitcoin/bitcoin/pull/33534#issuecomment-3366521126)
reACK d82fc69
👍 darosior approved a pull request: "[29.x] Finalise 29.2rc2"
(https://github.com/bitcoin/bitcoin/pull/33534#pullrequestreview-3300035989)
utACK 513cef75ee06bc5d310a22d366a5f3c815aa1499. Changes look good to me, but i have not been through the process of regenerating the doc myself.