💬 katesalazar commented on pull request "ci: check if file or directory already exists for ${HOME}/.bitcoin instead of failing":
(https://github.com/bitcoin/bitcoin/pull/33486#discussion_r2385066324)
You can't leave this line unchanged.

💬 0xhlin commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3342908639)
Thanks for this amazing project!

💬 andrewtoth commented on pull request "test: set par=2 in default config for functional test framework":
(https://github.com/bitcoin/bitcoin/pull/33485#issuecomment-3343177555)
> Q: does this affect the "-par=1" cases

No, extra args override args in the configuration file.

💬 RandyMcMillan commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3343829884)
tACK

---
It may be worth mentioning that this change fixed an issue (I was unable to isolate) on CentOS using HexStr() formatting a custom signetchallenge to display in the rpcconsole.

💬 cedwies commented on pull request "tests: cover abortrescan() in-flight True path with dynamic-tail retry":
(https://github.com/bitcoin/bitcoin/pull/33131#discussion_r2386173084)
Thank you for checking in. I lost focus of this PR, but I am still thinking about how to design this test without a race condition. I'll try to find a solution within the next days, or else I am going to close this PR.

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3343837654)
rebase on top of gui/master

temporarily cherry-pick PR https://github.com/bitcoin/bitcoin/pull/29838 to fix an issue.

💬 kevkevinpal commented on pull request "ci: check if file or directory already exists for ${HOME}/.bitcoin instead of failing":
(https://github.com/bitcoin/bitcoin/pull/33486#discussion_r2386185640)
Updated now in [3f5596f](https://github.com/bitcoin/bitcoin/pull/33486/commits/3f5596fd137b8833501ac4bd5ab9793f9485c9da)

💬 kevkevinpal commented on pull request "ci: check if file or directory already exists for ${HOME}/.bitcoin instead of failing":
(https://github.com/bitcoin/bitcoin/pull/33486#discussion_r2386185788)
I removed the explanation in [3f5596f](https://github.com/bitcoin/bitcoin/pull/33486/commits/3f5596fd137b8833501ac4bd5ab9793f9485c9da) now we can have this explanation here since it is more accurate

💬 hebasto commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2386223955)
Please keep `uname -m`, as different build platforms may produce different output, which could lead to cross-platform non-reproducibility:

```
uname -m && ...
```

💬 hebasto commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2386224466)
`$(git rev-parse --short=12 HEAD)` won't work for tags. However, that's not the case for pull requests.

🚀 fanquake merged a pull request: "doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness)"
(https://github.com/bitcoin/bitcoin/pull/33484)

📝 fanquake opened a pull request: "ci: use latest versions of lint deps"
(https://github.com/bitcoin/bitcoin/pull/33487)
Some of the versions used here are > 2 years old. i.e `mypy`. Use the latest avilable versions, except for LIEF, which is generally changed with Guix.

Side note. I can't remember the last time one of these tools (mypy, ruff, vulture) actually caught an issue in the lint job.

💬 fanquake commented on pull request "doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness)":
(https://github.com/bitcoin/bitcoin/pull/33484#issuecomment-3344323996)
Backported to 30.x in #33473.

📝 fanquake converted_to_draft a pull request: "cmake: exclude secp256k1 from all"
(https://github.com/bitcoin/bitcoin/pull/33390)
Instead of setting the EXCLUDE_FROM_ALL target property, pass EXCLUDE_FROM_ALL to `add_subdirectory()`.

This has the following advanteges:

* It is shorter (obviously).
* Target properties are set only in the `CMakeLists.txt` file that defines the target.
* Install rules defined in the subdirectory are excluded as well. This is what we want, because secp256k1 is linked statically.

💬 winterrdog commented on pull request "Avoid file overwriting in fallback `AllocateFileRange` implementation":
(https://github.com/bitcoin/bitcoin/pull/33164#discussion_r2386399909)
@cedwies @luke-jr
since this part of the code's gonna be run on POSIX systems only, i think trying out the `lseek()` system call can be of help. it is reliable on large files, sparse file aware and portable across Unix systems since it is a POSIX-standard syscall.

what do you think of this?

⚠️ ajtowns opened an issue: "[29.x] guix build failure on ppc with xcb"
(https://github.com/bitcoin/bitcoin/issues/33488)
Doing a guix build on the 29.x branch (both with v29.1, v29.2rc1 and f6d49d0a0995ad736c3462bb5cd9d2177d77c970) fails for me on powerpc (and powerpcle) seemingly related to xcb. Previous failures have just given me an error abort after some xcb install commands without indicating what failed, the latest failure gave this error:

```
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating xkbcommon.
...

💬 feroz333GP commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-3344438252)
Help me write a code from my bitget app account to my valer account so I can withdraw with my local bank account

💬 gomagic2100 commented on issue "`bitcoin-node` is unkillable after mining IPC connection is established":
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3344544160)
👍

💬 ajtowns commented on pull request "rpc: Fix dumptxoutset rollback with competing forks":
(https://github.com/bitcoin/bitcoin/pull/33444#issuecomment-3344697419)
> dumptxoutset rollback fails when competing forks are present at the target height, even though it should work on the active chain regardless of forks.

Couldn't this just be a contrib script or client-side bitcoin-cli feature? ie:

```
$ bitcoin-cli -invalidateto=00000000000000000001f3222fa4ad883d2d211443a77ecdec05604f4e253a02
```

which first looks up that block hash's height N, then iterates through each chain tip whose height is at least N, getting that tip's ancestor at height N+1
...

💬 ajtowns commented on pull request "Rollback for dumptxoutset without invalidating blocks":
(https://github.com/bitcoin/bitcoin/pull/33477#issuecomment-3344719601)
Nice!

> performance is slower (master took 3m 17s vs 9m 16s in my last test with the code here,

That probably makes sense. It might be possible to do it faster and with less disk usage for relatively short rollbacks via a two step process:

* create a read-only snapshot of the db
* create an empty "coins-delta" db
* iterate through the rev data to rollback, update the coins-delta db:
* when you rollback past a coin's creation:
* if the coin was in the snapshot db, add "[
...