📝 maflcko opened a pull request: "ci: Drop support for EOL macOS 13"
(https://github.com/bitcoin/bitcoin/pull/33489)
Now that macOS 13 is EOL (https://en.wikipedia.org/wiki/MacOS_Ventura), it seems odd to still support it.

No breaking changes are expected, and this patch will only be released in version 31.x, another 6 months out from now.

So:

* Update the release note template to drop EOL macOS 13.
* As a result, update the earliest Xcode to version 16 in CI.
* Also, bump the macOS CI runner to version 15, to avoid issues when version 14 will be at its EOL in about 1 year.

This does not affect c
...

💬 maflcko commented on pull request "ci: add libcpp hardening flags to macOS fuzz job":
(https://github.com/bitcoin/bitcoin/pull/33462#discussion_r2386747883)
Done in https://github.com/bitcoin/bitcoin/pull/33489

💬 maflcko commented on issue "[29.x] guix build failure on ppc with xcb":
(https://github.com/bitcoin/bitcoin/issues/33488#issuecomment-3345065399)
> Previous failures have just given me an error abort after some xcb install commands without indicating what failed, the latest failure gave this error:

So the failure is non-deterministic? Does it happen with a fully clean git repo?

💬 Akadosky1983 commented on issue "[29.x] guix build failure on ppc with xcb":
(https://github.com/bitcoin/bitcoin/issues/33488#issuecomment-3345068019)
👍

💬 l3tc commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3345094565)

RISC-V 64 / OrangePi RV2 / Ubuntu 24.04

Completed IBD over Tor on 30.0rc1. Passed the [testing guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/30.0-Release-Candidate-Testing-Guide) on 30.0rc2. Pre-compiled binaries were used in both cases.

💬 maflcko commented on pull request "ci: check if file or directory already exists for ${HOME}/.bitcoin instead of failing":
(https://github.com/bitcoin/bitcoin/pull/33486#issuecomment-3345157086)
I don't think it is supported or even encouraged to run this internal CI script on an outside machine. Also, I fail to see how this could even work, as you did not include any steps how to reproduce.

⚠️ maflcko reopened an issue: "ci: GHA fallback centos task runs out of space"
(https://github.com/bitcoin/bitcoin/issues/33293)
https://github.com/bitcoin-core/gui/actions/runs/17433074590/job/49495964258?pr=884#step:8:3785

```
...
+ eval 'TEST_RUNNER_EXTRA=()'
++ TEST_RUNNER_EXTRA=()
+ LD_LIBRARY_PATH=/home/runner/work/_temp/depends/x86_64-pc-linux-gnu/lib
+ /home/runner/work/_temp/build/test/functional/test_runner.py --ci -j4 --tmpdirprefix /home/runner/work/_temp/ci/scratch/test_runner/ --ansi --combinedlogslen=99999999 --timeout-factor=40 --quiet --failfast
WARNING! There may be insufficient free space in /home/runn
...

💬 maflcko commented on issue "ci: GHA fallback centos task runs out of space":
(https://github.com/bitcoin/bitcoin/issues/33293#issuecomment-3345162077)
Still happening: https://github.com/bitcoin-core/gui/actions/runs/18064088639

💬 maflcko commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3345164318)
> It may be worth mentioning that this change fixed an issue (I was unable to isolate) on CentOS using HexStr() formatting a custom signetchallenge to display in the rpcconsole.

That is unrelated to both this pull request and your pull request, see https://github.com/bitcoin/bitcoin/issues/33293.

💬 ajtowns commented on issue "[29.x] guix build failure on ppc with xcb":
(https://github.com/bitcoin/bitcoin/issues/33488#issuecomment-3345200636)
> > Previous failures have just given me an error abort after some xcb install commands without indicating what failed, the latest failure gave this error:
>
> So the failure is non-deterministic? Does it happen with a fully clean git repo?

It's part of the "depends" setup, which caches the downloaded source and build between runs afaics? I think that's the source of the differences in error. I tried it from a cleaned out checkout before, but will try again to see the exact error.

💬 maflcko commented on pull request "test: set par=2 in default config for functional test framework":
(https://github.com/bitcoin/bitcoin/pull/33485#issuecomment-3345215920)
lgtm ACK dda5228e02ca6a839bf87ae7dbd133547563816a

💬 ajtowns commented on issue "[29.x] guix build failure on ppc with xcb":
(https://github.com/bitcoin/bitcoin/issues/33488#issuecomment-3345222853)
Ah, there we go; these look like relevant lines:

```
$ HOSTS=powerpc64-linux-gnu contrib/guix/guix-build
...
xcb_auth.c:74:37: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
74 | #define AUTH_PROTO_MIT_MAGIC_COOKIE "MIT-MAGIC-COOKIE-1"
| ^~~~~~~~~~~~~~~~~~~~
xcb_auth.c:80:5: note: in expansion of macro 'AUTH_PROTO_MIT_MAGIC_COOKIE'
80 | AUTH_PROTO_MIT_MAGIC_COOKIE,
| ^~~~~~~~~~~~~
...

💬 maflcko commented on pull request "ci: use latest versions of lint deps":
(https://github.com/bitcoin/bitcoin/pull/33487#issuecomment-3345453011)
> Side note. I can't remember the last time one of these tools (mypy, ruff, vulture) actually caught an issue in the lint job.

The last thing mypy found was a false positive: https://github.com/bitcoin/bitcoin/pull/33201#issuecomment-3192610057 and https://github.com/bitcoin/bitcoin/pull/33201#discussion_r2284671990

Ruff is doing basically all python checks and finds stuff frequently: E.g. https://github.com/bitcoin/bitcoin/pull/33270#issuecomment-3236372196

vulture is only doing small
...

💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3345454480)
This build works for me when I don't have `libxcb-cursor0` installed

💬 maflcko commented on pull request "ci: use latest versions of lint deps":
(https://github.com/bitcoin/bitcoin/pull/33487#issuecomment-3345455571)
lgtm ACK aeab2c7f1d151beda3eff94fb4effc85a4d4a344

🤔 hodlinator reviewed a pull request: "ci: Drop support for EOL macOS 13"
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3278413474)
Reviewed fab9ddaf554837624fa8f388e046a30d5bf7626f

💬 hodlinator commented on pull request "ci: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#discussion_r2387051017)
Seems fine to push GH CI one version ahead of supported OS. Then again, it would be nice to have test coverage of minimum version as well?

💬 hodlinator commented on pull request "ci: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#discussion_r2387053565)
nit: Noticed 15 still technically supports x86: https://en.wikipedia.org/wiki/MacOS_Sequoia - so could keep arm64.

🤔 janb84 reviewed a pull request: "ci: use latest versions of lint deps"
(https://github.com/bitcoin/bitcoin/pull/33487#pullrequestreview-3278533531)
Concept ACK aeab2c7f1d151beda3eff94fb4effc85a4d4a344

This PR updates lint dependency packages to the latests versions.

Small NIT / question about ruff version.

💬 janb84 commented on pull request "ci: use latest versions of lint deps":
(https://github.com/bitcoin/bitcoin/pull/33487#discussion_r2387129503)
Why ruff 0.13.1 and not 0.13.2 ? or was it updated between PR creation and now ?