👍 vasild approved a pull request: "log: reduce excessive "rolling back/forward" messages during block replay"
(https://github.com/bitcoin/bitcoin/pull/33443#pullrequestreview-3261411627)
ACK ae26c59b92b5fc082faaeafca576a9d9f7e4549f

💬 vasild commented on pull request "log: reduce excessive "rolling back/forward" messages during block replay":
(https://github.com/bitcoin/bitcoin/pull/33443#discussion_r2374711347)
The `while` and the `if` just below it assume that if `pindexOld != pindexFork` is true, then `pindexOld` is not `nullptr`. So, `pindexOld && ` can be removed from the newly added `if`.

💬 vasild commented on pull request "log: reduce excessive "rolling back/forward" messages during block replay":
(https://github.com/bitcoin/bitcoin/pull/33443#discussion_r2374707112)
Previously every block would have been printed. Now the start will be printed and then every 10'000th, but not the end, e.g.:

```
rolling back from 54321 to 29238
rolling back 50000
rolling back 40000
rolling back 30000
// and nothing more
```
Would it be useful to indicate that the process has completed? E.g. one more message "rolled back successfully to 29238" after the loop?

Same for the "rolling forward" case.

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3326991984)
> Fixes #33432.

The issue is titled "v30rc1 Weird GUI windowing behavior", but `libxcb-cursor0` is [unrelated](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312837619) to it.

---

Is there any particular reason to rush this PR into v30.0?

💬 hebasto commented on issue "RFC: Migration from NSUserNotificationCenter to UNUserNotificationCenter on macOS":
(https://github.com/bitcoin-core/gui/issues/112#issuecomment-3327149264)
Related: https://bugreports.qt.io/browse/QTBUG-110998.

💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327181607)
> but libxcb-cursor0 is unrelated to it.

Installing libxcb-cursor fixes the windowing behaviour?

> Is there any particular reason to rush this PR into v30.0?

I'd prefer if we were shipping a gui which didn't require non technical users to install runtime dependencies.

💬 hebasto commented on issue "Create a Design Issue template for sharing designs":
(https://github.com/bitcoin-core/gui/issues/132#issuecomment-3327185449)
> With the Bitcoin Design community getting more involved with core, designs are / will begin to be shared more often by designers.

Recently, designers' efforts have been focused primarily on https://github.com/bitcoin-core/gui-qml.

Closing.

✅ hebasto closed an issue: "Create a Design Issue template for sharing designs"
(https://github.com/bitcoin-core/gui/issues/132)

✅ hebasto closed an issue: "[RFC] test: Clean test_bitcoin-qt output"
(https://github.com/bitcoin-core/gui/issues/222)

💬 hebasto commented on issue "Long(V3) Onion address is not wrapped in peer details":
(https://github.com/bitcoin-core/gui/issues/262#issuecomment-3327234495)
Closing.

Feel free to open a new issue if needed..

✅ hebasto closed an issue: "Long(V3) Onion address is not wrapped in peer details"
(https://github.com/bitcoin-core/gui/issues/262)

📝 janb84 opened a pull request: "guix: documented shasum gathering command"
(https://github.com/bitcoin/bitcoin/pull/33472)
When a PR requires proof of Guix builds (sha256sums), the PR author or reviewer uses a not well documented command to collect the sha256sums of build outputs or manually gathers them from files.

This pull request introduces a new section in the documentation, providing some documentation on the command's functionality and usage.

💬 janb84 commented on pull request "guix: Added guix-shasums script for gathering and formatting build output checksums":
(https://github.com/bitcoin/bitcoin/pull/33465#issuecomment-3327244261)
closing in favour of #33472

Thanks for the feedback

✅ janb84 closed a pull request: "guix: Added guix-shasums script for gathering and formatting build output checksums"
(https://github.com/bitcoin/bitcoin/pull/33465)

💬 hebasto commented on issue "Translation using XLIFF file":
(https://github.com/bitcoin-core/gui/issues/287#issuecomment-3327249870)
Closed via https://github.com/bitcoin/bitcoin/commit/90e0faaa442b6ced94aee2fa9d9d21c4063d76be.

✅ hebasto closed an issue: "Translation using XLIFF file"
(https://github.com/bitcoin-core/gui/issues/287)

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3327255336)
utACK 6bcf96c

✅ hebasto closed an issue: "The Bitcoin Design Guide adoption"
(https://github.com/bitcoin-core/gui/issues/352)

💬 maflcko commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375053958)


the guix builds use a time machine, so the description of the host guix should be irrelevant and is confusing to put here, no?

💬 maflcko commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375057101)
I think it is easier to keep this a one-line, to make copy-pasting easier?