💬 hebasto commented on issue "Consider factoring out "bitcoins" string in AskPassphraseDialog":
(https://github.com/bitcoin-core/gui/issues/380#issuecomment-3327284157)
> > If you want to make changes that improve the code here, that's fine, but
> > > and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.
> >
> >
> > that alone is not going to be a reason for us to make changes in our codebase.
>
> Yes, I know. The primary reason I'd hope for this change to be made is just that it makes the code cleaner, as with the merged PR that I linked.
Closing for now. Feel free to open a PR to continue the di
...
(https://github.com/bitcoin-core/gui/issues/380#issuecomment-3327284157)
> > If you want to make changes that improve the code here, that's fine, but
> > > and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.
> >
> >
> > that alone is not going to be a reason for us to make changes in our codebase.
>
> Yes, I know. The primary reason I'd hope for this change to be made is just that it makes the code cleaner, as with the merged PR that I linked.
Closing for now. Feel free to open a PR to continue the di
...
✅ hebasto closed an issue: "Consider factoring out "bitcoins" string in AskPassphraseDialog"
(https://github.com/bitcoin-core/gui/issues/380)
(https://github.com/bitcoin-core/gui/issues/380)
💬 hebasto commented on issue "R[v22.0] Font missing":
(https://github.com/bitcoin-core/gui/issues/425#issuecomment-3327301143)
> You're getting at two things here:
>
> 1. **BDB license info is missing?**
> I am not aware if the BDB license was ever in the `About Bitcoin` window. If what you're referring to the line in the `Information Tab` that used to show the current BDB version being used; that was removed in [Remove BDB version from the Information tab #118](https://github.com/bitcoin-core/gui/pull/118) as we have a deprecation plan to completely remove BDB in favor of sqlite.
>
> 2. **"Font issue" on
...
(https://github.com/bitcoin-core/gui/issues/425#issuecomment-3327301143)
> You're getting at two things here:
>
> 1. **BDB license info is missing?**
> I am not aware if the BDB license was ever in the `About Bitcoin` window. If what you're referring to the line in the `Information Tab` that used to show the current BDB version being used; that was removed in [Remove BDB version from the Information tab #118](https://github.com/bitcoin-core/gui/pull/118) as we have a deprecation plan to completely remove BDB in favor of sqlite.
>
> 2. **"Font issue" on
...
✅ hebasto closed an issue: "R[v22.0] Font missing"
(https://github.com/bitcoin-core/gui/issues/425)
(https://github.com/bitcoin-core/gui/issues/425)
💬 janb84 commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375087513)
Just tried to stay as close to the found command :
https://github.com/fanquake/core-review/tree/master/guix#build-output
Have changed it
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375087513)
Just tried to stay as close to the found command :
https://github.com/fanquake/core-review/tree/master/guix#build-output
Have changed it
💬 hebasto commented on issue "R[v22.0] Application icon":
(https://github.com/bitcoin-core/gui/issues/426#issuecomment-3327309798)
> Could you keep the OP focused on the reported bug only which is mentioned in the issue title?
> A similar bug in other project: https://bugs.documentfoundation.org/show_bug.cgi?id=125934
>
> Also from https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/:
>
> > On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the
...
(https://github.com/bitcoin-core/gui/issues/426#issuecomment-3327309798)
> Could you keep the OP focused on the reported bug only which is mentioned in the issue title?
> A similar bug in other project: https://bugs.documentfoundation.org/show_bug.cgi?id=125934
>
> Also from https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/:
>
> > On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the
...
✅ hebasto closed an issue: "R[v22.0] Application icon"
(https://github.com/bitcoin-core/gui/issues/426)
(https://github.com/bitcoin-core/gui/issues/426)
💬 hMsats commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327325279)
I've used `-datacarrier` and `-datacarriersize` in the past but have removed them based on all the recent discussions (especially Gregory Maxwell on Reddit) and am in favor of the recent default settings in Bitcoin Core 30.0. However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them. I also believe this documentation change is worth holding up the release for.
ACK
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327325279)
I've used `-datacarrier` and `-datacarriersize` in the past but have removed them based on all the recent discussions (especially Gregory Maxwell on Reddit) and am in favor of the recent default settings in Bitcoin Core 30.0. However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them. I also believe this documentation change is worth holding up the release for.
ACK
💬 Kruwed commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327350787)
>However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them.
"Expressing disgust" is not a reasonable use case. Why do you think that Bitcoin Core should cater towards emotional outbursts?
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327350787)
>However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them.
"Expressing disgust" is not a reasonable use case. Why do you think that Bitcoin Core should cater towards emotional outbursts?
💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327376933)
> > but libxcb-cursor0 is unrelated to it.
>
> Installing libxcb-cursor fixes the windowing behaviour?
No, it doesn't. The user [tested](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312812001) different binaries, rather than running the same binary with and without libxcb-cursor installed.
> > Is there any particular reason to rush this PR into v30.0?
>
> I'd prefer if we were shipping a gui which didn't require non technical users to install runtime dependencies.
...
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327376933)
> > but libxcb-cursor0 is unrelated to it.
>
> Installing libxcb-cursor fixes the windowing behaviour?
No, it doesn't. The user [tested](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312812001) different binaries, rather than running the same binary with and without libxcb-cursor installed.
> > Is there any particular reason to rush this PR into v30.0?
>
> I'd prefer if we were shipping a gui which didn't require non technical users to install runtime dependencies.
...
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327398830)
> No, it doesn't. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.
The comment in this thread claims that a Guix build of this PR does not have the windowing bug: https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327398830)
> No, it doesn't. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.
The comment in this thread claims that a Guix build of this PR does not have the windowing bug: https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332
💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327410871)
> > No, it doesn't. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.
>
> The comment in this thread claims that a Guix build of this PR does not have the windowing bug: [#33434 (comment)](https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332)
Sure. It never had it. The windowing bug is observed when using Qt 6.4.2 on Ubuntu.
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327410871)
> > No, it doesn't. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.
>
> The comment in this thread claims that a Guix build of this PR does not have the windowing bug: [#33434 (comment)](https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332)
Sure. It never had it. The windowing bug is observed when using Qt 6.4.2 on Ubuntu.
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327427018)
The initial issue was for a Guix built binary though: https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843 ?
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327427018)
The initial issue was for a Guix built binary though: https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843 ?
💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327444588)
> The initial issue was for a Guix built binary though: [#33434 (comment)](https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843) ?
That comment doesn’t make sense: "install libxcb-cursor0" cannot result in "removed dark mode". The user likely mixed up the binaries they ran.
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327444588)
> The initial issue was for a Guix built binary though: [#33434 (comment)](https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843) ?
That comment doesn’t make sense: "install libxcb-cursor0" cannot result in "removed dark mode". The user likely mixed up the binaries they ran.
💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3327532508)
Updated 2ac9d60c54a777978101c369f5895a933208a44c -> 21b0503c2f19f5e4662cea1ceecb425b8460967b ([kernelApi_66](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_66) -> [kernelApi_67](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_67), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_66..kernelApi_67))
* Expanded test coverage a bit more, no changes to the API.
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3327532508)
Updated 2ac9d60c54a777978101c369f5895a933208a44c -> 21b0503c2f19f5e4662cea1ceecb425b8460967b ([kernelApi_66](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_66) -> [kernelApi_67](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_67), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_66..kernelApi_67))
* Expanded test coverage a bit more, no changes to the API.
💬 bitschmidty commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327584051)
> This is the 3rd PR since #32406's merge discussing what the config options' docs should say.
Thank you to all who have reviewed and provided thoughtful feedback on this PR.
> I believe this PR tries to align the documentation with what users can expect. Usage of these options can cause the node to reject transactions that are likely to be mined, so the docs should discourage their use (to me, that means deprecated). However, it seems that removal in the near future is (1) unlikely and (
...
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327584051)
> This is the 3rd PR since #32406's merge discussing what the config options' docs should say.
Thank you to all who have reviewed and provided thoughtful feedback on this PR.
> I believe this PR tries to align the documentation with what users can expect. Usage of these options can cause the node to reject transactions that are likely to be mined, so the docs should discourage their use (to me, that means deprecated). However, it seems that removal in the near future is (1) unlikely and (
...
🤔 hebasto reviewed a pull request: "depends: static libxcb-cursor"
(https://github.com/bitcoin/bitcoin/pull/33434#pullrequestreview-3262163206)
Concept ACK. This is consistent with our [docs](https://github.com/bitcoin/bitcoin/blob/master/depends/packages.md#secondary-dependencies).
(https://github.com/bitcoin/bitcoin/pull/33434#pullrequestreview-3262163206)
Concept ACK. This is consistent with our [docs](https://github.com/bitcoin/bitcoin/blob/master/depends/packages.md#secondary-dependencies).
💬 maflcko commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3327728312)
> For the record a big-endian CI machine would have helped with #31144
It should be trivial to run the CI task locally, on demand. For development/debugging that should even be easier than to rely on a remove short-lived server. It should also be easy to temporarily add the config to the CI to trigger it on demand, if needed, similar to *BSD stuff, like https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2364674969.
Again, I am not against adding this. My only concern is that this wo
...
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3327728312)
> For the record a big-endian CI machine would have helped with #31144
It should be trivial to run the CI task locally, on demand. For development/debugging that should even be easier than to rely on a remove short-lived server. It should also be easy to temporarily add the config to the CI to trigger it on demand, if needed, similar to *BSD stuff, like https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2364674969.
Again, I am not against adding this. My only concern is that this wo
...
💬 maflcko commented on issue "ci: add (atleast one) *BSD job to the CI":
(https://github.com/bitcoin/bitcoin/issues/33438#issuecomment-3327754865)
This should be trivial to add, but requires a third-party action to be enabled. E.g.
* https://github.com/cross-platform-actions/action?tab=readme-ov-file#supported-platforms
* https://github.com/vmactions#hi-there-
* ...
So the main question here is how comfortable are we in trusting those actions to be enabled and run in this repo.
(https://github.com/bitcoin/bitcoin/issues/33438#issuecomment-3327754865)
This should be trivial to add, but requires a third-party action to be enabled. E.g.
* https://github.com/cross-platform-actions/action?tab=readme-ov-file#supported-platforms
* https://github.com/vmactions#hi-there-
* ...
So the main question here is how comfortable are we in trusting those actions to be enabled and run in this repo.
💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327769226)
@laanwj
You might want to take a look at this PR.
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327769226)
@laanwj
You might want to take a look at this PR.