💬 151henry151 commented on pull request "build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script":
(https://github.com/bitcoin/bitcoin/pull/33470#issuecomment-3326485536)
Guix build hashes for commit eb98b612f80f:

698ad81e49ed8fe64d3586fe7a87837c82fef4b0ec8477f1737587593eff424a dist-archive/bitcoin-eb98b612f80f.tar.gz
2e1cbd7e66128739582a7822c6ac06fc57b33061d0cbbcd86094dbc4624c02e5 x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu-debug.tar.gz
be406dc0f71c160a2a4173ff81b29f67e2b191a3331eaf4d6d905e7fd07e646b x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu.tar.gz

Build completed successfully on Linux x86_64.

🤔 yuvicc reviewed a pull request: "log: unify `UpdateTip` values"
(https://github.com/bitcoin/bitcoin/pull/32996#pullrequestreview-3260926110)
ACK b039305d3590aaf84bfdf3b3547b9311897f52c7

<details>
<summary>Logs</summary>

Before:

```bash
2025-09-24T04:47:28Z UpdateTip: new best=00000000000000c19c69a5f5ef54d4565102a4e28a59a05ebbf0cb5efba4bac6 height=236928 version=0x00000002 log2_work=70.073757 tx=18088438 date='2013-05-19T14:48:37Z' progress=0.014517 cache=2.4MiB(17642txo)
2025-09-24T04:47:28Z UpdateTip: new best=000000000000008c6591a7f59d653d83365426134522364a9bae323166efc3c8 height=236929 version=0x00000002 log2_work=70
...

👍 vasild approved a pull request: "ci: Update Clang in "tidy" job"
(https://github.com/bitcoin/bitcoin/pull/33445#pullrequestreview-3261242814)
ACK 5b20d172ca2a46a2b525201b4ff2444f9d415d8c

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3326764345)
> Nice. Should vanity grind that hash when/if we ever switch default signet challenge.

As far as I understand this change does not influence the default signet only custom ones.

See https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2672450161 for my total misunderstanding:)

💬 PiRK commented on pull request "test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage":
(https://github.com/bitcoin/bitcoin/pull/33381#issuecomment-3326828928)
Rebased, the phantom commit is gone now

💬 hebasto commented on issue "Make Close/OK buttons consistent across all windows":
(https://github.com/bitcoin-core/gui/issues/25#issuecomment-3326924376)
Closing.

It’s unlikely that further effort will be put into the current GUI design changes, given the ongoing development in https://github.com/bitcoin-core/gui-qml.

✅ hebasto closed an issue: "Make Close/OK buttons consistent across all windows"
(https://github.com/bitcoin-core/gui/issues/25)

💬 hebasto commented on issue "Maximum allowed requested length exceeded":
(https://github.com/bitcoin-core/gui/issues/47#issuecomment-3326941919)
> Qt has fixed this issue https://codereview.qt-project.org/c/qt/qtbase/+/408178

Closing.

✅ hebasto closed an issue: "Maximum allowed requested length exceeded"
(https://github.com/bitcoin-core/gui/issues/47)

👍 vasild approved a pull request: "log: reduce excessive "rolling back/forward" messages during block replay"
(https://github.com/bitcoin/bitcoin/pull/33443#pullrequestreview-3261411627)
ACK ae26c59b92b5fc082faaeafca576a9d9f7e4549f

💬 vasild commented on pull request "log: reduce excessive "rolling back/forward" messages during block replay":
(https://github.com/bitcoin/bitcoin/pull/33443#discussion_r2374711347)
The `while` and the `if` just below it assume that if `pindexOld != pindexFork` is true, then `pindexOld` is not `nullptr`. So, `pindexOld && ` can be removed from the newly added `if`.

💬 vasild commented on pull request "log: reduce excessive "rolling back/forward" messages during block replay":
(https://github.com/bitcoin/bitcoin/pull/33443#discussion_r2374707112)
Previously every block would have been printed. Now the start will be printed and then every 10'000th, but not the end, e.g.:

```
rolling back from 54321 to 29238
rolling back 50000
rolling back 40000
rolling back 30000
// and nothing more
```
Would it be useful to indicate that the process has completed? E.g. one more message "rolled back successfully to 29238" after the loop?

Same for the "rolling forward" case.

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3326991984)
> Fixes #33432.

The issue is titled "v30rc1 Weird GUI windowing behavior", but `libxcb-cursor0` is [unrelated](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312837619) to it.

---

Is there any particular reason to rush this PR into v30.0?

💬 hebasto commented on issue "RFC: Migration from NSUserNotificationCenter to UNUserNotificationCenter on macOS":
(https://github.com/bitcoin-core/gui/issues/112#issuecomment-3327149264)
Related: https://bugreports.qt.io/browse/QTBUG-110998.

💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327181607)
> but libxcb-cursor0 is unrelated to it.

Installing libxcb-cursor fixes the windowing behaviour?

> Is there any particular reason to rush this PR into v30.0?

I'd prefer if we were shipping a gui which didn't require non technical users to install runtime dependencies.

💬 hebasto commented on issue "Create a Design Issue template for sharing designs":
(https://github.com/bitcoin-core/gui/issues/132#issuecomment-3327185449)
> With the Bitcoin Design community getting more involved with core, designs are / will begin to be shared more often by designers.

Recently, designers' efforts have been focused primarily on https://github.com/bitcoin-core/gui-qml.

Closing.

✅ hebasto closed an issue: "Create a Design Issue template for sharing designs"
(https://github.com/bitcoin-core/gui/issues/132)

✅ hebasto closed an issue: "[RFC] test: Clean test_bitcoin-qt output"
(https://github.com/bitcoin-core/gui/issues/222)

💬 hebasto commented on issue "Long(V3) Onion address is not wrapped in peer details":
(https://github.com/bitcoin-core/gui/issues/262#issuecomment-3327234495)
Closing.

Feel free to open a new issue if needed..

✅ hebasto closed an issue: "Long(V3) Onion address is not wrapped in peer details"
(https://github.com/bitcoin-core/gui/issues/262)