📝 janb84 opened a pull request: "guix: documented shasum gathering command"
(https://github.com/bitcoin/bitcoin/pull/33472)
When a PR requires proof of Guix builds (sha256sums), the PR author or reviewer uses a not well documented command to collect the sha256sums of build outputs or manually gathers them from files.

This pull request introduces a new section in the documentation, providing some documentation on the command's functionality and usage.

💬 janb84 commented on pull request "guix: Added guix-shasums script for gathering and formatting build output checksums":
(https://github.com/bitcoin/bitcoin/pull/33465#issuecomment-3327244261)
closing in favour of #33472

Thanks for the feedback

✅ janb84 closed a pull request: "guix: Added guix-shasums script for gathering and formatting build output checksums"
(https://github.com/bitcoin/bitcoin/pull/33465)

💬 hebasto commented on issue "Translation using XLIFF file":
(https://github.com/bitcoin-core/gui/issues/287#issuecomment-3327249870)
Closed via https://github.com/bitcoin/bitcoin/commit/90e0faaa442b6ced94aee2fa9d9d21c4063d76be.

✅ hebasto closed an issue: "Translation using XLIFF file"
(https://github.com/bitcoin-core/gui/issues/287)

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3327255336)
utACK 6bcf96c

✅ hebasto closed an issue: "The Bitcoin Design Guide adoption"
(https://github.com/bitcoin-core/gui/issues/352)

💬 maflcko commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375053958)


the guix builds use a time machine, so the description of the host guix should be irrelevant and is confusing to put here, no?

💬 maflcko commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375057101)
I think it is easier to keep this a one-line, to make copy-pasting easier?

💬 hebasto commented on issue "Consider factoring out "bitcoins" string in AskPassphraseDialog":
(https://github.com/bitcoin-core/gui/issues/380#issuecomment-3327284157)
> > If you want to make changes that improve the code here, that's fine, but
> > > and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.
> >
> >
> > that alone is not going to be a reason for us to make changes in our codebase.
>
> Yes, I know. The primary reason I'd hope for this change to be made is just that it makes the code cleaner, as with the merged PR that I linked.

Closing for now. Feel free to open a PR to continue the di
...

✅ hebasto closed an issue: "Consider factoring out "bitcoins" string in AskPassphraseDialog"
(https://github.com/bitcoin-core/gui/issues/380)

💬 hebasto commented on issue "R[v22.0] Font missing":
(https://github.com/bitcoin-core/gui/issues/425#issuecomment-3327301143)
> You're getting at two things here:
>
> 1. **BDB license info is missing?**
> I am not aware if the BDB license was ever in the `About Bitcoin` window. If what you're referring to the line in the `Information Tab` that used to show the current BDB version being used; that was removed in [Remove BDB version from the Information tab #118](https://github.com/bitcoin-core/gui/pull/118) as we have a deprecation plan to completely remove BDB in favor of sqlite.
>
> 2. **"Font issue" on
...

✅ hebasto closed an issue: "R[v22.0] Font missing"
(https://github.com/bitcoin-core/gui/issues/425)

💬 janb84 commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#discussion_r2375087513)
Just tried to stay as close to the found command :
https://github.com/fanquake/core-review/tree/master/guix#build-output

Have changed it

💬 hebasto commented on issue "R[v22.0] Application icon":
(https://github.com/bitcoin-core/gui/issues/426#issuecomment-3327309798)
> Could you keep the OP focused on the reported bug only which is mentioned in the issue title?

> A similar bug in other project: https://bugs.documentfoundation.org/show_bug.cgi?id=125934
>
> Also from https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/:
>
> > On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the
...

✅ hebasto closed an issue: "R[v22.0] Application icon"
(https://github.com/bitcoin-core/gui/issues/426)

💬 hMsats commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327325279)
I've used `-datacarrier` and `-datacarriersize` in the past but have removed them based on all the recent discussions (especially Gregory Maxwell on Reddit) and am in favor of the recent default settings in Bitcoin Core 30.0. However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them. I also believe this documentation change is worth holding up the release for.

ACK

💬 Kruwed commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3327350787)
>However, I strongly oppose removing these options which so many people find useful to express their disgust for non-financial data in the block chain and therefore refuse to relay them.

"Expressing disgust" is not a reasonable use case. Why do you think that Bitcoin Core should cater towards emotional outbursts?

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327376933)
> > but libxcb-cursor0 is unrelated to it.
>
> Installing libxcb-cursor fixes the windowing behaviour?

No, it doesn't. The user [tested](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312812001) different binaries, rather than running the same binary with and without libxcb-cursor installed.

> > Is there any particular reason to rush this PR into v30.0?
>
> I'd prefer if we were shipping a gui which didn't require non technical users to install runtime dependencies.

...

💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3327398830)
> No, it doesn't. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.

The comment in this thread claims that a Guix build of this PR does not have the windowing bug: https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332