💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2373651147)
Changed the message.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2373652213)
It is supposed to sign when any descriptor has a private key for a participant. Added a test and fixed.

📝 151henry151 opened a pull request: "build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script"
(https://github.com/bitcoin/bitcoin/pull/33470)
Remove hardcoded CMAKE_SKIP_INSTALL_RPATH setting from CMakeLists.txt and add it as a CMake configuration option in the Guix build script. This makes the build system more portable by keeping build-environment-specific settings in the build scripts rather than hardcoded in the CMake configuration.

Changes:
- Remove set(CMAKE_SKIP_INSTALL_RPATH TRUE) from CMakeLists.txt
- Add -DCMAKE_SKIP_INSTALL_RPATH=TRUE to Guix build script cmake configuration

This addresses the feedback from hebasto in htt
...

⚠️ w0xlt opened an issue: "Inconsistent CJDNS address handling in Local addresses and AddLocal logs"
(https://github.com/bitcoin/bitcoin/issues/33471)
When running:

```bash
./build/bin/bitcoind -daemon -server=1 -onion=127.0.0.1:9050 -externalip=<hostname_addr> -listen -cjdnsreachable
```

only two Tor addresses appear under _Local addresses_ and no CJDNS addresses. The log also shows two `AddLocal(...)` entries for the onion address, but none for the CJDNS address. However, adding a CJDNS peer via `addnode ... add` works as expected.

In contrast, running:

```
./build/bin/bitcoind -daemon -listen -cjdnsreachable
```

shows one Tor address a
...

💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3325921683)
@fanquake yes!, done.

👍 davidgumberg approved a pull request: "test: fix p2p_leak_tx.py"
(https://github.com/bitcoin/bitcoin/pull/33121#pullrequestreview-3260015211)
reACK https://github.com/bitcoin/bitcoin/commit/a52c148ece2296f22e2fe1b7e9584d49e23f03f2

💬 davidgumberg commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3325945534)
Trying to do a guix build on this branch I get the following error:

```console
CMake Error at qtbase/cmake/QtBuildInformation.cmake:522 (message):
Feature "xcb": Forcing to "ON" breaks its condition:

QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11

Condition values dump:

QT_FEATURE_thread = "ON"
TARGET XCB::XCB found
TEST_xcb_syslibs = "FALSE"
QT_FEATURE_xkbcommon_x11 not evaluated

Call Stack (most recen
...

📝 RandyMcMillan opened a pull request: "rpcconsole: display signet challenge"
(https://github.com/bitcoin-core/gui/pull/896)

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3325965016)
display an elided signet challenge

<img width="799" height="669" alt="Screenshot 2025-09-23 at 6 51 46 PM" src="https://github.com/user-attachments/assets/49c0d622-1e4c-4c8a-ba28-158e22c78476" />

💬 kallewoof commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3325982255)
Nice. Should vanity grind that hash when/if we ever switch default signet challenge.

💬 fanquake commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3326133452)
> gui: Avoid pathological QT text/markdown behavior...
> during text selection by only setting plaintext mime data.

@amishhaa looks like you've got a partial commit message from a prior commit in this repo, as part of your commit message?

💬 151henry151 commented on pull request "build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script":
(https://github.com/bitcoin/bitcoin/pull/33470#issuecomment-3326485536)
Guix build hashes for commit eb98b612f80f:

698ad81e49ed8fe64d3586fe7a87837c82fef4b0ec8477f1737587593eff424a dist-archive/bitcoin-eb98b612f80f.tar.gz
2e1cbd7e66128739582a7822c6ac06fc57b33061d0cbbcd86094dbc4624c02e5 x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu-debug.tar.gz
be406dc0f71c160a2a4173ff81b29f67e2b191a3331eaf4d6d905e7fd07e646b x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu.tar.gz

Build completed successfully on Linux x86_64.

🤔 yuvicc reviewed a pull request: "log: unify `UpdateTip` values"
(https://github.com/bitcoin/bitcoin/pull/32996#pullrequestreview-3260926110)
ACK b039305d3590aaf84bfdf3b3547b9311897f52c7

<details>
<summary>Logs</summary>

Before:

```bash
2025-09-24T04:47:28Z UpdateTip: new best=00000000000000c19c69a5f5ef54d4565102a4e28a59a05ebbf0cb5efba4bac6 height=236928 version=0x00000002 log2_work=70.073757 tx=18088438 date='2013-05-19T14:48:37Z' progress=0.014517 cache=2.4MiB(17642txo)
2025-09-24T04:47:28Z UpdateTip: new best=000000000000008c6591a7f59d653d83365426134522364a9bae323166efc3c8 height=236929 version=0x00000002 log2_work=70
...

👍 vasild approved a pull request: "ci: Update Clang in "tidy" job"
(https://github.com/bitcoin/bitcoin/pull/33445#pullrequestreview-3261242814)
ACK 5b20d172ca2a46a2b525201b4ff2444f9d415d8c

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3326764345)
> Nice. Should vanity grind that hash when/if we ever switch default signet challenge.

As far as I understand this change does not influence the default signet only custom ones.

See https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2672450161 for my total misunderstanding:)

💬 PiRK commented on pull request "test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage":
(https://github.com/bitcoin/bitcoin/pull/33381#issuecomment-3326828928)
Rebased, the phantom commit is gone now

💬 hebasto commented on issue "Make Close/OK buttons consistent across all windows":
(https://github.com/bitcoin-core/gui/issues/25#issuecomment-3326924376)
Closing.

It’s unlikely that further effort will be put into the current GUI design changes, given the ongoing development in https://github.com/bitcoin-core/gui-qml.

✅ hebasto closed an issue: "Make Close/OK buttons consistent across all windows"
(https://github.com/bitcoin-core/gui/issues/25)

💬 hebasto commented on issue "Maximum allowed requested length exceeded":
(https://github.com/bitcoin-core/gui/issues/47#issuecomment-3326941919)
> Qt has fixed this issue https://codereview.qt-project.org/c/qt/qtbase/+/408178

Closing.

✅ hebasto closed an issue: "Maximum allowed requested length exceeded"
(https://github.com/bitcoin-core/gui/issues/47)