💬 hebasto commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/33445#discussion_r2373459060)
> This seems more like a bug that should be reported upstream...

https://github.com/llvm/llvm-project/issues/160394

💬 hebasto commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/33445#discussion_r2373473699)
> ... it would seem good to have a comment saying it is a temporary workaround.

Thanks! Done.

💬 hebasto commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/33445#issuecomment-3325580515)
The [feedback](https://github.com/bitcoin/bitcoin/pull/33445#discussion_r2372684495) from @ryanofsky has been addressed.

💬 hebasto commented on pull request "guix: Added guix-shasums script for gathering and formatting build output checksums":
(https://github.com/bitcoin/bitcoin/pull/33465#issuecomment-3325607240)
> ~0. I'm not sure if 90 lines of bash, is better than documenting and using the one-liner? Note that the markdown also bloats the size of the comment dramatically ([#33465 (comment)](https://github.com/bitcoin/bitcoin/pull/33465#issuecomment-3325505399)), compared to what is currently used ([#33185 (comment)](https://github.com/bitcoin/bitcoin/pull/33185#issuecomment-31968446200) (and makes it harder to copy paste).

Same from me.

💬 darosior commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325610461)
> AFAIK there is already a PR for rc2 (see #33424, #32275) and I personally don't think it's worth holding up the release for this PR.

+1. I ACK'd the change because i believe it is technically correct to say we won't be removing the option anytime soon, but i don't think a small documentation change is worth holding up the release for.

👍 hebasto approved a pull request: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424#pullrequestreview-3259681241)
ACK 7ebdfa2173b90faad71057d37b6b71c462dd3ea1, I applied all backports locally without conflicts and obtained a zero diff with this PR branch.

💬 trevarj commented on pull request "guix: Added guix-shasums script for gathering and formatting build output checksums":
(https://github.com/bitcoin/bitcoin/pull/33465#issuecomment-3325704017)
Firstly, thanks for sharing that one-liner. I looked everywhere for it and ended up doing it manually 😊

Approach NACK from me as well, since I think the compact code block is more legible due to not having newlines in the markdown table cells. I don't mine the one-liner in its own script, but having it documented seems necessary.

💬 fanquake commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325790255)
> AFAIK there is already a PR for rc2 (see https://github.com/bitcoin/bitcoin/pull/33424, https://github.com/bitcoin/bitcoin/issues/32275)

Given it's been 2 weeks since rc1, and there's going to be an rc3 in either cas, I'm going to tag an rc2 shortly, and when it's decided what to do here, it could be incorported into rc3.

🚀 fanquake merged a pull request: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424)

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2373651147)
Changed the message.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2373652213)
It is supposed to sign when any descriptor has a private key for a participant. Added a test and fixed.

📝 151henry151 opened a pull request: "build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script"
(https://github.com/bitcoin/bitcoin/pull/33470)
Remove hardcoded CMAKE_SKIP_INSTALL_RPATH setting from CMakeLists.txt and add it as a CMake configuration option in the Guix build script. This makes the build system more portable by keeping build-environment-specific settings in the build scripts rather than hardcoded in the CMake configuration.

Changes:
- Remove set(CMAKE_SKIP_INSTALL_RPATH TRUE) from CMakeLists.txt
- Add -DCMAKE_SKIP_INSTALL_RPATH=TRUE to Guix build script cmake configuration

This addresses the feedback from hebasto in htt
...

⚠️ w0xlt opened an issue: "Inconsistent CJDNS address handling in Local addresses and AddLocal logs"
(https://github.com/bitcoin/bitcoin/issues/33471)
When running:

```bash
./build/bin/bitcoind -daemon -server=1 -onion=127.0.0.1:9050 -externalip=<hostname_addr> -listen -cjdnsreachable
```

only two Tor addresses appear under _Local addresses_ and no CJDNS addresses. The log also shows two `AddLocal(...)` entries for the onion address, but none for the CJDNS address. However, adding a CJDNS peer via `addnode ... add` works as expected.

In contrast, running:

```
./build/bin/bitcoind -daemon -listen -cjdnsreachable
```

shows one Tor address a
...

💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3325921683)
@fanquake yes!, done.

👍 davidgumberg approved a pull request: "test: fix p2p_leak_tx.py"
(https://github.com/bitcoin/bitcoin/pull/33121#pullrequestreview-3260015211)
reACK https://github.com/bitcoin/bitcoin/commit/a52c148ece2296f22e2fe1b7e9584d49e23f03f2

💬 davidgumberg commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3325945534)
Trying to do a guix build on this branch I get the following error:

```console
CMake Error at qtbase/cmake/QtBuildInformation.cmake:522 (message):
Feature "xcb": Forcing to "ON" breaks its condition:

QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11

Condition values dump:

QT_FEATURE_thread = "ON"
TARGET XCB::XCB found
TEST_xcb_syslibs = "FALSE"
QT_FEATURE_xkbcommon_x11 not evaluated

Call Stack (most recen
...

📝 RandyMcMillan opened a pull request: "rpcconsole: display signet challenge"
(https://github.com/bitcoin-core/gui/pull/896)

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3325965016)
display an elided signet challenge

<img width="799" height="669" alt="Screenshot 2025-09-23 at 6 51 46 PM" src="https://github.com/user-attachments/assets/49c0d622-1e4c-4c8a-ba28-158e22c78476" />

💬 kallewoof commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-3325982255)
Nice. Should vanity grind that hash when/if we ever switch default signet challenge.

💬 fanquake commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3326133452)
> gui: Avoid pathological QT text/markdown behavior...
> during text selection by only setting plaintext mime data.

@amishhaa looks like you've got a partial commit message from a prior commit in this repo, as part of your commit message?