📝 janb84 opened a pull request: "guix: Added guix-shasums script for gathering and formatting build output checksums"
(https://github.com/bitcoin/bitcoin/pull/33465)
When a PR requires proof of Guix builds (sha256sums), the PR author or reviewer uses a not well documented command to collect the sha256sums of build outputs or manually gathers them from files:
```sh
guix describe
uname -m
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
```
This PR introduces a guix-shasums script that gathers all the sha256sums from the output directories and either outputs them on the screen or fo
...
(https://github.com/bitcoin/bitcoin/pull/33465)
When a PR requires proof of Guix builds (sha256sums), the PR author or reviewer uses a not well documented command to collect the sha256sums of build outputs or manually gathers them from files:
```sh
guix describe
uname -m
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
```
This PR introduces a guix-shasums script that gathers all the sha256sums from the output directories and either outputs them on the screen or fo
...
💬 hebasto commented on pull request "ci: Update Clang in "tidy" job":
(https://github.com/bitcoin/bitcoin/pull/33445#issuecomment-3324991629)
> re: [#33445 (comment)](https://github.com/bitcoin/bitcoin/pull/33445#issuecomment-3315082319)
>
> > Could you please take a look at the following IPC-related warning:
>
> Thanks, created [capnproto/capnproto#2417](https://github.com/capnproto/capnproto/pull/2417) to address it
I've added a commit to temporarily silence this warning.
(https://github.com/bitcoin/bitcoin/pull/33445#issuecomment-3324991629)
> re: [#33445 (comment)](https://github.com/bitcoin/bitcoin/pull/33445#issuecomment-3315082319)
>
> > Could you please take a look at the following IPC-related warning:
>
> Thanks, created [capnproto/capnproto#2417](https://github.com/capnproto/capnproto/pull/2417) to address it
I've added a commit to temporarily silence this warning.
💬 Sjors commented on pull request "ci: remove Clang build from msan fuzz job":
(https://github.com/bitcoin/bitcoin/pull/33425#discussion_r2373077161)
That build took over an hour on https://github.com/Sjors/sv2-tp and cherry-picking this commit made it fast again, so that's nice.
(https://github.com/bitcoin/bitcoin/pull/33425#discussion_r2373077161)
That build took over an hour on https://github.com/Sjors/sv2-tp and cherry-picking this commit made it fast again, so that's nice.
💬 ryanofsky commented on issue "`bitcoin-node` is unkillable after mining IPC connection is established":
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325023136)
> I'm not sure if `waitTipChanged` and `waitNext` can handle being interrupted before their timeouts yet, from either side
They are supposed to be handle it because they wait on `kernel_notifications.m_tip_block_cv` and `chainman.m_interrupt` which should both get signaled on shutdown.
Client should also not need to do anything on shutdown and should just be disconnected.
From the log it seems like ctrl-c is being processed, and shutdown is proceeding all the way up to the "Shutdown down" mes
...
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325023136)
> I'm not sure if `waitTipChanged` and `waitNext` can handle being interrupted before their timeouts yet, from either side
They are supposed to be handle it because they wait on `kernel_notifications.m_tip_block_cv` and `chainman.m_interrupt` which should both get signaled on shutdown.
Client should also not need to do anything on shutdown and should just be disconnected.
From the log it seems like ctrl-c is being processed, and shutdown is proceeding all the way up to the "Shutdown down" mes
...
💬 fanquake commented on pull request "ci: add libcpp hardening flags to macOS fuzz job":
(https://github.com/bitcoin/bitcoin/pull/33462#issuecomment-3325033349)
Looks like this does pass with the correct Clang (https://github.com/bitcoin/bitcoin/actions/runs/17950891735/job/51049620756#step:3:16):
```bash
Apple clang version 17.0.0 (clang-1700.0.13.5)
Target: arm64-apple-darwin24.6.0
Thread model: posix
InstalledDir: /Applications/Xcode_16.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
with some slowdown. i.e on master:
```bash
tx_pool_standard: succeeded against 919 files in 22s.
utxo_total_supply: succeeded against
...
(https://github.com/bitcoin/bitcoin/pull/33462#issuecomment-3325033349)
Looks like this does pass with the correct Clang (https://github.com/bitcoin/bitcoin/actions/runs/17950891735/job/51049620756#step:3:16):
```bash
Apple clang version 17.0.0 (clang-1700.0.13.5)
Target: arm64-apple-darwin24.6.0
Thread model: posix
InstalledDir: /Applications/Xcode_16.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
with some slowdown. i.e on master:
```bash
tx_pool_standard: succeeded against 919 files in 22s.
utxo_total_supply: succeeded against
...
💬 maflcko commented on pull request "test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage":
(https://github.com/bitcoin/bitcoin/pull/33381#discussion_r2373097896)
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes
(https://github.com/bitcoin/bitcoin/pull/33381#discussion_r2373097896)
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes
💬 plebhash commented on issue "`bitcoin-node` is unkillable after mining IPC connection is established":
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325050561)
I also tried with `mining` and `template` examples from https://github.com/rustaceanrob/bitcoin-ipc/tree/mining (there's also a `chain` example but it doesn't compile)
both `mining` and `template` do some brief interaction with `bitcoin-node` and then exit... in other words, they don't sustain a connection indefinitely, like my WIP code does
and killing `bitcoin-node` after these examples are finished works fine, no hanging
so this seems to be related to the fact that there's an active IPC c
...
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325050561)
I also tried with `mining` and `template` examples from https://github.com/rustaceanrob/bitcoin-ipc/tree/mining (there's also a `chain` example but it doesn't compile)
both `mining` and `template` do some brief interaction with `bitcoin-node` and then exit... in other words, they don't sustain a connection indefinitely, like my WIP code does
and killing `bitcoin-node` after these examples are finished works fine, no hanging
so this seems to be related to the fact that there's an active IPC c
...
💬 ryanofsky commented on issue "`bitcoin-node` is unkillable after mining IPC connection is established":
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325090308)
Makes sense an active connection or even an active call might be required to trigger this, but it's definitely not expected behavior, and there is probably a deadlock of some kind here. Its possible the patch from #33387 could fix this, and `thread apply all bt` output from GDB would also more clearly identify the problem
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3325090308)
Makes sense an active connection or even an active call might be required to trigger this, but it's definitely not expected behavior, and there is probably a deadlock of some kind here. Its possible the patch from #33387 could fix this, and `thread apply all bt` output from GDB would also more clearly identify the problem
💬 l0rinc commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325096918)
I keep flipping between acking or nacking this change. I actually considered proposing something similar a few weeks ago but ultimately decided against it, so I understand the motivations here.
While we all want Bitcoin to succeed as the best form of money ever created, and we all understand that transactions need to generate sufficient fees to keep miners alive, I don't see how deliberately misconfiguring our nodes to reject transactions that will likely be mined anyway helps achieve these g
...
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325096918)
I keep flipping between acking or nacking this change. I actually considered proposing something similar a few weeks ago but ultimately decided against it, so I understand the motivations here.
While we all want Bitcoin to succeed as the best form of money ever created, and we all understand that transactions need to generate sufficient fees to keep miners alive, I don't see how deliberately misconfiguring our nodes to reject transactions that will likely be mined anyway helps achieve these g
...
🤔 glozow reviewed a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3259161134)
ACK 1b1f359fc43385cb4d465b15754dac84eef06873
Could probably have someone double check the min feerate backport. The CI failure is related to #31210 / #30125. IIUC we skipped backporting #30125 as it's quite involved (also see https://github.com/bitcoin/bitcoin/pull/31422#pullrequestreview-2607160362)
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3259161134)
ACK 1b1f359fc43385cb4d465b15754dac84eef06873
Could probably have someone double check the min feerate backport. The CI failure is related to #31210 / #30125. IIUC we skipped backporting #30125 as it's quite involved (also see https://github.com/bitcoin/bitcoin/pull/31422#pullrequestreview-2607160362)
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3325105755)
Guix Build (x86_64):
```bash
cf7f86d91288477c11afdc767969d6b19b0ba1e62c73924e72b22a2527374653 guix-build-eca50854e1cb/output/aarch64-linux-gnu/SHA256SUMS.part
5afe50eb76079f96a5129b5e51e2ede657f10c5031abe24a875410f006c55511 guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu-debug.tar.gz
ba6f7937c5d333e64560abcd95dbb3856ceaa43fbcde766ebcaed1f8e23f2a7e guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu.tar.gz
bbdf057
...
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3325105755)
Guix Build (x86_64):
```bash
cf7f86d91288477c11afdc767969d6b19b0ba1e62c73924e72b22a2527374653 guix-build-eca50854e1cb/output/aarch64-linux-gnu/SHA256SUMS.part
5afe50eb76079f96a5129b5e51e2ede657f10c5031abe24a875410f006c55511 guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu-debug.tar.gz
ba6f7937c5d333e64560abcd95dbb3856ceaa43fbcde766ebcaed1f8e23f2a7e guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu.tar.gz
bbdf057
...
📝 asutosh23 opened a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33466)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33466)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
✅ asutosh23 closed a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33466)
(https://github.com/bitcoin/bitcoin/pull/33466)
📝 asutosh23 opened a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33467)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33467)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
✅ asutosh23 closed a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33467)
(https://github.com/bitcoin/bitcoin/pull/33467)
⚠️ jb55 opened an issue: "sqlite legacy descriptor wallet migration fails"
(https://github.com/bitcoin/bitcoin/issues/33468)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
the latest version of bitcoin does not load my legacy wallet, and migration doesn't work
when I try to migrate:
```
./build/bin/bitcoin-cli migratewallet personal
```
I get:
```
error code: -4
error message:
Error: This wallet is already a descriptor wallet
```
so effectively I can't use my wallet in the latest version of bitcoin.
cc @achow101
### Expected behaviour
I expect migra
...
(https://github.com/bitcoin/bitcoin/issues/33468)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
the latest version of bitcoin does not load my legacy wallet, and migration doesn't work
when I try to migrate:
```
./build/bin/bitcoin-cli migratewallet personal
```
I get:
```
error code: -4
error message:
Error: This wallet is already a descriptor wallet
```
so effectively I can't use my wallet in the latest version of bitcoin.
cc @achow101
### Expected behaviour
I expect migra
...
💬 glozow commented on pull request "p2p: protect addnode peers during IBD":
(https://github.com/bitcoin/bitcoin/pull/32051#issuecomment-3325159459)
> Yes, I plan to update this as mentioned at the last meeting: https://www.erisian.com.au/bitcoin-core-dev/log-2025-08-07.html#l-302
@jonatack I'm going to mark this as draft since it's been a while. Please mark as ready for review whenever you get the chance to address the comments.
(https://github.com/bitcoin/bitcoin/pull/32051#issuecomment-3325159459)
> Yes, I plan to update this as mentioned at the last meeting: https://www.erisian.com.au/bitcoin-core-dev/log-2025-08-07.html#l-302
@jonatack I'm going to mark this as draft since it's been a while. Please mark as ready for review whenever you get the chance to address the comments.
📝 glozow converted_to_draft a pull request: "p2p: protect addnode peers during IBD"
(https://github.com/bitcoin/bitcoin/pull/32051)
When an addnode peer is disconnected by our IBD headers/blocks download timeout or stalling logic, `ThreadOpenAddedConnections` attempts to immediately reconnect it (unless "onetry" was passed to the addnode RPC) up to the limit of 8 addnode connections that is separate from regular peer connection limits.
During IBD in a low-bandwidth environment, I see these disconnections+reconnections very frequently with high-quality addnode peers; see https://www.erisian.com.au/bitcoin-core-dev/log-2025
...
(https://github.com/bitcoin/bitcoin/pull/32051)
When an addnode peer is disconnected by our IBD headers/blocks download timeout or stalling logic, `ThreadOpenAddedConnections` attempts to immediately reconnect it (unless "onetry" was passed to the addnode RPC) up to the limit of 8 addnode connections that is separate from regular peer connection limits.
During IBD in a low-bandwidth environment, I see these disconnections+reconnections very frequently with high-quality addnode peers; see https://www.erisian.com.au/bitcoin-core-dev/log-2025
...
💬 trevarj commented on pull request "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2":
(https://github.com/bitcoin/bitcoin/pull/33185#issuecomment-3325186341)
Here is a time-machine commit ([1aa6da547d](https://codeberg.org/guix/guix/commit/1aa6da547dac764f72476b155b26844e3d93b632)) from yesterday, with small changes applied: https://github.com/bitcoin/bitcoin/commit/569ef2cb52ddab7253991bd622a661191a2ada3c
Only got around to building for the x86_64-linux-gnu target.
```
c6c16e7c6a99609b333bdf1ebeb2d66fe775c9e64e1808bf4d8e94d7c7d40203 dist-archive/bitcoin-569ef2cb52dd.tar.gz
58125ee3e19841480e325573fd10be009aaa0efb28afdcbbfdeeba5e03743a5d x
...
(https://github.com/bitcoin/bitcoin/pull/33185#issuecomment-3325186341)
Here is a time-machine commit ([1aa6da547d](https://codeberg.org/guix/guix/commit/1aa6da547dac764f72476b155b26844e3d93b632)) from yesterday, with small changes applied: https://github.com/bitcoin/bitcoin/commit/569ef2cb52ddab7253991bd622a661191a2ada3c
Only got around to building for the x86_64-linux-gnu target.
```
c6c16e7c6a99609b333bdf1ebeb2d66fe775c9e64e1808bf4d8e94d7c7d40203 dist-archive/bitcoin-569ef2cb52dd.tar.gz
58125ee3e19841480e325573fd10be009aaa0efb28afdcbbfdeeba5e03743a5d x
...
🚀 glozow merged a pull request: "test: don't throw from the destructor of DebugLogHelper"
(https://github.com/bitcoin/bitcoin/pull/33388)
(https://github.com/bitcoin/bitcoin/pull/33388)