💬 jb55 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325250806)
commenting out that check didn't seem to harm anything and it migrated successfully.

```patch
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
index 6b5d08b0a3ad..150d79749324 100644
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -4230,9 +4230,9 @@ util::Result<MigrationResult> MigrateLegacyToDescriptor(std::shared_ptr<CWallet>
const std::string wallet_name = local_wallet->GetName();

// Before anything else, check if there is something to migrate.
- if (loca
...

🚀 glozow merged a pull request: "wallet: Set descriptor cache upgraded flag for migrated wallets"
(https://github.com/bitcoin/bitcoin/pull/33031)

💬 glozow commented on pull request "cli: Handle arguments that can be either JSON or string":
(https://github.com/bitcoin/bitcoin/pull/33230#issuecomment-3325276784)
Needs rebase for #33031, which was merged first per the author's request.

👋 fanquake's pull request is ready for review: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424)

👋 mzumsande's pull request is ready for review: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464)

🤔 glozow reviewed a pull request: "docs: Undeprecate datacarrier and datacarriersize configuration options"
(https://github.com/bitcoin/bitcoin/pull/33453#pullrequestreview-3259349531)
This is the 3rd PR since #32406's merge discussing what the config options' docs should say. Given how much collective effort this has required, I think we should be realistic about what this PR achieves.

I believe this PR tries to align the documentation with what users can expect. Usage of these options can cause the node to reject transactions that are likely to be mined, so the docs should discourage their use (to me, that means deprecated). However, it seems that removal in the near futu
...

💬 glozow commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#discussion_r2373272312)
I'd agree with this approach

👍 willcl-ark approved a pull request: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424#pullrequestreview-3259382528)
ACK 7ebdfa2173b90faad71057d37b6b71c462dd3ea1

Backports are clean.

None added to release notes, but I don't think any particularly need to be (#33333 could be the only potential candidate here IMO).

💬 achow101 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325340756)
Can you be more specific as to which configuration you had? Was it bdb-descriptor or sqlite-legacy?

Either way, both of those are not supported wallet configurations and are not possible to create without modifying the software.

🚀 fanquake merged a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/33408)

💬 achow101 commented on pull request "cli: Handle arguments that can be either JSON or string":
(https://github.com/bitcoin/bitcoin/pull/33230#issuecomment-3325352104)
Rebased

💬 jb55 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325363600)
bdb-descriptor. I don't think I ran modified software, I do remember importing descriptors exported via hwi a long time ago.

✅ jb55 closed an issue: "sqlite legacy descriptor wallet migration fails"
(https://github.com/bitcoin/bitcoin/issues/33468)

💬 jb55 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325372801)
anyway I fixed it, all good

💬 achow101 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325389924)
It was only possible to create bdb-descriptor with a build of master for the 5 months between #16528 and #19077. I'm surprised that `migratewallet` works on those wallets when removing that check.

My typical recommendation for such wallets is to use `bitcoin-wallet dump` and `bitcoin-wallet createfromdump` to export the records and the load them into a new sqlite database.

💬 fanquake commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3325406653)
Thanks. You'll need to remove the merge commit here. Can you change the commit message to something more like: `contrib: fix using macdeploy script without translations`.

💬 jb55 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325407230)
ok I will try that instead just in case

💬 00w1 commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325429769)
I just wanted to share the reason why this pull request is open and not closed by maintainers:

<img width="289" height="209" alt="image" src="https://github.com/user-attachments/assets/5415c037-23f2-4e68-b0dd-8f551049a5a6" />

💬 pinheadmz commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3325450088)
@00w1 personal attacks are off topic and result in a ban re: moderation policy. Technical and conceptual discussion is the only type of comment that is allowed.

📝 instagibbs opened a pull request: "TxGraph: change m_excluded_clusters"
(https://github.com/bitcoin/bitcoin/pull/33469)
Change BlockBuilderImpl's m_excluded_clusters to unordered set since ordering is not used.

Change the set to a set of sequence numbers for a modest stability increase under fuzz testing.

This shouldn't be merged until https://github.com/bitcoin/bitcoin/pull/33157 is merged.