💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3312186763)
@instagibbs, yes, this was already taken some time ago and squashed into the relevant commit: https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2795829514

💬 john-moffett commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2362907654)
Currently not reachable as the [RPC](https://github.com/bitcoin/bitcoin/blob/74fa028da1ea38c5348f988464074899684cebcf/src/rpc/mempool.cpp#L1054):

`CHECK_NONFATAL(m_tx_results.size() == txns.size() || m_tx_results.empty())`

and acceptance [code](https://github.com/bitcoin/bitcoin/blob/74fa028da1ea38c5348f988464074899684cebcf/src/validation.cpp#L1852):

`Assume(results_final.size() == package.size())`

both are all-or-nothing in terms of package result reporting. I put that there as a
...

💬 hebasto commented on pull request "system: silence unused variable warning and make GetTotalRAM() work on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2362917905)
```suggestion
#elif defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__illumos__)
```

🤔 hebasto reviewed a pull request: "system: silence unused variable warning and make GetTotalRAM() work on FreeBSD"
(https://github.com/bitcoin/bitcoin/pull/33435#pullrequestreview-3244906271)
Concept ACK.

💬 instagibbs commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2362921924)
may be redundant but could add a more local assertion to this fact; easier for future reviewers to see what is unexpected?

📝 fanquake opened a pull request: "ci: run s390x job"
(https://github.com/bitcoin/bitcoin/pull/33436)
How fast does this run? (`-md`).

🤔 furszy reviewed a pull request: "test: don't throw from the destructor of DebugLogHelper"
(https://github.com/bitcoin/bitcoin/pull/33388#pullrequestreview-3244943259)
utACK 2427939935f3e6669be6bf553be89639e0afabaa

💬 furszy commented on pull request "test: don't throw from the destructor of DebugLogHelper":
(https://github.com/bitcoin/bitcoin/pull/33388#discussion_r2362946041)
nit:
"Fatal error: expected message '%s' not found in the logs\n"
otherwise it reads as you were printing the debug log.

💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312291709)
Guix Build:
```bash
2267864350c00270c5adac8da0a4a3ca998f7a1ccdd048e1ce7ad449e381fdba guix-build-2cf742c5214a/output/aarch64-linux-gnu/SHA256SUMS.part
6a132794251abc3c926adc0db07c66ceb512d87c5f9100cad3f0317ad8fbe1a1 guix-build-2cf742c5214a/output/aarch64-linux-gnu/bitcoin-2cf742c5214a-aarch64-linux-gnu-debug.tar.gz
9b89a316337713173bbf57ab4cd16201c2209c928e57c2ad83ea89b8c3f6c6db guix-build-2cf742c5214a/output/aarch64-linux-gnu/bitcoin-2cf742c5214a-aarch64-linux-gnu.tar.gz
ba3346a1e931f90f
...

⚠️ fanquake opened an issue: "ci: add an Alpine (musl libc) job"
(https://github.com/bitcoin/bitcoin/issues/33437)
This exists in some nightly repos alreaady, however we could have some libc diversity in the main CI, especially given static (musl based) binary discussion.

⚠️ fanquake opened an issue: "ci: add (atleast one) *BSD job to the CI"
(https://github.com/bitcoin/bitcoin/issues/33438)
See https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2362493046 & #33435. BSDs are being tested in nightly repos, but merging code here, just to have it reported as broken after the fact, which then requires more changes to fix, isn't ideal. Issues should be caught in this repo, before merging.

🤔 hebasto reviewed a pull request: "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245114592)
I suggest the following patch:
```diff
--- a/share/setup.nsi.in
+++ b/share/setup.nsi.in
@@ -118,10 +118,12 @@ Section -post SEC0001
DeleteRegKey HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name) (64-bit)"
Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\Uninstall $(^Name) (64-bit).lnk"
Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\$(^Name) (64-bit).lnk"
+ Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\Bitcoin Core (testnet, 64-bit).lnk"
DeleteRegValu
...

💬 marcofleon commented on pull request "fuzz: reduce iterations in slow targets":
(https://github.com/bitcoin/bitcoin/pull/33429#issuecomment-3312448551)
I ran the MSan fuzz CI script on my machine with these changes and for single run through the qa-assets inputs:

- `mini_miner` 105 sec
- `txdownloadman` 115 sec
- `txdownloadman_impl` 165 sec
- `tx_pool_standard` 727 sec

Some previous times can be seen in https://github.com/bitcoin/bitcoin/pull/33425.

👋 marcofleon's pull request is ready for review: "fuzz: reduce iterations in slow targets"
(https://github.com/bitcoin/bitcoin/pull/33429)

💬 hebasto commented on pull request "msvc: Update vcpkg manifest":
(https://github.com/bitcoin/bitcoin/pull/33408#issuecomment-3312449574)
Friendly ping @sipsorcery @hodlinator @davidgumberg :)

💬 john-moffett commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#issuecomment-3312483030)
Updated with suggestions. Thanks @instagibbs & @glozow.

💬 hebasto commented on pull request "system: silence unused variable warning and make GetTotalRAM() work on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2363141671)
Here are the relevant docs:
- [OpenBSD manpage](https://man.openbsd.org/sysconf.3)
- [NetBSD manpage](https://man.netbsd.org/sysconf.3)
- [illumos manpage](https://illumos.org/man/3C/sysconf)

💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843)
> @benthecarman any chance you can test a Guix built binary?

I needed to install libxcb-cursor0 to get the guix built binary to work, that's when it fixed the window issue but removed dark mode

👍 dergoegge approved a pull request: "fuzz: reduce iterations in slow targets"
(https://github.com/bitcoin/bitcoin/pull/33429#pullrequestreview-3245267683)
utACK 6a33970fef1b7b4d634f28277607b882958c95ac

💬 hebasto commented on pull request "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/33422#issuecomment-3312513869)
What about `RMDir /r /REBOOTOK $INSTDIR\doc` part I mentioned in https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245114592?