💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312514980)
Just to be clear, I meant could you test a Guix build of this branch, as the `bitcoin-qt` produced no-longer has a `libxcb-cursor0` dependency.

💬 hodlinator commented on pull request "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/33422#issuecomment-3312515677)
> Another alternative is to ask the user to uninstall any previous installation before installing a new one, but this is suboptimal.

Yup. I wish NSIS would keep exact track of previously installed files in the registry with checksums and allowed one to diff against the new files.

> I suggest the following patch:
> ...
> It additionally clears lingering artifacts from older versions and enables a clean uninstall on systems with a long upgrade history.
>
> See:
>
> * #25809
>

...

👍 hebasto approved a pull request: "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245308207)
ACK 79752b9c0b6bd9b2203ac98d28dd67734050c14a.

💬 willcl-ark commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3312527009)
I think this needs qemu:

```patch
commit 766b0b32361ae2eca3ee0b85caf1e27701fc0275
Author: will <will@256k1.dev>
Date: Fri Sep 19 15:47:01 2025 +0100

use qemu

diff --git a/.github/actions/configure-docker/action.yml b/.github/actions/configure-docker/action.yml
index c78df86b6cf..db5001c140d 100644
--- a/.github/actions/configure-docker/action.yml
+++ b/.github/actions/configure-docker/action.yml
@@ -4,9 +4,16 @@ inputs:
use-cirrus:
description: 'Use cirrus cache'
...

💬 willcl-ark commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3312546529)
Or we just enable qemu on all jobs (no downsides that I know of) with:

```patch
commit 6e7fba0b93d1dec0deafe7b7f87054c9a629134f
Author: will <will@256k1.dev>
Date: Fri Sep 19 15:47:01 2025 +0100

use qemu

diff --git a/.github/actions/configure-docker/action.yml b/.github/actions/configure-docker/action.yml
index c78df86b6cf..b5f3601a24b 100644
--- a/.github/actions/configure-docker/action.yml
+++ b/.github/actions/configure-docker/action.yml
@@ -7,6 +7,9 @@ inputs:
runs:

...

💬 instagibbs commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363328883)
Do we want the RPC to return an error, or stumble through and try to return something?

Middle ground is adding an `Assume()` that gets compiled out in release builds

@glozow

💬 ajtowns commented on pull request "net: Provide block templates to peers on request":
(https://github.com/bitcoin/bitcoin/pull/33191#issuecomment-3312726054)
Patchset to also request templates from outbound peers is at https://github.com/ajtowns/bitcoin/commits/202508-sendtemplate3/

💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332)
Sorry, that was for v30rc1

built guix binary for this PR. This fixes so I don't need `libxcb-cursor0` installed to run the binary and is the same where no dark mode but also no windowing bug

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#discussion_r2363468002)
> Haven't tested this, or looked for potential side effects (i.e #33432 claims that installing the dep breaks dark mode). Also related to #32097.

I’m still not sure I understand this fix. Perhaps @benthecarman could provide [more details](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3311581711) about the reported bug?

💬 glozow commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363493462)
I think CHECK_NONFATAL is fine. `Assume` might make it seem like this API quirk is more important than it actually is, and then we'd have to explain why it's ok to delete it later.

💬 benthecarman commented on issue "v30rc1 Weird GUI windowing behavior":
(https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312812001)
compiled from source without `libxcb-cursor0`

```
2025-09-19T16:11:53Z Ignoring unknown configuration value mempoolfullrbf
2025-09-19T16:11:53Z Ignoring unknown configuration value signet.signetblocktime
2025-09-19T16:11:53Z Bitcoin Core version v30.0rc1 (release build)
2025-09-19T16:11:53Z Qt 6.4.2 (dynamic), plugin=wayland
2025-09-19T16:11:53Z No static plugins.
2025-09-19T16:11:53Z Style: fusion / QFusionStyle
2025-09-19T16:11:53Z System: Ubuntu 24.04.3 LTS, x86_64-little_endian-lp64
2025-09
...

👋 fanquake's pull request is ready for review: "depends: static libxcb-cursor"
(https://github.com/bitcoin/bitcoin/pull/33434)

💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#discussion_r2363496059)
https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312812001

🤔 glozow reviewed a pull request: "p2p: Increase tx relay rate"
(https://github.com/bitcoin/bitcoin/pull/28592#pullrequestreview-3245717908)
utACK b81f37031c8f2ccad9346f1b65ee0f8083c44796

💬 glozow commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363502186)
is optional now false?

💬 hebasto commented on issue "v30rc1 Weird GUI windowing behavior":
(https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3312837619)
Thanks, @benthecarman!

From the provided logs, it appears that the reported bug occurs when building with the system’s Qt 6.4.2, rather than with the statically linked release binary.

The requirement to install `libxcb-cursor0` is already a known issue and is being tracked elsewhere.

💬 PiRK commented on pull request "test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage":
(https://github.com/bitcoin/bitcoin/pull/33381#issuecomment-3312853835)
let's see if this works. I moved the problematic test line to its own test suite, where it does not affect other flush tests.

The failure I'm trying to solve seems intermittent. It happens about 75% of the time on master if I just add the scriptPubKey to MakeCoin.
After my commit I get no failure in 10 runs of `./build/bin/test_bitcoin --run_test=coins_tests`

💬 PiRK commented on pull request "test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage":
(https://github.com/bitcoin/bitcoin/pull/33381#issuecomment-3312873728)
To clarify the rationale for this PR: the `SanityCheck` test added to `flush_all` in https://github.com/bitcoin/bitcoin/pull/28280/commits/a14edada8a051e280af6fedd5130be40247e2d7a does not have full coverage if `cachedCoinsUsage` is not exercised.

This PR ensure that the `cachedCoinsUsage` part of `SanityCheck` now actually does something useful for the `TestFlushBehavior` suite.

💬 john-moffett commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363560078)
I'd think it stays optional, as successful (and partially successful) submissions won't have an error for every tx. See, eg, [this test](https://github.com/bitcoin/bitcoin/blob/edb871cba22a658714ce97e843ff84cfe1ba9ac4/test/functional/rpc_packages.py#L417), where only the child has an error.

💬 fanquake commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3312901010)
Thanks @willcl-ark. Pulled in (some version) of your change, and added a `NO_QT=1` for now.