💬 hodlinator commented on pull request "scripted-diff: Type-safe settings retrieval":
(https://github.com/bitcoin/bitcoin/pull/31260#discussion_r2168630944)
Leftover line of code?

💬 hodlinator commented on pull request "scripted-diff: Type-safe settings retrieval":
(https://github.com/bitcoin/bitcoin/pull/31260#discussion_r2178387847)
nit: `self` is an unfortunate variable name in Python and is only written to, so can be removed.

💬 purpleKarrot commented on pull request "cmake: Fix `FindQt` module":
(https://github.com/bitcoin/bitcoin/pull/32709#issuecomment-3027803729)
ACK 89d3daf823e4350667b42473c0924430ea7400bc

💬 purpleKarrot commented on pull request "cmake: Fix `FindQt` module":
(https://github.com/bitcoin/bitcoin/pull/32709#discussion_r2180015085)
I don't think upstream considers this as an issue. Whether those variables should be considered advanced or not is a matter of taste.

💬 fanquake commented on pull request "cmake: Fix `FindQt` module":
(https://github.com/bitcoin/bitcoin/pull/32709#discussion_r2180022340)
If anything, that would seem inconsistent, because they have marked every other dependency as advanced, as there's no explanation for why `XKB` hasn't been marked as such (my guess is just oversight).

💬 fanquake commented on pull request "cmake, qt: Process `*.qrc` files manually":
(https://github.com/bitcoin/bitcoin/pull/32648#issuecomment-3027824977)
NACK - this should be fixed in Qts tooling.

👋 fanquake's pull request is ready for review: "build: add `-Wleading-whitespace`"
(https://github.com/bitcoin/bitcoin/pull/32482)

💬 fanquake commented on pull request "build: add `-Wleading-whitespace`":
(https://github.com/bitcoin/bitcoin/pull/32482#issuecomment-3027826781)
Dropped `-Wtrailing-whitespace` for now. That could be added when Qts tools are fixed.

💬 fanquake commented on pull request "test: Introduce `SUPPRESS_ABORT_MESSAGE` environment variable":
(https://github.com/bitcoin/bitcoin/pull/32409#issuecomment-3027837451)
What is the status of this?

✅ fanquake closed a pull request: "RFC: build: support for pre-compiled headers."
(https://github.com/bitcoin/bitcoin/pull/31053)

💬 fanquake commented on pull request "RFC: build: support for pre-compiled headers.":
(https://github.com/bitcoin/bitcoin/pull/31053#issuecomment-3027853404)
Closing for now. Could re-open if you want to circle back to looking at this.

✅ fanquake closed a pull request: "bench: reduces unnecessary big vector definition"
(https://github.com/bitcoin/bitcoin/pull/32787)

💬 fanquake commented on pull request "bench: reduces unnecessary big vector definition":
(https://github.com/bitcoin/bitcoin/pull/32787#issuecomment-3027858492)
Going to close this for now. Someone could open a new PR, adding an explanatory comment to the code here.

✅ hebasto closed a pull request: "cmake, qt: Process `*.qrc` files manually"
(https://github.com/bitcoin/bitcoin/pull/32648)

💬 fanquake commented on pull request "rpc: distinguish between vsize and sigop-adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/27591#issuecomment-3027867903)
This was picked up in #32800.

💬 fanquake commented on pull request "descriptors: Allow `H` as a hardened indicator":
(https://github.com/bitcoin/bitcoin/pull/32788#issuecomment-3027872200)
Moved this to draft for now, given https://github.com/bitcoin/bips/pull/1888.

📝 fanquake converted_to_draft a pull request: "descriptors: Allow `H` as a hardened indicator"
(https://github.com/bitcoin/bitcoin/pull/32788)
BIP 380 states that `H` is a valid hardened indicator.

💬 maflcko commented on pull request "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0":
(https://github.com/bitcoin/bitcoin/pull/32289#issuecomment-3027873189)
apple will support intel machines for another three years, but this is just a warning, so should be fine to leave as-is?

💬 luke-jr commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180035747)
That's not what's in the current BIP, nor what is implemented here...

💬 instagibbs commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180069882)
when the script is executed*?