📝 fanquake converted_to_draft a pull request: "Musig2 tests"
(https://github.com/bitcoin/bitcoin/pull/32724)
Built on https://github.com/bitcoin/bitcoin/pull/31244

This PR adds explicit tests for Bitcoin Core's MuSig2 interface.

Any issues in musig2.{cpp,h} will likely also be caught by the descriptor tests, but having more detailed tests for the MuSig2 class itself improves test reporting/coverage.

It uses BIP 328 test vectors.

💬 GregTonoski commented on issue "bitcoind shouldn't fail to progress with synchronization: endless [leveldb] Generated table ... logs":
(https://github.com/bitcoin/bitcoin/issues/31882#issuecomment-3027906134)
> To answer your question, I...

Is there the answer?


> So far I don't see an obvious performance issue as the inital block downloads typically finishes within 70 minutes with **debug=0**, which matches your original expectation.

I disagree, because my expectation was not shorter IBD (better performance) on much faster hardware.

We can have a debug session together and I can help reproducing the issue, profiling or debugging on your environment.

💬 fanquake commented on pull request "ci: update pwsh to use custom shell that fails-fast":
(https://github.com/bitcoin/bitcoin/pull/32672#issuecomment-3027913283)
cc @hebasto @hodlinator @davidgumberg for Concept ACK / NACK.

✅ hebasto closed a pull request: "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0"
(https://github.com/bitcoin/bitcoin/pull/32289)

💬 hebasto commented on pull request "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0":
(https://github.com/bitcoin/bitcoin/pull/32289#issuecomment-3027918074)
The issue has been [fixed](https://cmake.org/cmake/help/latest/release/4.0.html#id2) in CMake 4.0.2.

Closing.

✅ hebasto closed a pull request: "refactor: Drop unused `#include <boost/operators.hpp>`"
(https://github.com/bitcoin/bitcoin/pull/32668)

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3027932624)
@SomberNight @luke-jr

I'm redoing this comment showing the proposed code changes, which are based on @SomberNight's comments. I'm not sure IF these are all the fixes needed, just making the changes based on the comments so far. Let me know if anyone wants this branch pushed for the PR.

## Changes:

### 1. Fixed witness commitment verification in `src/rpc/txoutproof.cpp`

```cpp
// In verifytxoutproof RPC, around line 220
const auto wtxids = [&]() -> std::unordered_map<unsigned int, uint256> {
...

📝 fanquake converted_to_draft a pull request: "fee estimate test: fix #31944 by handling a legitimate scenario that …"
(https://github.com/bitcoin/bitcoin/pull/32615)
Fix a legitimate scenario that feerate is not always available, due to the randomly generated fees that causes current percentage to be smaller than success break point, in TxConfirmStats::EstimateMedianVal (in src/policy/fees.cpp). The solution is to hard code a list of fees that guarantee to pass the check of fees and smart fees.

To reproduce/validate the issue, run the test with a specific randomseed: 2986529890161488286

build/test/functional/test_runner.py test/functional/feature_fee_
...

💬 fanquake commented on pull request "fee estimate test: fix #31944 by handling a legitimate scenario that …":
(https://github.com/bitcoin/bitcoin/pull/32615#issuecomment-3027935606)
@tnndbtc I've moved this to draft, as we aren't going to merge this with the current approach, using the generated `global_fee_list`.

💬 darosior commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180101377)
Yeah it's just a typo when/where:
```suggestion
// Unlike the existing block wide sigop limit, BIP54 counts sigops where they are actually executed.
```

💬 darosior commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180103816)
Done, thanks for spotting the typo.

💬 hodlinator commented on pull request "ci: update pwsh to use custom shell that fails-fast":
(https://github.com/bitcoin/bitcoin/pull/32672#issuecomment-3027942199)
Concept ACK (but my PowerShell skill is 0).

@fanquake you are currently registered as a N-A-C-K.

💬 instagibbs commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180105702)
I think that's still ambiguous as it does read like a taproot sigops budget sense where the opcode itself must be executed to count

💬 luke-jr commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180106942)
This is still wrong. If you bury a sigop in (false) OP_IF, they are still counted even though not actually executed

💬 fanquake commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#issuecomment-3027954533)
Added this to `30.0`.

👍 brunoerg approved a pull request: "fuzz: Make process_message(s) more deterministic"
(https://github.com/bitcoin/bitcoin/pull/32822#pullrequestreview-2979255643)
light code review ACK fac673d434b4d32d8c44dcc50a3655ba4a1816de

✅ fanquake closed a pull request: "doc: Add hint about avoiding spaces in paths when building on Windows"
(https://github.com/bitcoin/bitcoin/pull/32397)

💬 fanquake commented on pull request "doc: Add hint about avoiding spaces in paths when building on Windows":
(https://github.com/bitcoin/bitcoin/pull/32397#issuecomment-3027979421)
Closing for now. @hebasto maybe you can followup with your own suggestion.

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3027980445)
Changes are in my branch: https://github.com/bigshiny90/bitcoin/tree/fix-pr-32844-witness

💬 fanquake commented on pull request "allocators: Apply manual ASan poisoning to `PoolResource`":
(https://github.com/bitcoin/bitcoin/pull/32581#issuecomment-3027988340)
Added this to 30.0.
cc @marcofleon