💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3332019270)
@fanquake, sorry of the delay! fixed.

🤔 weezyb0893 reviewed a pull request: "util: Revert "common: Close non-std fds before exec in RunCommandJSON""
(https://github.com/bitcoin/bitcoin/pull/33063#pullrequestreview-3265576651)
Stop

💬 waketraindev commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3332170515)
This PR is more of an example of the brink foundation leveraging and rallying their members to get a nonsensical help text change pushed and backported for V30.

The change itself is senseless and should not be something accepted in any kind of engineering.

Don't know who this attempts to please but it's clearly group think and group push from Brink.

-1 and concept nack and sure minimize this

✅ maflcko closed an issue: "Cleanup CFeeRate constructor (sat/vB vs BTC/kvB)"
(https://github.com/bitcoin/bitcoin/issues/23129)

💬 maflcko commented on issue "Cleanup CFeeRate constructor (sat/vB vs BTC/kvB)":
(https://github.com/bitcoin/bitcoin/issues/23129#issuecomment-3332398249)
Closing for now. Seems fine to just organically change this, the next time the code is touched.

💬 purpleKarrot commented on pull request "CPack":
(https://github.com/bitcoin/bitcoin/pull/33455#discussion_r2377948657)
CMake does not provide options for all NSIS attributes. For attributes that are strictly required, we may need to upstream support (see [example](https://gitlab.kitware.com/cmake/cmake/-/issues/27260)).

However, we should also reconsider whether deviating from the defaults is truly necessary.

The default behavior for `CRCCheck` is to verify the CRC, but it also allows users to disable the check via a command-line option to the installer, which can be useful for testing purposes. Setting `force
...

⚠️ waketraindev opened an issue: "No way to clear command history in RPC console or reset the console without restarting the node"
(https://github.com/bitcoin-core/gui/issues/897)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [x] I still think this issue should be opened here

### Report

No way to clear the command history of a RPC console. With the history remaining until client reset.

Please add a way to either clear the command history or fully reset the console.

Thanks in advance

⚠️ waketraindev opened an issue: "Ability to retrieve peer by peer id"
(https://github.com/bitcoin/bitcoin/issues/33478)
### Please describe the feature you'd like to see added.

All the debug logs with data pertaining net peers contain a peer id, yet there's no way to retrieve that peer info without depending on other utilities like jq

Please add the ability to retrieve that peer information based on peer id.

Thanks in advance

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

...

💬 maflcko commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2378064596)
It disables the auto-detection for all functional tests by default, which I can't really find a downside to. Also, it removes idle "spam" threads while debugging (gdb and other tools will display less script check threads), which also seems beneficial to have?

💬 maflcko commented on pull request "Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found":
(https://github.com/bitcoin/bitcoin/pull/33433#discussion_r2378402591)
I don't understand this change. This line of code is only run when `not self.options.run_ipv4 and not self.options.run_ipv6`. The whole test is only run when `sum([self.options.run_ipv4, self.options.run_ipv6, self.options.run_nonloopback]) > 1`. So `self.options.run_nonloopback` must be set.

However, the previous check already guard this:

```py
if self.non_loopback_ip is None and self.options.run_nonloopback:
raise SkipTest("This test requires a non-loopback ip addre
...

💬 waketraindev commented on pull request "net: Provide block templates to peers on request":
(https://github.com/bitcoin/bitcoin/pull/33191#discussion_r2365773084)
NIT: Replace break; return; with just return for clarity and to simplify control flow.

```suggestion
return;
```

💬 hodlinator commented on pull request "node: Add --debug_runs/-waitfordebugger":
(https://github.com/bitcoin/bitcoin/pull/31723#issuecomment-3333179240)
Realized one could start a debugger session from the CLI:
`$ subl --command "debugger {\"action\": \"start\", \"configuration\": {\"name\": \"foo\", \"type\": \"lldb\", \"request\": \"launch\", \"program\": \"\${project_path}/build/bin/bitcoind\", \"args\": [\"-noconnect\"]}}"`
or
`$ kgx -- $(which lldb) -o run -- /home/hodlinator/bc/3/build/bin/bitcoind -noconnect`

So I've explored a variation of this which does not change the C++ side at all - https://github.com/hodlinator/bitcoin/tree/r
...

👋 hodlinator's pull request is ready for review: "node: Add --debug_runs/-waitfordebugger"
(https://github.com/bitcoin/bitcoin/pull/31723)

💬 hodlinator commented on pull request "node: Add --debug_runs/-waitfordebugger + --debug_cmd":
(https://github.com/bitcoin/bitcoin/pull/31723#discussion_r2378506262)
I've explored launching the debugger instead of attaching in a separate branch, see https://github.com/bitcoin/bitcoin/pull/31723#issuecomment-3333179240

💬 ismaelsadeeq commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#issuecomment-3333198233)
reACK 5ac32aa441bf3ec1f1fa826f689405bc4a7b7354

Changes since last ACK are nits fixes.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570634)
Added in the latest commit.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570767)
Seems good. Fixed.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570933)
Done.

💬 hebasto commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3333308568)
cc @Sjors

👍 vasild approved a pull request: "log: reduce excessive "rolling back/forward" messages during block replay"
(https://github.com/bitcoin/bitcoin/pull/33443#pullrequestreview-3266970216)
ACK 1fc7a81f1f5f30ba3ebe305ac2a520c7b4afb596

👍 luke-jr approved a pull request: "bugfix: miner: fix `addPackageTxs` unsigned integer overflow"
(https://github.com/bitcoin/bitcoin/pull/33475#pullrequestreview-3267000636)
utACK