💬 luke-jr commented on pull request "Rollback for dumptxoutset without invalidating blocks":
(https://github.com/bitcoin/bitcoin/pull/33477#issuecomment-3333347528)
Concept ACK, this seems cleaner.

> master took 3m 17s vs 9m 16s in my last test with the code here

I suspect if you go back further, this approach will end up performing better because we no longer need to roll back forward at the end

💬 luke-jr commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#discussion_r2378633638)
Might be a better way to elide the middle so that a copy/paste gets the full string?

⚠️ Jamesthomas32 opened an issue: "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE"
(https://github.com/bitcoin/bitcoin/issues/33479)
### Motivation

I never thought I will get scammed of all my assets on this exchange which I was warned by friends to keep off the exchange, they stole all my life saving the total funds of $850k worth of bitcoin. I couldn’t believe bitcoin can ever be recovered, all thanks to a kind hearted man called SMITH WHITE HACK SERVICE he just offered me top notch services and he is capable of offering hacking services of any sort. To that one person or persons out there who really need a true and effici
...

✅ willcl-ark closed an issue: "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE"
(https://github.com/bitcoin/bitcoin/issues/33479)

💬 willcl-ark commented on issue "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE":
(https://github.com/bitcoin/bitcoin/issues/33479#issuecomment-3333368905)
For general bitcoin discussion you can try [bitcointalk](https://bitcointalk.org) or [https://reddit.com/r/bitcoin](reddit.com/r/bitcoin).

💬 hebasto commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3333537565)
@amishhaa

Would you mind sharing the steps to reproduce the failure?

🚀 fanquake merged a pull request: "bugfix: miner: fix `addPackageTxs` unsigned integer overflow"
(https://github.com/bitcoin/bitcoin/pull/33475)

💬 fanquake commented on pull request "bugfix: miner: fix `addPackageTxs` unsigned integer overflow":
(https://github.com/bitcoin/bitcoin/pull/33475#issuecomment-3333677484)
Backported to 30.x in #33473.

💬 hebasto commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2378912338)
Is there any particular reason to capitalize "installed" here?

💬 hebasto commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2378918081)
This comment doesn't seem correct to me, since we check that installed binaries have no `RUNPATH` or `RPATH` set. Maybe drop this line?

📝 maflcko opened a pull request: "ci: Turn CentOS config into Alpine musl config"
(https://github.com/bitcoin/bitcoin/pull/33480)
Fixes https://github.com/bitcoin/bitcoin/issues/33437

Historically, the centos task was added to add CI coverage for centos-like distros. Also, to have coverage for 32-bit builds, but this is now covered by different tasks.

So basically, the centos task is similar to all the Ubuntu/Debian CI tasks, possibly with some packages named slightly differently. I am not aware of the task ever discovering a centos-related issue, so it seems fine to recycle it into an Alpine Linux task.

The main
...

💬 willcl-ark commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3333712941)
Concept ACK

👍 willcl-ark approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3267449488)
ACK a5e4fec4949f61ebbd7d6696f39da26df04515f9

This now only includes #33236, #33395 and #33340, with the other changes moving into #33476.

Backports look fine, 966666de was the only commit that appears to have needed resolution.

All backports are credited in the release notes.

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3267478272)
I've tested 9c13be9c45cad19d9db78e318b1e8376d56d6ec5, including running with [`V=1`](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/README.md#recognized-environment-variables). It looks good.

Please amend the comments in `contrib/guix/libexec/build.sh` as noted above.

🤔 rkrux reviewed a pull request: "key: use static context for libsecp256k1 calls where applicable"
(https://github.com/bitcoin/bitcoin/pull/33399#pullrequestreview-3267494219)
crACK 1ff9e929489e625a603e8755b8efe849feda1f16

I have limited exposure to this area. I agree with the intent of using the static context in more places where the non-static one is not really required.

I checked the implementation of the functions that have the static context passed now, and almost of them don't seem to use the passed context besides for the not-null checks. The `secp256k1_declassify` function internally called via `secp256k1_keypair_xonly_pub` does seem to use the context but
...

⚠️ asadr42 opened an issue: "Transaction"
(https://github.com/bitcoin/bitcoin/issues/33481)
Hello, dear supporter, on December 12, 2024, $1,609 was deducted from my Bitcoin wallet account, and I don't know why. When I go to my Bitcoin transaction history, it shows a page that I will send to you. Please guide me based on this explanation and the screenshot sent and tell me what I should do. Thank you for your response.

✅ pinheadmz closed an issue: "Transaction"
(https://github.com/bitcoin/bitcoin/issues/33481)

💬 maflcko commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#issuecomment-3333824240)
> they weren't legacy wallet specific but rather configuration problems.

You'll have to adjust the pull description. Also, CI fails.

To ensure this is tested once, you can add `--gen-test-data` to one CI task config via TEST_RUNNER_EXTRA.

💬 janb84 commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3333847560)
> I am running Arch Linux x86_64. Please let me know if there is anything I can do to help diagnose this issue.

I have changed the command to `ss -ax | grep node` that will fix this issue. Thank you for you patience.

💬 pinheadmz commented on issue "Transaction":
(https://github.com/bitcoin/bitcoin/issues/33481#issuecomment-3333923185)
The Bitcoin Core issue tracker is reserved for specific software issues like bug reports and feature requests. Individual help inquiries or general Bitcoin usage questions are more appropriate at https://bitcoin.stackexchange.com https://reddit.com/r/bitcoin or IRC channels such as `#bitcoin`