💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#issuecomment-1553447313)
> Happy to write it differently if it is not good enough. Maybe should change "child class init function" for "CustomInit"?. (in the commit description it's explained with more details anyway)

Yes if CustomInit was mentioned I probably would have understood better. I would say this PR fixes a race condition where an index's `CustomAppend` method might be called before its `CustomInit` method, causing the index to try to update itself before it is initialized. And that the PR fixes the proble
...

💬 hebasto commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#issuecomment-1553447916)
The `help generate` command returns:
```
generate

has been replaced by the -generate cli option. Refer to -help for more information.
```

💬 pinheadmz commented on pull request "Add wallet method to detect if a key is "active"":
(https://github.com/bitcoin/bitcoin/pull/27216#issuecomment-1553450191)
> Needs rebase

done thanks

💬 MarcoFalke commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1198150716)
It could also be `constexpr auto FEE_FLUSH_INTERVAL{1h};`

⚠️ Omermohemmed74 opened an issue: "DSE"
(https://github.com/bitcoin/bitcoin/issues/27701)

✅ pinheadmz closed an issue: "DSE"
(https://github.com/bitcoin/bitcoin/issues/27701)

💬 furszy commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#issuecomment-1553480215)
sounds good. Description updated, thanks.

✅ hebasto closed an issue: "Watch-only, balance not "available" for psbt"
(https://github.com/bitcoin-core/gui/issues/83)

💬 hebasto commented on issue "guiutil.cpp: formatNiceTimeOffset":
(https://github.com/bitcoin-core/gui/issues/728#issuecomment-1553504397)
Closing for now.

> Please post a screen shot - for clarity.

Can be reopened when more details (a screenshot) will be provided.

> that tool tip can be improved

It is still not clear what is wrong with the current implementation.

✅ hebasto closed an issue: "guiutil.cpp: formatNiceTimeOffset"
(https://github.com/bitcoin-core/gui/issues/728)

💬 hebasto commented on pull request "Make network graph slider easier to use":
(https://github.com/bitcoin-core/gui/pull/483#issuecomment-1553508354)
> There hasn't been much activity lately. What is the status here?

Closing due to lack of interest.

✅ hebasto closed a pull request: "Make network graph slider easier to use"
(https://github.com/bitcoin-core/gui/pull/483)

🤔 ryanofsky reviewed a pull request: "index: improve initialization and pruning violation check"
(https://github.com/bitcoin/bitcoin/pull/27607#pullrequestreview-1433254608)
Reviewed dd9bc393ebd4ba915ca94991390b6e98d29dcfaf, which looks good overall, but I had questions about few things

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198165818)
In commit "init: start indexes after the loadblk thread finishes" (ca3041984cf3665e27b6783c923ab1c32682500a)

Could we change "indexers" to "indexes" in all new code? I don't think distinguishing between an "index" and "indexer" really clarifies anything, and the word "indexers" seems a little odd and unexpected.

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198184049)
In commit "init: start indexes after the loadblk thread finishes" (ca3041984cf3665e27b6783c923ab1c32682500a)

One side-effect of this change is that now if there is a "best block of the index goes beyond pruned data" error, bitcoind successfully starts and returns 0 then exits, where previously it could fail early and actually return an error code.

That aspect of the previous behavior seems better to me, though I'm not sure what the tradeoffs are.

Do you think the the main benefit of th
...

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198191133)
In commit "index: simplify pruning violation check" (704c9e4cf67468708db655226a78489b92ef0523)

Would be good to make this declaration use the same argument name as the definition which is `BlockManager::GetFirstStoredBlock(const CBlockIndex& start_block)`

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198195900)
In commit "index: prevent race by calling 'CustomInit' prior setting 'm_synced' flag" (21812970cc56191e18f96692e47f00ed881bd596)

I think it would be nice to split this commit off into a separate PR is possible, so we have a minimal bugfix that could backported (and also be easier to understand)

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198193156)
In commit "index: simplify pruning violation check" (704c9e4cf67468708db655226a78489b92ef0523)

Could the commit message clarify if any behavior is changing here? Would be good to label it a refactoring and say it does not change behavior if nothing is changing, and say what is changing otherwise.

Also, it seems like new code that is added here just gets moved / deleted later in the PR in the last commit "index: verify blocks data existence only once" (dd9bc393ebd4ba915ca94991390b6e98d29dcf
...

💬 ryanofsky commented on pull request "index: improve initialization and pruning violation check":
(https://github.com/bitcoin/bitcoin/pull/27607#discussion_r1198198410)
In commit "refactor: index, decouple 'Init' from 'Start'" (26bd60eafc42484d80d5dfef0fa0abb77e7817ce)

Init return value is ignored. I think this needs to return false if it fails. Would also be good to mark Init declaration with `[[nodiscard]]`

💬 dooglus commented on issue "v25.0rc2 unusably slow at times":
(https://github.com/bitcoin/bitcoin/issues/27700#issuecomment-1553533679)
@MarcoFalke Thanks. I use this:

`./configure CXXFLAGS=-fno-omit-frame-pointer --with-incompatible-bdb --with-miniupnpc=no --enable-debug`

Closing the issue. And sorry for the dup.