💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1552919155)
Moved to https://github.com/bitcoin-core/gui/issues/730.

✅ hebasto closed an issue: "Can't start bitcoin-qt by double-click on Debian 11"
(https://github.com/bitcoin/bitcoin/issues/27655)

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1552920830)
I can't see a reason that it wouldn't be (absent a new report), and the crash here is coming from objective C code that isn't part of bitcoind.

💬 ajtowns commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552923162)
> > I think it would also be good to continue serving txs from `vExtraTxnForCompact`
>
> I wasn't sure how to do this, given the planned removal of `m_recently_announced_invs` in #27675 . Otherwise we may relay invalid/non-standard transactions that were injected into us by a spy node.

I guess a straightforward approach would be to have the mempool separately keep track of the last ~700 txs removed, as well as their entry time and removal time. Then they could be relayed to a node (under #
...

💬 MarcoFalke commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1552934253)
>I guess a straightforward approach would be to have the mempool separately keep track of the last ~700 txs removed, as well as their entry time and removal time. Then they could be relayed to a node (under https://github.com/bitcoin/bitcoin/pull/27675's proposed logic)

That would still leave the fingerprint vector if the spy node sent a transaction and its replacement immediately after. That is, before we'd have a chance to announce or send the original to anyone. Leaving us with a unique fi
...

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552966704)
Tested on version 25.0rc2. It works there.

💬 fanquake commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552967514)
> Tested on version 25.0rc2. It works there.

Ok. We can close this then.

Maybe fixed with https://github.com/bitcoin-core/gui/pull/469 ?

✅ fanquake closed an issue: "bitcoin-qt generates bad psbt"
(https://github.com/bitcoin/bitcoin/issues/27697)

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552978120)
A psbt file that's saved in 24.0.1 and that failed to open in 24.0.1, could successfully be opened in 25.0rc2. I guess this means that the saved psbt file is valid and that it's the parsing of the psbt file that is buggy.

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1552982794)
However, I'm not sure https://github.com/bitcoin-core/gui/pull/469 fixed it, because the saved psbt is binary. Attaching my psbt file (renamed to *.txt to circumvent upload restrictions)
[test3.psbt.txt](https://github.com/bitcoin/bitcoin/files/11507730/test3.psbt.txt)

👍 stickies-v approved a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640#pullrequestreview-1432623162)
Code review ACK faf4315c88d8c81c2ff84870bc81aef3cf719816

I'd have preferred doing things a bit differently but I think as per the PRs rationale, it's better to move away from the tuple return type quickly to avoid larger refactorings in the future. My comments can easily be implemented in follow-ups, if people want them.

---

> The idea is to use the same return type as the other MiniWallet methods.

Fair enough, I hadn't considered that.

> If you want compile-time type checks <...>
...

💬 kallerosenbaum commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553009843)
If I convert the test3.psbt.txt (binary) file to a base64 file, I can then read the base64 into bitcoin core.
```
$ cat test3.psbt.txt|base64 -w0 > test3.psbt
```

⚠️ fanquake opened an issue: "crash on macOS 12.6.5"
(https://github.com/bitcoin-core/gui/issues/731)
Moved from https://github.com/bitcoin/bitcoin/issues/27681.


### What version of Bitcoin Core are you using?

V22.0.0 and 24.0.1.

### Operating system and version

Mac osx 12.6.5

### Machine specifications

2.8 dual core i5 8 gb ram high speed internet
1tb drive

```bash
Translated Report (Full Report Below)
-------------------------------------

Process: Bitcoin-Qt [844]
Path: /Applications/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
Ident
...

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553024681)
Moved over to https://github.com/bitcoin-core/gui/issues/731.

✅ fanquake closed an issue: "Mac osx 12.6.5 "
(https://github.com/bitcoin/bitcoin/issues/27681)

💬 fanquake commented on issue "bitcoin-qt generates bad psbt":
(https://github.com/bitcoin/bitcoin/issues/27697#issuecomment-1553027002)
Ok. Could continue discussion with an issue in https://github.com/bitcoin-core/gui if still relevant?

cc @achow101

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553045708)
thank u all do I have to forward this or haves it been done

💬 fanquake commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1553046960)
> thank u all do I have to forward this or haves it been done

A new issue has been opened, https://github.com/bitcoin-core/gui/issues/731, thanks.

🚀 fanquake merged a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640)

👍 fanquake approved a pull request: "build: Bump minimum supported GCC to g++-9"
(https://github.com/bitcoin/bitcoin/pull/27662#pullrequestreview-1432713153)
ACK fa953f15bfcf95df9aa9c91e1c4b56a205f4d1ae