💬 hebasto commented on pull request "Use subprocess library for notifications":
(https://github.com/bitcoin/bitcoin/pull/32566#discussion_r2098055653)
3e2b4660b84af872d114afc1556649f3dd93a1af:

`#include <codecvt>` might be removed now.

💬 hebasto commented on pull request "Modernize use of UTF-8 in Windows code":
(https://github.com/bitcoin/bitcoin/pull/32380#issuecomment-2894562974)
Changes overlapping with https://github.com/bitcoin/bitcoin/pull/32566 have been dropped.

📝 hebasto converted_to_draft a pull request: "cmake, guix: Skip building tests in subtrees for releases"
(https://github.com/bitcoin/bitcoin/pull/32054)
The `BUILD_TESTS` variable has a broad scope, controlling:
- Building `test_bitcoin`
- Building `test_bitcoin-qt`
- Building tests in subtrees, such as `secp256k1` and `univalue`
- Creating CTest's tests

However, for release builds, only the first is necessary.

To address this, this PR introduces the new `BUILD_TEST_BINARY` variable, which allows building only the `test_bitcoin` binary without enabling other tests.

---

As an alternative, an explicit list of build targets can be s
...

📝 vicjuma opened a pull request: "refactor: remove dump.h/cpp, wallet_bdb_parser.cpp"
(https://github.com/bitcoin/bitcoin/pull/32569)
This PR removes the following deprecated legacy wallet files:

- `src/wallet/dump.cpp`
- `src/wallet/dump.h`
- `src/wallet/test/fuzz/wallet_bdb_parse.cpp`
- `Their associated references and usages`

These files were originally part of the legacy BerkeleyDB wallet backend and are no longer used in current functionality. They were retained for backward compatibility but are now fully obsolete due to ongoing deprecation tracked in #28710.

### Motivation

- These files are no longer comp
...

💬 maflcko commented on pull request "refactor: remove dump.h/cpp, wallet_bdb_parser.cpp":
(https://github.com/bitcoin/bitcoin/pull/32569#issuecomment-2894610004)
Please no AI slop

✅ maflcko closed a pull request: "refactor: remove dump.h/cpp, wallet_bdb_parser.cpp"
(https://github.com/bitcoin/bitcoin/pull/32569)

🤔 hebasto reviewed a pull request: "refactor: remove dump.h/cpp, wallet_bdb_parser.cpp"
(https://github.com/bitcoin/bitcoin/pull/32569#pullrequestreview-2854410943)
Please do not touch automatically generated `src/qt/bitcoinstrings.cpp`.

👍 hebasto approved a pull request: "qt: drop unused watch-only functionality"
(https://github.com/bitcoin/bitcoin/pull/32459#pullrequestreview-2854442158)
ACK e8661aac752eb08fee318eb8f56e599578d78f9f, I have reviewed the code and it looks OK. The `src/qt/forms/overviewpage.ui` form was reviewed in Qt Designer.

Tested on Ubuntu 25.04.

💬 pinheadmz commented on pull request "tests: Expand HTTP coverage to assert libevent behavior":
(https://github.com/bitcoin/bitcoin/pull/32408#discussion_r2098146539)
The problem with this is the test becomes flakey because the timer may not start in sync with the server, so it may record less time than the server actually waited: https://github.com/bitcoin/bitcoin/pull/32408#discussion_r2081584805

note also that libevent doesn't even try to test the lower bound: https://github.com/bitcoin/bitcoin/pull/32408#discussion_r2080431221

💬 instagibbs commented on pull request "test: fix pushdata scripts":
(https://github.com/bitcoin/bitcoin/pull/32270#issuecomment-2894683573)
@TheCharlatan rebased

💬 luke-jr commented on issue "rpc method removeprunedfunds should take an array of txids":
(https://github.com/bitcoin/bitcoin/issues/29466#issuecomment-2894701844)
Can't you just make a batch RPC request?

💬 polespinasa commented on pull request "rpc: generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2098176485)
> not sure about forcing an array, when all tests mostly just want to provide a single dummy value.

I don't think this should be a problem.
Same happens with `sendall`. Most tests just provide a single value in a list. And it actually doesn't affect many tests.

I think it keeps the code simpler and avoids the confusion that could appear if we use multiple possible arguments.

Also, even if this is not a backward compatible change it's not something critical as it is the test code.

B
...

💬 laanwj commented on pull request "Use subprocess library for notifications":
(https://github.com/bitcoin/bitcoin/pull/32566#discussion_r2098190718)
Done, thanks

🚀 fanquake merged a pull request: "Remove legacy `Parse(U)Int*`"
(https://github.com/bitcoin/bitcoin/pull/32520)

💬 fanquake commented on pull request "fs: remove `_POSIX_C_SOURCE` defining":
(https://github.com/bitcoin/bitcoin/pull/32460#issuecomment-2894739331)
```bash
181155a38912fab7e25d751d1f0281d7127ca8c309e2835bf0b109f30d425f91 guix-build-db895c0e3842/output/aarch64-linux-gnu/SHA256SUMS.part
1b89a9dc265956572226b7a1558f8cb24c6f65f490c82382cbfba16500c91d9c guix-build-db895c0e3842/output/aarch64-linux-gnu/bitcoin-db895c0e3842-aarch64-linux-gnu-debug.tar.gz
7180be8208cfad61ba6fda74d10f942769a8e3c7cbd6a141b3d53e9905d1a76f guix-build-db895c0e3842/output/aarch64-linux-gnu/bitcoin-db895c0e3842-aarch64-linux-gnu.tar.gz
459deb9325f13dc780a138e52e10f
...

💬 furszy commented on issue "rpc method removeprunedfunds should take an array of txids":
(https://github.com/bitcoin/bitcoin/issues/29466#issuecomment-2894743434)
> Can't you just make a batch RPC request?

Cannot batch wallet db writes by batching RPC requests.

💬 fanquake commented on pull request "depends: use "mkdir -p" when installing xproto":
(https://github.com/bitcoin/bitcoin/pull/32568#discussion_r2098215129)
Added a comment.

👍 ryanofsky approved a pull request: "wallet: Use `util::Error` throughout `AddWalletDescriptor` instead of returning `nullptr` for some errors"
(https://github.com/bitcoin/bitcoin/pull/32475#pullrequestreview-2854592072)
Code review ACK 785e1407b0a39fef81a7b25554aab88d4cecd66b

🤔 pablomartin4btc reviewed a pull request: "wallet: Use `util::Error` throughout `AddWalletDescriptor` instead of returning `nullptr` for some errors"
(https://github.com/bitcoin/bitcoin/pull/32475#pullrequestreview-2854602428)
Concept ACK

👍 ryanofsky approved a pull request: "Add checkBlock() to Mining interface"
(https://github.com/bitcoin/bitcoin/pull/31981#pullrequestreview-2854605689)
Code review ACK 975991571de3f11399ca01753e41753e0008b5a0. Since last review just dropped some RPC changes which were not strictly necessary and added test comments