💬 romanz commented on issue "intermittent issue in rpc_signer.py (enumeratesigners timeout)":
(https://github.com/bitcoin/bitcoin/issues/32524#issuecomment-2888369623)
Another instance: https://cirrus-ci.com/task/4688904676179968?logs=ci#L4390

💬 purpleKarrot commented on issue "test: Running thread * was not suspended. False leaks are possible.":
(https://github.com/bitcoin/bitcoin/issues/32542#issuecomment-2888371321)
CTest is instructed to pass some arguments to `test_bitcoin`: https://github.com/bitcoin/bitcoin/blob/7710a31f0cb69a04529f39840196826d0b9770ab/src/test/CMakeLists.txt#L193-L195

Maybe that is the reason? That being said, CTest has builtin support for memory checking using sanitizers.

💬 laanwj commented on pull request "[DONOTMERGE] subprocess: replace `fs::directory_iterator` with `readdir`":
(https://github.com/bitcoin/bitcoin/pull/32529#issuecomment-2888390983)
> I haven't looked at the code, but the CI passed 50 times: https://cirrus-ci.com/task/6662743735926784

Okay. So unless the original code is using `directory_iterator` wrong (which i don't think so), we can be reasonably sure there's an intermittent bug in the implementation of it on at least some libc++ versions.

👍 TheCharlatan approved a pull request: "validation: stricter internal handling of invalid blocks"
(https://github.com/bitcoin/bitcoin/pull/31405#pullrequestreview-2848281583)
Re-ACK ed172d3002da68a3ddbd5d13e7d3f0618c1378d4

💬 l0rinc commented on pull request "blocks: avoid recomputing block header hash in `ReadBlock`":
(https://github.com/bitcoin/bitcoin/pull/32487#discussion_r2094147733)
We're not always checking this, only when the index is available.
But after this change this check is for free, no need to recalculate the header's hash anymore.

📝 TheCharlatan opened a pull request: "kernel: Remove dependency on clientversion"
(https://github.com/bitcoin/bitcoin/pull/32543)
Including a Bitcoin-Core specific version does not make sense if used by external applications.

💬 romanz commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-2888466453)
Force-pushed to fix a typo in commit description.

💬 katesalazar commented on issue "Option to use dark theme for Windows":
(https://github.com/bitcoin-core/gui/issues/378#issuecomment-2888477115)
There is too low contrast on the buttons in that pic

🤔 polespinasa reviewed a pull request: "rpc: Round verificationprogress to 1 for a recent tip"
(https://github.com/bitcoin/bitcoin/pull/32528#pullrequestreview-2848344096)
cACK

💬 polespinasa commented on pull request "rpc: Round verificationprogress to 1 for a recent tip":
(https://github.com/bitcoin/bitcoin/pull/32528#discussion_r2094159634)
> In case we know there are unprocessed blocks in the chain (because we have their headers), we shouldn't say progress: 1

I agree we should not return 1 if we didn't verify the last block we know (we don't want Core to lie to users 😉)

What if we do something like:
```c++
if (pindex->nHeight == m_best_header->nHeight && pindex->nChainWork == m_best_header->nChainWork) {
const auto block_time{pindex->GetBlockTime() + Ticks<std::chrono::seconds>(2h)};
} else {
const auto block_
...

📝 theStack opened a pull request: "scripted-diff: test: remove 'descriptors=True' argument for `createwallet` calls"
(https://github.com/bitcoin/bitcoin/pull/32544)
Descriptor wallets are already created by default [since v23.0](https://github.com/bitcoin/bitcoin/blob/7710a31f0cb69a04529f39840196826d0b9770ab/doc/release-notes/release-notes-23.0.md?plain=1#L171), but since the recent legacy wallet removal the `descriptors` parameter *must* be True for the `createwallet` RPC (see commit 9f04e02ffaee0fe64027dc56c7bea3885254321a), i.e. still passing it wouldn't contain any information for test readers anymore. So simply drop them in the functional tests in orde
...

💬 1440000bytes commented on pull request "scripted-diff: test: remove 'descriptors=True' argument for `createwallet` calls":
(https://github.com/bitcoin/bitcoin/pull/32544#issuecomment-2888488756)
Concept ACK

The argument `descriptors` could also be removed from `createwallet` RPC.

🤔 tapcrafter reviewed a pull request: "init: Configure reachable networks before we start the RPC server"
(https://github.com/bitcoin/bitcoin/pull/32539#pullrequestreview-2848348655)
tACK 12ff4be9c724c752fe67835419be3ff4d0e65990

<details>

<summary>Test protocol</summary>

## Current error message on master (7710a31f0cb69a04529f39840196826d0b9770ab):

```
$ bitcoind -regtest -rpcallowip=fc00:dead:beef::/64 -rpcuser=u -rpcpassword=p

2025-05-17T16:24:29Z Command-line arg: regtest=""
2025-05-17T16:24:29Z Command-line arg: rpcallowip="fc00:dead:beef::/64"
2025-05-17T16:24:29Z Command-line arg: rpcpassword=****
2025-05-17T16:24:29Z Command-line arg: rpcuser=****

...

💬 tapcrafter commented on pull request "init: Configure reachable networks before we start the RPC server":
(https://github.com/bitcoin/bitcoin/pull/32539#discussion_r2094164033)
I'm aware brevity is probably prioritized here. But I didn't recognize RFC4193 just from its number, so had to look it up. What about "RFC4193 style IPv6 ULA addresses are only allowed..."?

💬 yancyribbens commented on pull request "doc: Add missing top-level description to pruneblockchain RPC":
(https://github.com/bitcoin/bitcoin/pull/32333#issuecomment-2888498892)
cr ACK https://github.com/bitcoin/bitcoin/pull/32333/commits/135a0f0aa711b95c50aa4cbe0c38d82d647f1c8b

Nice, didn't know this rpc existed.

💬 yancyribbens commented on issue "Migrate from BTC/kvB to sat/vB on RPC and startup options":
(https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888499988)
> Don't forget that fundrawtransaction accepts two different units, depending on snake case / camel case (!)

This seems like a bug that ought to be fixed separately?

💬 jonatack commented on issue "Migrate from BTC/kvB to sat/vB on RPC and startup options":
(https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888506000)
> Don't forget that `fundrawtransaction` accepts two different units, depending on snake case / camel case (!)

See https://github.com/bitcoin/bitcoin/pull/20483.

💬 Ashkar776 commented on issue "Migrate from BTC/kvB to sat/vB on RPC and startup options":
(https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888508710)
How to use

On Sat, 17 May, 2025, 9:38 pm Jon Atack, ***@***.***> wrote:

> *jonatack* left a comment (bitcoin/bitcoin#32093)
> <https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888506000>
>
> Don't forget that fundrawtransaction accepts two different units,
> depending on snake case / camel case (!)
>
> See #20483 <https://github.com/bitcoin/bitcoin/pull/20483>.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/32093#
...

💬 Ashkar776 commented on issue "Migrate from BTC/kvB to sat/vB on RPC and startup options":
(https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888508833)
You have tutorial video step by step

On Sat, 17 May, 2025, 9:39 pm Ashkar Asku, ***@***.***>
wrote:

> How to use
>
> On Sat, 17 May, 2025, 9:38 pm Jon Atack, ***@***.***> wrote:
>
>> *jonatack* left a comment (bitcoin/bitcoin#32093)
>> <https://github.com/bitcoin/bitcoin/issues/32093#issuecomment-2888506000>
>>
>> Don't forget that fundrawtransaction accepts two different units,
>> depending on snake case / camel case (!)
>>
>> See #20483 <https://github.com/bitcoin/bitcoin/pull
...

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2888528076)
Perhaps this should be backported to all current release branches?