💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551423215)
This is all that I'm getting as of now the program then shuts down

👍 ryanofsky approved a pull request: "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate"
(https://github.com/bitcoin/bitcoin/pull/25193#pullrequestreview-1430738915)
Code review ACK 974140f9e721740f857b45d10d7dbab62fdbbe53. Confirmed this is just a clean rebase since my last review. This needs another rebase now, but after that I would like to merge it.

📝 fanquake opened a pull request: "doc: remove Security section from build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27688)
Our compile documentation isn't the right place for genric binary hardening notes, which are neither particularly Bitcoin-Core specific, or as relevant as they might have once been, i.e non-executable stacks are now just the norm.

Just remove the notes for now, if someone has something more interesting/Bitcoin Core specific, it could be added in separate documentation in the future (maybe into the devwiki or similar).

Split from https://github.com/bitcoin/bitcoin/pull/27685#discussion_r119
...

💬 fanquake commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196552617)
Ok. Done in #27688.

💬 furszy commented on pull request "init: verify blocks data existence only once for all the indexers":
(https://github.com/bitcoin/bitcoin/pull/27607#issuecomment-1551443566)
Was about to send the updates comment hehe. I was too tired last night to write it. Thanks for the review ryanofsky!

Updates list:

- Decoupled index `Init()` from `Start()`. So indexers can be initialized without spawning the sync thread.

- Simplified the pruning violation code by re-purposing the `GetFirstStoredBlock` function. Now called `IsBlockDataAvailable`.

- Fixed a small race, where we set the index `m_synced` flag (which enables `BlockConnected` events) before calling to th
...

💬 hebasto commented on pull request "msvc: Provide `ObjectFileName` explicitly":
(https://github.com/bitcoin/bitcoin/pull/27687#issuecomment-1551446156)
> Can you explain what the issue currently is, and why this is the right fix

The issue is the file name conflict.

See https://api.cirrus-ci.com/v1/task/6646912535756800/logs/build.log:
```
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(1098,5): warning MSB8027: Two or more files with the name of util.cpp will produce outputs to the same location. This can lead to an incorrect build result. The files involved are ..\..\
...

💬 pinheadmz commented on issue "Change handling of "h" versus "'" marker for hardened derivation in descriptors":
(https://github.com/bitcoin/bitcoin/issues/15740#issuecomment-1551450881)
Closing as completed by #26076

✅ pinheadmz closed an issue: "Change handling of "h" versus "'" marker for hardened derivation in descriptors"
(https://github.com/bitcoin/bitcoin/issues/15740)

📝 fanquake opened a pull request: "doc: remove mention of glibc 2.10+"
(https://github.com/bitcoin/bitcoin/pull/27689)
We already require glibc 2.27+, so mentioning a much older version here is redundant.

💬 pinheadmz commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1551471794)
<img width="1552" alt="Screen Shot 2023-05-17 at 10 06 51 AM" src="https://github.com/bitcoin/bitcoin/assets/2084648/43139c94-d32d-4469-952b-25980242e1f6">



I've been running this branch for 7 days on a VPS and noticed this morning the CPU on b-msghand is back up to 100%. It was about that high running v24 release but dropped to 30% or so when I first switched to this branch and restarted.

📝 MarcoFalke opened a pull request: "ci: Use credits for ARM task"
(https://github.com/bitcoin/bitcoin/pull/27690)
After https://github.com/bitcoin/bitcoin/pull/27562 the task should finish in less than 10 minutes, so also using credits for it will be cheap and improve dev experience.

👋 hebasto's pull request is ready for review: "msvc: Provide `ObjectFileName` explicitly"
(https://github.com/bitcoin/bitcoin/pull/27687)

💬 hebasto commented on pull request "msvc: Provide `ObjectFileName` explicitly":
(https://github.com/bitcoin/bitcoin/pull/27687#issuecomment-1551496570)
MSVC build is [free](https://api.cirrus-ci.com/v1/task/5943704519704576/logs/build.log) from `MSB8027` now.

👍 fanquake approved a pull request: "ci: Use credits for ARM task"
(https://github.com/bitcoin/bitcoin/pull/27690#pullrequestreview-1430835654)
ACK aaaa07bc845f0b8741270552e77b9694802fb0e3 - if green

👍 fanquake approved a pull request: "doc: Rework build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27685#pullrequestreview-1430856715)
ACK fa29651c3ff3e13a42d6505b14971265562f088a

💬 hebasto commented on pull request "ci: A few fixes of `ccache` issues":
(https://github.com/bitcoin/bitcoin/pull/27084#issuecomment-1551531499)
> What is the status of this

I've analyzed the [recent](https://cirrus-ci.com/build/5086582458286080) `ccache` summaries at https://github.com/bitcoin/bitcoin/commit/a75c77ea903c100531e0fc5fde94bb9b52642145.

I don't think this PR can improve them.

✅ hebasto closed a pull request: "ci: A few fixes of `ccache` issues"
(https://github.com/bitcoin/bitcoin/pull/27084)

💬 fjahr commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#issuecomment-1551540184)
> I guess a simpler way to phrase it is: what can go wrong if [c14ae13](https://github.com/bitcoin/bitcoin/commit/c14ae132c5a5204a9a755c84c6de05fb30459221) picks the incorrect chainstate for a block? What are all the different ways in which we can receive a block? What do we expect to happen in each of these cases? Tests would be a really nice way to illustrate that, but are apparently a pain to write for net_processing.

@Sjors I have tried to create an overview of the different cases and add
...

👍 ryanofsky approved a pull request: "kernel: Remove interface_ui, util/system from kernel library"
(https://github.com/bitcoin/bitcoin/pull/27636#pullrequestreview-1430775316)
Code review ACK 0b88c307a8ed81705cf8e6fb6332fdf969eb0e2e. These changes all seem very clean and straightforward now. I left some more suggestions, but you can feel free to ignore them them

💬 ryanofsky commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1196631303)
In commit "kernel: Add fatalError method to notifications" (0b88c307a8ed81705cf8e6fb6332fdf969eb0e2e)

Would maybe make `notifications` the first parameter. It seems awkward for it to placed between the debug message and the user message.