💬 maflcko commented on pull request "rpc:generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2083970563)
It is possible to call CNB from the test-only function. Something like:

```cpp
def CNB_test()
b = CNB()
b.vtx[0].output_script = b'aa'
... etc

🤔 janb84 reviewed a pull request: "rpc: Undeprecate rpcuser/rpcpassword, store all credentials hashed in memory"
(https://github.com/bitcoin/bitcoin/pull/32423#pullrequestreview-2832467514)
reACK https://github.com/bitcoin/bitcoin/commit/e49a7274a2141dcb9e188bc4b45c2d7b928ccecd

Changes since last ACK:
- Added Enum + logic to use Enum in GenerateAuthCookieResult and InitRPCAuthentication
- the user and pass are now stored separate variables
- small change in the logwarning

Reviewed:

- Compiled & run tests ✅
- Code review ✅
- Some manual testing ✅ (Did some additional testing and weirdly enough an empty user with a password is allowed. This is consistent with the curre
...

💬 polespinasa commented on pull request "rpc:generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2084241023)
This is necessary to avoid `RegenerateCommitments` to return -1 so breaking the code.
Idk if there's a better approach to it.

💬 polespinasa commented on pull request "rpc:generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#discussion_r2084243740)
Please see 5a5ff2a20cdff56b5756fa0b6c9cbb9184f17818
Tried to follow your approach, actually it makes things easier :)

Will squash commits after ack the new approach better than the first one.

💬 juanitoddd commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2871805846)
Concept NACK

As a node runner, removing this configurations limits my sovereignty over what my node relays.

💬 Sjors commented on pull request "qt: drop unused watch-only functionality":
(https://github.com/bitcoin/bitcoin/pull/32459#discussion_r2084301483)
Dropped the file.

👋 Sjors's pull request is ready for review: "qt: drop unused watch-only functionality"
(https://github.com/bitcoin/bitcoin/pull/32459)

📝 Sjors converted_to_draft a pull request: "qt: drop unused watch-only functionality"
(https://github.com/bitcoin/bitcoin/pull/32459)
The watch-only functionality in the GUI was only used for legacy wallets. Watch-only descriptor wallets do not use this.

The only visible changes of this commit should be dropping the "Spendable:" label from the overview tab.

💬 Sjors commented on pull request "qt: drop unused watch-only functionality":
(https://github.com/bitcoin/bitcoin/pull/32459#issuecomment-2871909501)
Somehow the Date column disappeared.

✅ hebasto closed a pull request: "Add used balance to overview page"
(https://github.com/bitcoin-core/gui/pull/775)

💬 hebasto commented on pull request "Add used balance to overview page":
(https://github.com/bitcoin-core/gui/pull/775#issuecomment-2871965508)
Closing due to inactivity. Feel free to re-open.

💬 hebasto commented on issue "`used` balance should be shown on overview page":
(https://github.com/bitcoin-core/gui/issues/769#issuecomment-2871972651)
Cross-posting @luke-jr's [comment](https://github.com/bitcoin-core/gui/pull/775#issuecomment-2073729945) from https://github.com/bitcoin-core/gui/pull/775:

> What is the use case here? (And the avoid_reuse flag in general...)

💬 laanwj commented on pull request "cmake: Allow `WITH_DBUS` on all Unix-like systems":
(https://github.com/bitcoin/bitcoin/pull/32469#issuecomment-2871975207)
ACK 5b7ed460c7c181f1fd34a927a09aed36284083cb

This is conceptually correct because freedesktop DBUS is a standard for UNIX-like systems, not specifically Linux.

👍 TheCharlatan approved a pull request: "threading: drop CSemaphore in favor of c++20 std::counting_semaphore"
(https://github.com/bitcoin/bitcoin/pull/32466#pullrequestreview-2832753782)
ACK 6f7052a7b96f058568af9aed2f014ae7a25e0f68

👍 TheCharlatan approved a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2832760013)
ACK 415650cea94f5050d7c368fdf9fd9878809957e1

Guix build matches.

🤔 hebasto reviewed a pull request: "qt: drop unused watch-only functionality"
(https://github.com/bitcoin/bitcoin/pull/32459#pullrequestreview-2832784295)
Are these lines still necessary:https://github.com/bitcoin/bitcoin/blob/59e09e0fb7b4cf8f8db97c2f81a8f6f69fe6cacf/src/interfaces/wallet.h#L374-L377 ?

💬 donaldevinev1 commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2872047967)
Concept NACK - removing these limits is like saying 'because some cars are speeding we should remove the speed limit on all the roads'.

💬 hebasto commented on pull request "qt: drop unused watch-only functionality":
(https://github.com/bitcoin/bitcoin/pull/32459#discussion_r2084441564)
Where is this value used?

💬 Sjors commented on pull request "qt: drop unused watch-only functionality":
(https://github.com/bitcoin/bitcoin/pull/32459#discussion_r2084444051)
It's not, dropping it again.

💬 pinheadmz commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2872113690)
> Concept NACK - removing these limits is like saying 'because some cars are speeding we should remove the speed limit on all the roads'.

It's more like "some cars are driving idiotically slow so we'll allow them to drive on the shoulder so they bother less people"