💬 fanquake commented on pull request "ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task":
(https://github.com/bitcoin/bitcoin/pull/26388#issuecomment-1551106363)
> As https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1550459263, this seems to have removed RUN_SECURITY_TESTS for x86 too?

See #27683.

📝 hebasto opened a pull request: "Avoid lock order inversion in `Chainstate::ConnectTip` function "
(https://github.com/bitcoin/bitcoin/pull/27684)
Due to the synchronous call of `CValidationInterface::BlockChecked` a lock order inversion [happens](https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1514928912):
```
PeerManagerImpl::m_peer_mutex
|
V
Peer::TxRelay::m_tx_inventory_mutex
|
V
CTxMemPool::cs
|
V
PeerManagerImpl::m_peer_mutex
```

This PR breaks the last link.

The other possible solution is to move `CValidationInterface::BlockChecked` to a background thread (see https://github.com/bitcoin/bit
...

💬 fanquake commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1551127526)
The CI failure is unrelated, and will be fixed post-rebase. Guix currently fails to build. i.e:
```bash
time HOSTS="x86_64-apple-darwin arm64-apple-darwin" ./contrib/guix/guix-build
<snip>
Extracting libevent...
/home/ubuntu/sources/libevent-2.1.12-stable.tar.gz: OK
Preprocessing libevent...
Configuring libevent...
checking for a BSD-compatible install... /home/ubuntu/.guix-profile/bin/install -c
checking whether build environment is sane... yes
checking for x86_64-apple-darwin-strip..
...

💬 hebasto commented on pull request "ci: remove `RUN_SECURITY_TESTS`":
(https://github.com/bitcoin/bitcoin/pull/27683#issuecomment-1551132082)
> We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case).

Concept ACK on that.

💬 MarcoFalke commented on pull request "Avoid lock order inversion in `Chainstate::ConnectTip` function":
(https://github.com/bitcoin/bitcoin/pull/27684#discussion_r1196280935)
Can you explain why this is fine in the context of logical races, as well as performance-wise in the context of new thread(pools) getting spawned?

💬 hebasto commented on pull request "Avoid lock order inversion in `Chainstate::ConnectTip` function":
(https://github.com/bitcoin/bitcoin/pull/27684#discussion_r1196283047)
Is `MaybePunishNodeForBlock` performance critical?

💬 DanM3rcurius commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551144773)
Hi Hennadii,

I did, sorry i forgot to mention that.
Anything else that i miss?

sincerely,
Dan

Sent with [Proton Mail](https://proton.me/) secure email.

------- Original Message -------
On Wednesday, May 17th, 2023 at 00:21, Hennadii Stepanov ***@***.***> wrote:

>> Steps to reproduce
>>
>> Setup Raspi4 with Raspi OS installed on a bootable SSD
>> Install BDB 4.8
>> Clone bitcoin repo 24.0.1
>> configure
>
> Try to run ./autogen.sh before ./configure as it is documented [here](https://github.
...

💬 MarcoFalke commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551153545)
What are the exact steps to reproduce? Make sure to follow https://github.com/bitcoin/bitcoin/blob/24.x/doc/build-unix.md#to-build and not an external outdated random blog post from 2016. BDB isn't required for new installs, and in fact discouraged, unless you need it for a legacy wallet. New wallets use sqlite.

💬 MarcoFalke commented on pull request "Avoid lock order inversion in `Chainstate::ConnectTip` function":
(https://github.com/bitcoin/bitcoin/pull/27684#discussion_r1196294868)
Bitcoin Core is performance critical and randomly (unspecified) spawning thread(pool)s may kill performance, cause OOM, etc ...

💬 DanM3rcurius commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551160542)
Thank you for that info.
i will start from the beginning.

Sent from Proton Mail for iOS

On Wed, May 17, 2023 at 12:38, MacrabFalke ***@***.***> wrote:

> What are the exact steps to reproduce? Make sure to follow https://github.com/bitcoin/bitcoin/blob/24.x/doc/build-unix.md#to-build and not an external outdated random blog post from 2016. BDB isn't required for new installs, and in fact discouraged, unless you need it for a legacy wallet. New wallets use sqlite.
>
> —
> Reply to this email di
...

💬 DanM3rcurius commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551166508)
Why i used the blog post, because it was linked from a beginner friendly tutorial for a raspnode setup. The bitcoin docs on github are difficult for novices like me to understand and execute.

Sent from Proton Mail for iOS

On Wed, May 17, 2023 at 12:38, MacrabFalke ***@***.***> wrote:

> What are the exact steps to reproduce? Make sure to follow https://github.com/bitcoin/bitcoin/blob/24.x/doc/build-unix.md#to-build and not an external outdated random blog post from 2016. BDB isn't required for
...

💬 hebasto commented on pull request "Avoid lock order inversion in `Chainstate::ConnectTip` function":
(https://github.com/bitcoin/bitcoin/pull/27684#discussion_r1196311522)
Then #18963 should be a better approach.

💬 MarcoFalke commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551182308)
Ok, I'll try to simplify them. You should be able to just follow the section for "Debian/Ubuntu".

💬 ccdle12 commented on pull request "net, refactor: extract Network and BIP155Network logic to node/network":
(https://github.com/bitcoin/bitcoin/pull/27385#discussion_r1196330262)
Could be a candidate for another PR - since we are changing `SOCKS5Atyp` to an enum class, would it make sense to also change the following enums to enum classes `SOCKSVersion, SOCKS5Command, SOCKS5Method` and `SOCKS5Reply`?

💬 DanM3rcurius commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551201282)
Many thanks! I'll share my noob-pov experience with the tutorial once core is running.

Sincerely,
Dan

Sent with [Proton Mail](https://proton.me/) secure email.

------- Original Message -------
On Wednesday, May 17th, 2023 at 12:59, MacrabFalke ***@***.***> wrote:

> Ok, I'll try to simplify them. You should be able to just follow the section for "Debian/Ubuntu".
>
> —
> Reply to this email directly, [view it on GitHub](https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551182308),
...

📝 MarcoFalke opened a pull request: "doc: Rework build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27685)
The doc has many issues:

* The fist section contains outdated non-existing and confusing configure flags like `--enable-cxx` and `--disable-shared`, as well as edge-case expert options such as `BDB_PREFIX`. Fix that by removing the section and adding notes elsewhere, if applicable.
* There are links to the depends system before instructions on how to simply build from system packages. Fix that by moving that later.

💬 svanstaa commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1551252948)
Concept ACK

💬 MarcoFalke commented on issue "Can't compile v24.0.1":
(https://github.com/bitcoin/bitcoin/issues/27680#issuecomment-1551257895)
ok, sgtm

💬 hebasto commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551266534)
Observing the same issue -- https://cirrus-ci.com/task/6646912535756800

:(

💬 MarcoFalke commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551271233)
Anything holding back https://github.com/bitcoin/bitcoin/pull/27571 ?